{"id":9229,"url":"https://patchwork.libcamera.org/api/1.1/patches/9229/?format=json","web_url":"https://patchwork.libcamera.org/patch/9229/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200805151507.227503-3-kieran.bingham@ideasonboard.com>","date":"2020-08-05T15:14:56","name":"[libcamera-devel,v4,02/13] libcamera: formats: add numPlanes helper","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"83afe7d820585f9883b7e924af61fb56f023bbf2","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9229/mbox/","series":[{"id":1198,"url":"https://patchwork.libcamera.org/api/1.1/series/1198/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1198","date":"2020-08-05T15:14:54","name":"android: JPEG support","version":4,"mbox":"https://patchwork.libcamera.org/series/1198/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9229/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9229/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07A49BD87B\n\tfor ;\n\tWed, 5 Aug 2020 15:15:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BD9F460745;\n\tWed, 5 Aug 2020 17:15:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B5E5A60392\n\tfor ;\n\tWed, 5 Aug 2020 17:15:11 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 389ACA5E;\n\tWed, 5 Aug 2020 17:15:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gcVmEgdo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596640511;\n\tbh=m5BBFcRsKZ1wbFyRcIpoeZeom2pKehtEEUeN9KVELjw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gcVmEgdoWnOe8KaYIi+kzElGh+glNiWxwfJMUaKk6QVxObQ7aptgDGrf4k90JbOK5\n\treyCjEiocGhBN232e4bjnRX8R/mOqzZ16uW1v0TuTcBUFfHe4LRnSDNEyee70b08zF\n\tmDdHBgzXr3uryGPfGtvdVizQvA6ELsFMsc4PvLWc=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 5 Aug 2020 16:14:56 +0100","Message-Id":"<20200805151507.227503-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200805151507.227503-1-kieran.bingham@ideasonboard.com>","References":"<20200805151507.227503-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 02/13] libcamera: formats: add\n\tnumPlanes helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Determine the number of planes used by a format by counting the number\nof PixelFormatPlaneInfo entries with a valid entry.\n\nReviewed-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \nSigned-off-by: Kieran Bingham \n\n---\nv3:\n - Rename $SUBJECT :D\n\nv2:\n - Rename to numPlanes\n - Simplify fucntion doc.\n\n include/libcamera/internal/formats.h | 2 ++\n src/libcamera/formats.cpp | 18 ++++++++++++++++++\n 2 files changed, 20 insertions(+)","diff":"diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\nindex b8e474916378..51a8a6b8b0ae 100644\n--- a/include/libcamera/internal/formats.h\n+++ b/include/libcamera/internal/formats.h\n@@ -46,6 +46,8 @@ public:\n \tunsigned int frameSize(const Size &size,\n \t\t\t const std::array &strides) const;\n \n+\tunsigned int numPlanes() const;\n+\n \t/* \\todo Add support for non-contiguous memory planes */\n \tconst char *name;\n \tPixelFormat format;\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex a51e96810aed..ebaae9be3d75 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -821,4 +821,22 @@ PixelFormatInfo::frameSize(const Size &size,\n \treturn sum;\n }\n \n+/**\n+ * \\brief Retrieve the number of planes represented by the format\n+ * \\return The number of planes used by the format\n+ */\n+unsigned int PixelFormatInfo::numPlanes() const\n+{\n+\tunsigned int count = 0;\n+\n+\tfor (const PixelFormatPlaneInfo &p : planes) {\n+\t\tif (p.bytesPerGroup == 0)\n+\t\t\tbreak;\n+\n+\t\tcount++;\n+\t}\n+\n+\treturn count;\n+}\n+\n } /* namespace libcamera */\n","prefixes":["libcamera-devel","v4","02/13"]}