{"id":9212,"url":"https://patchwork.libcamera.org/api/1.1/patches/9212/?format=json","web_url":"https://patchwork.libcamera.org/patch/9212/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200805104900.2172763-6-niklas.soderlund@ragnatech.se>","date":"2020-08-05T10:48:56","name":"[libcamera-devel,v8,5/9] libcamera: camera_sensor: Add accessors for sensor ID","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c5090e8019dbf5afcfaed627e7f805379dda5372","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9212/mbox/","series":[{"id":1192,"url":"https://patchwork.libcamera.org/api/1.1/series/1192/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1192","date":"2020-08-05T10:48:51","name":"libcamera: Generate unique and stable camera IDs","version":8,"mbox":"https://patchwork.libcamera.org/series/1192/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9212/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9212/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 025B8BD87B\n\tfor ;\n\tWed, 5 Aug 2020 10:49:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2158E605AE;\n\tWed, 5 Aug 2020 12:49:17 +0200 (CEST)","from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EC39C6055E\n\tfor ;\n\tWed, 5 Aug 2020 12:49:15 +0200 (CEST)","from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 4d3302b5-d709-11ea-a39b-005056917f90;\n\tWed, 05 Aug 2020 12:49:15 +0200 (CEST)"],"X-Halon-ID":"4d3302b5-d709-11ea-a39b-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 5 Aug 2020 12:48:56 +0200","Message-Id":"<20200805104900.2172763-6-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200805104900.2172763-1-niklas.soderlund@ragnatech.se>","References":"<20200805104900.2172763-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v8 5/9] libcamera: camera_sensor: Add\n\taccessors for sensor ID","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add an accessors so that the sensor ID can be used outside CameraSensor.\n\nSigned-off-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \nReviewed-by: Jacopo Mondi \n---\n include/libcamera/internal/camera_sensor.h | 1 +\n src/libcamera/camera_sensor.cpp | 10 ++++++++++\n 2 files changed, 11 insertions(+)","diff":"diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex 0f65fca46877e89a..b9eba89f00fba882 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -47,6 +47,7 @@ public:\n \tint init();\n \n \tconst std::string &model() const { return model_; }\n+\tconst std::string &id() const { return id_; }\n \tconst MediaEntity *entity() const { return entity_; }\n \tconst std::vector &mbusCodes() const { return mbusCodes_; }\n \tconst std::vector &sizes() const { return sizes_; }\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 695c4ad0028d5c4c..2c2db051f8e264c7 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -291,6 +291,16 @@ int CameraSensor::init()\n * \\return The sensor model name\n */\n \n+/**\n+ * \\fn CameraSensor::id()\n+ * \\brief Retrieve the sensor ID\n+ *\n+ * The sensor ID is a free-form string that uniquely identifies the sensor in\n+ * the system. The ID satisfy the requirements to be used as a camera ID.\n+ *\n+ * \\return The sensor ID\n+ */\n+\n /**\n * \\fn CameraSensor::entity()\n * \\brief Retrieve the sensor media entity\n","prefixes":["libcamera-devel","v8","5/9"]}