{"id":9203,"url":"https://patchwork.libcamera.org/api/1.1/patches/9203/?format=json","web_url":"https://patchwork.libcamera.org/patch/9203/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200804214711.177645-11-kieran.bingham@ideasonboard.com>","date":"2020-08-04T21:47:08","name":"[libcamera-devel,v3,10/13] android: camera_device: Report configuration changes from validate()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a2f02f5720099d31a5e43ec76e6a3237003f6633","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9203/mbox/","series":[{"id":1191,"url":"https://patchwork.libcamera.org/api/1.1/series/1191/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1191","date":"2020-08-04T21:46:58","name":"android: JPEG support","version":3,"mbox":"https://patchwork.libcamera.org/series/1191/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9203/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9203/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A04A1BD87A\n\tfor ;\n\tTue, 4 Aug 2020 21:47:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E2E3605AB;\n\tTue, 4 Aug 2020 23:47:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7415C6055E\n\tfor ;\n\tTue, 4 Aug 2020 23:47:20 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F2D6AD5F;\n\tTue, 4 Aug 2020 23:47:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p3PyiuAC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596577640;\n\tbh=xSWyxn4rUgI7fXZbQWv7uKbOnOr9mMB61KLdspvcDKQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=p3PyiuACI98b3n7LD4lihjm+2kgNQjDx5z3kaLhXDzXBRfnCJo/3JOwOt3oOzqCGn\n\tN3wCA1LaDqa0c0KNj11TTJE5QdKW7Izpu+hOFpoB7/jZANxuRPEY2sl4Mgku05Ix7i\n\tza6J7mruq/udBxwdSxn6L3px1GLolc3M6Yb4D9rs=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Tue, 4 Aug 2020 22:47:08 +0100","Message-Id":"<20200804214711.177645-11-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200804214711.177645-1-kieran.bingham@ideasonboard.com>","References":"<20200804214711.177645-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 10/13] android: camera_device: Report\n\tconfiguration changes from validate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When we call validate on a configuration, if there are any adjustments\non the configuration, we fail without showing why.\n\nDisplay the stream configuration after the validate stage to aid\ndebugging stream startup failures.\n\nReviewed-by: Jacopo Mondi \nSigned-off-by: Kieran Bingham \n---\n src/android/camera_device.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 5899154b3e78..4178db952846 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1047,7 +1047,11 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \tcase CameraConfiguration::Valid:\n \t\tbreak;\n \tcase CameraConfiguration::Adjusted:\n-\t\tLOG(HAL, Info) << \"Camera configuration adjusted\";\n+\t\tLOG(HAL, Info) << \"Camera configuration adjusted:\";\n+\n+\t\tfor (const StreamConfiguration &cfg : *config_)\n+\t\t\tLOG(HAL, Info) << \" : \" << cfg.toString();\n+\n \t\tconfig_.reset();\n \t\treturn -EINVAL;\n \tcase CameraConfiguration::Invalid:\n","prefixes":["libcamera-devel","v3","10/13"]}