{"id":9200,"url":"https://patchwork.libcamera.org/api/1.1/patches/9200/?format=json","web_url":"https://patchwork.libcamera.org/patch/9200/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200804214711.177645-8-kieran.bingham@ideasonboard.com>","date":"2020-08-04T21:47:05","name":"[libcamera-devel,v3,07/13] android: camera_device: Report an error in notifyError()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6a6f80239b8efe7f32ac228987adb428ccadcba1","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9200/mbox/","series":[{"id":1191,"url":"https://patchwork.libcamera.org/api/1.1/series/1191/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1191","date":"2020-08-04T21:46:58","name":"android: JPEG support","version":3,"mbox":"https://patchwork.libcamera.org/series/1191/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9200/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9200/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47AECBD87A\n\tfor ;\n\tTue, 4 Aug 2020 21:47:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 152A46059F;\n\tTue, 4 Aug 2020 23:47:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 474A76054E\n\tfor ;\n\tTue, 4 Aug 2020 23:47:19 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AFB10D39;\n\tTue, 4 Aug 2020 23:47:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oZ8DRloP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596577639;\n\tbh=r1dCq+bzrAWmHf089Bgrm4j0rwbtXHY5NscqEZFu/9Y=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=oZ8DRloPUZnHSHkA1/6aw1Eq5/TNhqOVdVEApuJmsMtobkBLidZYEAfiAgsSt7e0n\n\t9FMY8gMpVgSbWQeSmlIqFkiNoLQ7qyl3lDzWjcJVcdP5n8CEtoy+SghsDwlmU+I7go\n\tYBPEyG2HSMG5vjG1KfSIpFkwdVydIDUiASHyXX9k=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Tue, 4 Aug 2020 22:47:05 +0100","Message-Id":"<20200804214711.177645-8-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200804214711.177645-1-kieran.bingham@ideasonboard.com>","References":"<20200804214711.177645-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 07/13] android: camera_device: Report\n\tan error in notifyError()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If an error is generated, try to be verbose about it in the libcamera logs.\n\nReviewed-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \nSigned-off-by: Kieran Bingham \n\n---\nv2:\n - Add todo to note possible debug info expansion\n - Fix typo\n - Print .toString() formatted pixel format\n\nv3:\n - Remove colon from todo:\n---\n src/android/camera_device.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 84d8c32a90c2..e4dce680d46f 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1258,6 +1258,13 @@ void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream)\n {\n \tcamera3_notify_msg_t notify = {};\n \n+\t/*\n+\t * \\todo Report and identify the stream number or configuration to\n+\t * clarify the stream that failed.\n+\t */\n+\tLOG(HAL, Error) << \"Error occurred on frame \" << frameNumber << \" (\"\n+\t\t\t<< toPixelFormat(stream->format).toString() << \")\";\n+\n \tnotify.type = CAMERA3_MSG_ERROR;\n \tnotify.message.error.error_stream = stream;\n \tnotify.message.error.frame_number = frameNumber;\n","prefixes":["libcamera-devel","v3","07/13"]}