{"id":9134,"url":"https://patchwork.libcamera.org/api/1.1/patches/9134/?format=json","web_url":"https://patchwork.libcamera.org/patch/9134/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200802225023.346784-1-niklas.soderlund@ragnatech.se>","date":"2020-08-02T22:50:23","name":"[libcamera-devel] libcamera: device_enumerator_udev: Align class final declaration with sysfs subclass","commit_ref":"f0f297c5f26d2e87b9ce819973beac47f361c7ee","pull_url":null,"state":"accepted","archived":false,"hash":"b49acf5011d3f6e5c70916fb45f162bdbbe462be","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9134/mbox/","series":[{"id":1177,"url":"https://patchwork.libcamera.org/api/1.1/series/1177/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1177","date":"2020-08-02T22:50:23","name":"[libcamera-devel] libcamera: device_enumerator_udev: Align class final declaration with sysfs subclass","version":1,"mbox":"https://patchwork.libcamera.org/series/1177/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9134/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9134/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C8E3BD87A\n\tfor ;\n\tSun, 2 Aug 2020 22:50:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1BDE2609B2;\n\tMon, 3 Aug 2020 00:50:47 +0200 (CEST)","from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9569060398\n\tfor ;\n\tMon, 3 Aug 2020 00:50:45 +0200 (CEST)","from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 954c2805-d512-11ea-933e-005056917a89;\n\tMon, 03 Aug 2020 00:50:42 +0200 (CEST)"],"X-Halon-ID":"954c2805-d512-11ea-933e-005056917a89","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 3 Aug 2020 00:50:23 +0200","Message-Id":"<20200802225023.346784-1-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.28.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] libcamera: device_enumerator_udev: Align\n\tclass final declaration with sysfs subclass","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Instead of marking each individual overloaded function with final mark\nthe whole class as final. This aligns the sysfs and udev based\nDeviceEnumerator implementations.\n\nSigned-off-by: Niklas Söderlund \n---\n include/libcamera/internal/device_enumerator_udev.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/include/libcamera/internal/device_enumerator_udev.h b/include/libcamera/internal/device_enumerator_udev.h\nindex 2e7916a0b280f60d..6f45be0c1c423d02 100644\n--- a/include/libcamera/internal/device_enumerator_udev.h\n+++ b/include/libcamera/internal/device_enumerator_udev.h\n@@ -26,14 +26,14 @@ class EventNotifier;\n class MediaDevice;\n class MediaEntity;\n \n-class DeviceEnumeratorUdev : public DeviceEnumerator\n+class DeviceEnumeratorUdev final : public DeviceEnumerator\n {\n public:\n \tDeviceEnumeratorUdev();\n \t~DeviceEnumeratorUdev();\n \n-\tint init() final;\n-\tint enumerate() final;\n+\tint init();\n+\tint enumerate();\n \n private:\n \tusing DependencyMap = std::map>;\n","prefixes":["libcamera-devel"]}