{"id":9077,"url":"https://patchwork.libcamera.org/api/1.1/patches/9077/?format=json","web_url":"https://patchwork.libcamera.org/patch/9077/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200729120212.499788-1-kieran.bingham@ideasonboard.com>","date":"2020-07-29T12:02:12","name":"[libcamera-devel] libcamera: FrameBuffer: Correct Buffer references","commit_ref":"000257a707fed083c6b9ed95d9497ba709cf6f30","pull_url":null,"state":"accepted","archived":false,"hash":"a785c8703f9170563f84cefcf7d1361a2eef6afe","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9077/mbox/","series":[{"id":1164,"url":"https://patchwork.libcamera.org/api/1.1/series/1164/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1164","date":"2020-07-29T12:02:12","name":"[libcamera-devel] libcamera: FrameBuffer: Correct Buffer references","version":1,"mbox":"https://patchwork.libcamera.org/series/1164/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9077/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9077/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 931AFBD878\n\tfor ;\n\tWed, 29 Jul 2020 12:02:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 21C5C613C6;\n\tWed, 29 Jul 2020 14:02:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6ABC76039D\n\tfor ;\n\tWed, 29 Jul 2020 14:02:18 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7936331F;\n\tWed, 29 Jul 2020 14:02:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cSJ+lZb5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596024137;\n\tbh=p3GYOETfq7zaK1nby58m0hPj49ERLVLe2xULcKG3+XU=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=cSJ+lZb5OkfJHgh2eiDU6MnhlQolxYOcAcctA1bcAgR2+RGxzfjttQvK+B+Q7icfE\n\tRpktOPpx4sxQhF5ZiQmRHmIKnSqcR3Eskg+4zzK7t0QviCSadETl6jgYCmigttsPSD\n\tAIRnd3YRTSvot0bhoLM2zanumxp6Wy8Zrv7XubTg=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 29 Jul 2020 13:02:12 +0100","Message-Id":"<20200729120212.499788-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] libcamera: FrameBuffer: Correct Buffer\n\treferences","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Update the remaining (capitalised) Buffer references to the new FrameBuffer\nobject that they refer to.\n\nLower-case 'buffer' terms are kept, as a generic reference to a buffer\nrather than the specific type 'FrameBuffer'.\n\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/buffer.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\nindex 0fe12ab93b58..500d1cf791e7 100644\n--- a/src/libcamera/buffer.cpp\n+++ b/src/libcamera/buffer.cpp\n@@ -174,11 +174,11 @@ FrameBuffer::FrameBuffer(const std::vector &planes, unsigned int cookie)\n * The intended callers of this method are buffer completion handlers that\n * need to associate a buffer to the request it belongs to.\n *\n- * A Buffer is associated to a request by Request::addBuffer() and the\n+ * A FrameBuffer is associated to a request by Request::addBuffer() and the\n * association is valid until the buffer completes. The returned request\n * pointer is valid only during that interval.\n *\n- * \\return The Request the Buffer belongs to, or nullptr if the buffer is\n+ * \\return The Request the FrameBuffer belongs to, or nullptr if the buffer is\n * not associated with a request\n */\n \n@@ -224,7 +224,7 @@ FrameBuffer::FrameBuffer(const std::vector &planes, unsigned int cookie)\n \n /**\n * \\brief Copy the contents from another buffer\n- * \\param[in] src Buffer to copy\n+ * \\param[in] src FrameBuffer to copy\n *\n * Copy the buffer contents and metadata from \\a src to this buffer. The\n * destination FrameBuffer shall have the same number of planes as the source\n","prefixes":["libcamera-devel"]}