{"id":9049,"url":"https://patchwork.libcamera.org/api/1.1/patches/9049/?format=json","web_url":"https://patchwork.libcamera.org/patch/9049/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200728234225.3505868-1-niklas.soderlund@ragnatech.se>","date":"2020-07-28T23:42:21","name":"[libcamera-devel,v3,1/5] libcamera: v4l2_device: Add method to lookup device path","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ad7352b096d1c4b58c086faff5a92d4fe0ccdaec","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9049/mbox/","series":[{"id":1158,"url":"https://patchwork.libcamera.org/api/1.1/series/1158/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1158","date":"2020-07-28T23:37:39","name":"libcamera: Generate unique and stable camera names","version":3,"mbox":"https://patchwork.libcamera.org/series/1158/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9049/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9049/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 212F1BD86F\n\tfor ;\n\tTue, 28 Jul 2020 23:42:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0AFC2617C8;\n\tWed, 29 Jul 2020 01:42:40 +0200 (CEST)","from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A52CB60535\n\tfor ;\n\tWed, 29 Jul 2020 01:42:38 +0200 (CEST)","from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 000ee37c-d12c-11ea-8fb8-005056917f90;\n\tWed, 29 Jul 2020 01:42:37 +0200 (CEST)"],"X-Halon-ID":"000ee37c-d12c-11ea-8fb8-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 29 Jul 2020 01:42:21 +0200","Message-Id":"<20200728234225.3505868-1-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200728233744.3503740-1-niklas.soderlund@ragnatech.se>","References":"<20200728233744.3503740-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 1/5] libcamera: v4l2_device: Add method\n\tto lookup device path","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a method to lookup a V4L2 devices path in sysfs.\n\nSigned-off-by: Niklas Söderlund \n---\n include/libcamera/internal/v4l2_device.h | 1 +\n src/libcamera/v4l2_device.cpp | 24 ++++++++++++++++++++++++\n 2 files changed, 25 insertions(+)","diff":"diff --git a/include/libcamera/internal/v4l2_device.h b/include/libcamera/internal/v4l2_device.h\nindex bf643f2ec966bb33..3b605aab343b3b94 100644\n--- a/include/libcamera/internal/v4l2_device.h\n+++ b/include/libcamera/internal/v4l2_device.h\n@@ -30,6 +30,7 @@ public:\n \tint setControls(ControlList *ctrls);\n \n \tconst std::string &deviceNode() const { return deviceNode_; }\n+\tstd::string devicePath() const;\n \n protected:\n \tV4L2Device(const std::string &deviceNode);\ndiff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 56ea1ddda2c1425f..c186f246dbfaff66 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -9,6 +9,7 @@\n \n #include \n #include \n+#include \n #include \n #include \n #include \n@@ -350,6 +351,29 @@ int V4L2Device::setControls(ControlList *ctrls)\n \treturn ret;\n }\n \n+/**\n+ * \\brief Retrieve the device path\n+ *\n+ * The device path describes the device backing the V4L2 device.\n+ *\n+ * \\todo When switching to C++17 use std::filesystem:: in the implementation.\n+ * \\todo Query udev for this information as the path created for vdev here\n+ * migh not be correct.\n+ *\n+ * \\return The device path\n+ */\n+std::string V4L2Device::devicePath() const\n+{\n+\tstd::string vdev = basename(deviceNode_.c_str());\n+\tstd::string sysfs = \"/sys/class/video4linux/\" + vdev + \"/device\";\n+\n+\tchar path[PATH_MAX];\n+\tif (!realpath(sysfs.c_str(), path))\n+\t\tLOG(V4L2, Fatal) << \"Can not resolve path for \" << deviceNode_;\n+\n+\treturn path;\n+}\n+\n /**\n * \\brief Perform an IOCTL system call on the device node\n * \\param[in] request The IOCTL request code\n","prefixes":["libcamera-devel","v3","1/5"]}