{"id":9045,"url":"https://patchwork.libcamera.org/api/1.1/patches/9045/?format=json","web_url":"https://patchwork.libcamera.org/patch/9045/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200728185548.3361465-2-niklas.soderlund@ragnatech.se>","date":"2020-07-28T18:55:46","name":"[libcamera-devel,1/3] android: camera_device: Skip instead of fail if camera don't support format","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"424d2ba50fc4cfcea5beef3185d2928acbeb3aa1","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9045/mbox/","series":[{"id":1157,"url":"https://patchwork.libcamera.org/api/1.1/series/1157/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1157","date":"2020-07-28T18:55:45","name":"android: camera_device: Add RAW support","version":1,"mbox":"https://patchwork.libcamera.org/series/1157/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9045/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9045/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F21ABD86F\n\tfor ;\n\tTue, 28 Jul 2020 18:56:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 351FF611A2;\n\tTue, 28 Jul 2020 20:56:10 +0200 (CEST)","from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7327060923\n\tfor ;\n\tTue, 28 Jul 2020 20:56:07 +0200 (CEST)","from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid fdd9785b-d103-11ea-8fb8-005056917f90;\n\tTue, 28 Jul 2020 20:56:06 +0200 (CEST)"],"X-Halon-ID":"fdd9785b-d103-11ea-8fb8-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 28 Jul 2020 20:55:46 +0200","Message-Id":"<20200728185548.3361465-2-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200728185548.3361465-1-niklas.soderlund@ragnatech.se>","References":"<20200728185548.3361465-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 1/3] android: camera_device: Skip instead\n\tof fail if camera don't support format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If the libcamera Camera don't support the Android format do not fail the\ninitialization. Instead skip adding the Android format to the list of\nsupported formats reported.\n\nThis allows extending the camera3FormatsMap with Android formats not\nsupported by all libcamera Cameras and probe and report only the ones\nthat overlap.\n\nSigned-off-by: Niklas Söderlund \n---\n src/android/camera_device.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex b49d6681e5a52d32..265627a98422bd67 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -282,10 +282,10 @@ int CameraDevice::initializeStreamConfigurations()\n \t\t\t}\n \t\t}\n \t\tif (!mappedFormat.isValid()) {\n-\t\t\tLOG(HAL, Error) << \"Failed to map Android format \"\n+\t\t\tLOG(HAL, Debug) << \"Failed to map Android format \"\n \t\t\t\t\t<< camera3Format.name << \" (\"\n \t\t\t\t\t<< utils::hex(androidFormat) << \")\";\n-\t\t\treturn -EINVAL;\n+\t\t\tcontinue;\n \t\t}\n \n \t\t/*\n","prefixes":["libcamera-devel","1/3"]}