{"id":9020,"url":"https://patchwork.libcamera.org/api/1.1/patches/9020/?format=json","web_url":"https://patchwork.libcamera.org/patch/9020/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200727151820.24466-4-kgupta@es.iitr.ac.in>","date":"2020-07-27T15:18:20","name":"[libcamera-devel,v3,3/3] libcamera: stream_option: use format name to set cam/qcam format","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"831a8732b2adb134950aa3070aada7d64cf39981","submitter":{"id":39,"url":"https://patchwork.libcamera.org/api/1.1/people/39/?format=json","name":"Kaaira Gupta","email":"kgupta@es.iitr.ac.in"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9020/mbox/","series":[{"id":1152,"url":"https://patchwork.libcamera.org/api/1.1/series/1152/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1152","date":"2020-07-27T15:18:17","name":"Enable formats lookup based on name","version":3,"mbox":"https://patchwork.libcamera.org/series/1152/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9020/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9020/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7FC38BD878\n\tfor ;\n\tMon, 27 Jul 2020 15:18:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4ED35613D2;\n\tMon, 27 Jul 2020 17:18:51 +0200 (CEST)","from mail-pf1-x443.google.com (mail-pf1-x443.google.com\n\t[IPv6:2607:f8b0:4864:20::443])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E0F66118A\n\tfor ;\n\tMon, 27 Jul 2020 17:18:49 +0200 (CEST)","by mail-pf1-x443.google.com with SMTP id s26so9228790pfm.4\n\tfor ;\n\tMon, 27 Jul 2020 08:18:49 -0700 (PDT)","from kaaira-HP-Pavilion-Notebook ([103.113.213.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tq24sm14784792pgg.3.2020.07.27.08.18.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 27 Jul 2020 08:18:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=es-iitr-ac-in.20150623.gappssmtp.com\n\theader.i=@es-iitr-ac-in.20150623.gappssmtp.com\n\theader.b=\"qCRaCI+q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Vujycd8EPvoebCgjNl2OyNBkTEe2zGIFJY2qcVv2RBk=;\n\tb=qCRaCI+qcPA1rrJBhngpz+H7PKYfcQ+AxlIxWVhh+qobqWEgF0qMDdQtVBAHnFDr71\n\t2ItFaEF9S8O/g18DNNA9gk592j0191JPtGl5fdG4i4K50aztu4ALOS2rN37u+wvenBAZ\n\tE2LmZZfXhlryIVcU2Wr3kRq0D9ECF0cWLyrM0+wDOXrj5KtYRTgjrDT3OLl1x54i6hjl\n\txrSoIqRyAAL/XsA6AF/+cQ7Ocrp3seHly/38EL4eM4muBHf0TM4hQjs2J6sFM6cS2xm5\n\thTKHUDyZTBfJeKe5RMqhERyJIdsMeDSMLxwWra0Hc8NxT/95gDGokMKBQDEMRm1081yM\n\t25GQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Vujycd8EPvoebCgjNl2OyNBkTEe2zGIFJY2qcVv2RBk=;\n\tb=HNgZOZzMtWG2rQ7w+ddanRCX63IATZz1p2yeBwkosl2vwZp1S/lTg7ZXMXUZSdd1sM\n\tTPDmFT87sD/M+Dv/SMhiGb2wlfvdi4nA3VtkqvQNxJo/EXqX/qPUXn33IXEPJJJ+AkNH\n\t0MazTF9wfjUFNGOKH0L746CSpR9y+vADNPE0Isk5cIUSEra9M9DQtbTbwmrkVZ6H56Ns\n\tHN14XkYQR4qVONGIhLbikQYwGaL3k/gGYgrFSmwX8Nz/3PoL59h7e8zo4krQokQj2zvn\n\t/tw8DqaqloDFtC1xsPEjGdYUPUvLJbxGWPP+p1OngsOz7af5moTgDRFHFa7SijeE0leq\n\tQW+A==","X-Gm-Message-State":"AOAM5330eveITMp2gbCTmcCZhNklYFS25gByastpS+isp9WxqF8sSN6q\n\tt1T2tqMd6hvORfqqPSiK0hSSvB3GN9s=","X-Google-Smtp-Source":"ABdhPJxnMmOTSauMtDrfFD4cIpW+AAJ4qrHFxZ4HSlyldcbiw7IWbyAiRVncD4Sv3Qh2auXOjAf2xg==","X-Received":"by 2002:a63:4144:: with SMTP id o65mr20061672pga.8.1595863128005;\n\tMon, 27 Jul 2020 08:18:48 -0700 (PDT)","From":"Kaaira Gupta ","To":"libcamera-devel@lists.libcamera.org, Kieran Bingham\n\t, =?utf-8?q?Niklas_S=C3=B6derlund?=\n\t","Date":"Mon, 27 Jul 2020 20:48:20 +0530","Message-Id":"<20200727151820.24466-4-kgupta@es.iitr.ac.in>","X-Mailer":"git-send-email 2.17.1","In-Reply-To":"<20200727151820.24466-1-kgupta@es.iitr.ac.in>","References":"<20200727151820.24466-1-kgupta@es.iitr.ac.in>","Subject":"[libcamera-devel] [PATCH v3 3/3] libcamera: stream_option: use\n\tformat name to set cam/qcam format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kaaira Gupta ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Replace hex input for pixel formats with their format names, for input in\ncam and qcam.\nHence, remove the todo.\n\nSigned-off-by: Kaaira Gupta \n---\n src/cam/stream_options.cpp | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/src/cam/stream_options.cpp b/src/cam/stream_options.cpp\nindex bd12c8f..4168e5d 100644\n--- a/src/cam/stream_options.cpp\n+++ b/src/cam/stream_options.cpp\n@@ -19,7 +19,7 @@ StreamKeyValueParser::StreamKeyValueParser()\n \t\t ArgumentRequired);\n \taddOption(\"height\", OptionInteger, \"Height in pixels\",\n \t\t ArgumentRequired);\n-\taddOption(\"pixelformat\", OptionInteger, \"Pixel format\",\n+\taddOption(\"pixelformat\", OptionString, \"Pixel format name\",\n \t\t ArgumentRequired);\n }\n \n@@ -95,9 +95,8 @@ int StreamKeyValueParser::updateConfiguration(CameraConfiguration *config,\n \t\t\tcfg.size.height = opts[\"height\"];\n \t\t}\n \n-\t\t/* \\todo Translate 4CC string to pixelformat with modifier. */\n \t\tif (opts.isSet(\"pixelformat\"))\n-\t\t\tcfg.pixelFormat = PixelFormat(opts[\"pixelformat\"]);\n+\t\t\tcfg.pixelFormat = PixelFormat::fromString(opts[\"pixelformat\"].toString());\n \t}\n \n \treturn 0;\n","prefixes":["libcamera-devel","v3","3/3"]}