{"id":9003,"url":"https://patchwork.libcamera.org/api/1.1/patches/9003/?format=json","web_url":"https://patchwork.libcamera.org/patch/9003/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200725144058.129388-4-jacopo@jmondi.org>","date":"2020-07-25T14:40:55","name":"[libcamera-devel,v2,3/6] andrdid: camera_device: Store const templates","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a7ee7a99243d5774a055b81c546e0b3d9c6a0950","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9003/mbox/","series":[{"id":1146,"url":"https://patchwork.libcamera.org/api/1.1/series/1146/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1146","date":"2020-07-25T14:40:52","name":"android: camera_device: Generate correct preview template","version":2,"mbox":"https://patchwork.libcamera.org/series/1146/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9003/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9003/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E54A4BD86F\n\tfor ;\n\tSat, 25 Jul 2020 14:37:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C0D62613AA;\n\tSat, 25 Jul 2020 16:37:31 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87E51611A2\n\tfor ;\n\tSat, 25 Jul 2020 16:37:28 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id D39A1240004;\n\tSat, 25 Jul 2020 14:37:27 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 25 Jul 2020 16:40:55 +0200","Message-Id":"<20200725144058.129388-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200725144058.129388-1-jacopo@jmondi.org>","References":"<20200725144058.129388-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 3/6] andrdid: camera_device: Store\n\tconst templates","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The request capture templates stored in the\nCameraDevice::requestTemplates_ should not be modified once created.\n\nStore a const pointer to the request templates in the class member\nmap.\n\nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 5b8b9c3e26e2..af1b58ab6b4e 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -95,7 +95,7 @@ private:\n \tstd::unique_ptr config_;\n \n \tCameraMetadata *staticMetadata_;\n-\tstd::map requestTemplates_;\n+\tstd::map requestTemplates_;\n \tconst camera3_callback_ops_t *callbacks_;\n \n \tstd::vector streamConfigurations_;\n","prefixes":["libcamera-devel","v2","3/6"]}