{"id":898,"url":"https://patchwork.libcamera.org/api/1.1/patches/898/?format=json","web_url":"https://patchwork.libcamera.org/patch/898/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190403080148.11479-13-jacopo@jmondi.org>","date":"2019-04-03T08:01:47","name":"[libcamera-devel,v8,12/13] libcamera: ipu3: Limit resolution to 2560x1920","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8374f021ebb3e136fb9b147dd281a910c826041d","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/898/mbox/","series":[{"id":235,"url":"https://patchwork.libcamera.org/api/1.1/series/235/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=235","date":"2019-04-03T08:01:35","name":"libcamera: ipu3: Add ImgU support","version":8,"mbox":"https://patchwork.libcamera.org/series/235/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/898/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/898/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D9F6D611AB\n\tfor ;\n\tWed, 3 Apr 2019 10:01:20 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 219CB6001E;\n\tWed, 3 Apr 2019 08:01:19 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 3 Apr 2019 10:01:47 +0200","Message-Id":"<20190403080148.11479-13-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190403080148.11479-1-jacopo@jmondi.org>","References":"<20190403080148.11479-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v8 12/13] libcamera: ipu3: Limit\n\tresolution to 2560x1920","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 03 Apr 2019 08:01:21 -0000"},"content":"As the procedure to configure the intermediate sizes and the alignement\nrequirements of the ImgU device have not been clarified yet, return as\ndefault configuration the (2560x1920) resolution that has been validated\nfor both cameras.\n\nReviewed-by: Laurent Pinchart \nReviewed-by: Niklas Söderlund \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 792ff42c0eaa..a1e53c9a5a06 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -206,10 +206,17 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n \tstd::map configs;\n \tIPU3CameraData *data = cameraData(camera);\n \tStreamConfiguration *config = &configs[&data->stream_];\n-\tSize *maxSize = &data->.cio2_.maxSize_;\n \n-\tconfig->width = maxSize->width;\n-\tconfig->height = maxSize->height;\n+\t/*\n+\t * FIXME: Soraka: the maximum resolution reported by both sensors\n+\t * (2592x1944 for ov5670 and 4224x3136 for ov13858) are returned as\n+\t * default configurations but they're not correctly processed by the\n+\t * ImgU. Resolutions up tp 2560x1920 have been validated.\n+\t *\n+\t * \\todo Clarify ImgU alignement requirements.\n+\t */\n+\tconfig->width = 2560;\n+\tconfig->height = 1920;\n \tconfig->pixelFormat = V4L2_PIX_FMT_NV12;\n \tconfig->bufferCount = IPU3_BUFFER_COUNT;\n \n","prefixes":["libcamera-devel","v8","12/13"]}