{"id":8962,"url":"https://patchwork.libcamera.org/api/1.1/patches/8962/?format=json","web_url":"https://patchwork.libcamera.org/patch/8962/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200724090744.508110-5-niklas.soderlund@ragnatech.se>","date":"2020-07-24T09:07:44","name":"[libcamera-devel,v2,4/4] android: camera_device: Add ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS","commit_ref":"a2a6f95bffcff24869f24d94b94247ebc05f448c","pull_url":null,"state":"accepted","archived":false,"hash":"51d33b939841eb0be055b028965488183ca72c76","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8962/mbox/","series":[{"id":1134,"url":"https://patchwork.libcamera.org/api/1.1/series/1134/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1134","date":"2020-07-24T09:07:40","name":"android: camera_device: Improve on format related tags","version":2,"mbox":"https://patchwork.libcamera.org/series/1134/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8962/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8962/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CEC1DBD86F\n\tfor ;\n\tFri, 24 Jul 2020 09:07:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 65B0E61220;\n\tFri, 24 Jul 2020 11:07:59 +0200 (CEST)","from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F54A6120B\n\tfor ;\n\tFri, 24 Jul 2020 11:07:56 +0200 (CEST)","from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 29127b46-cd8d-11ea-8fb8-005056917f90;\n\tFri, 24 Jul 2020 11:07:55 +0200 (CEST)"],"X-Halon-ID":"29127b46-cd8d-11ea-8fb8-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 24 Jul 2020 11:07:44 +0200","Message-Id":"<20200724090744.508110-5-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200724090744.508110-1-niklas.soderlund@ragnatech.se>","References":"<20200724090744.508110-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 4/4] android: camera_device: Add\n\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Define the ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS to zero to inform users\nthe HAL does not support any reprocessing.\n\nSigned-off-by: Niklas Söderlund \nReviewed-by: Jacopo Mondi \n---\n* Changes since v1\n- Change size of tag from uint8_t to uint32_t and update byteSize\n accordingly.\n---\n src/android/camera_device.cpp | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex d9fdaf44b2803399..b49d6681e5a52d32 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -370,8 +370,8 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n \t * \\todo Keep this in sync with the actual number of entries.\n \t * Currently: 50 entries, 647 bytes of static metadata\n \t */\n-\tuint32_t numEntries = 49;\n-\tuint32_t byteSize = 647;\n+\tuint32_t numEntries = 50;\n+\tuint32_t byteSize = 651;\n \n \t/*\n \t * Calculate space occupation in bytes for dynamically built metadata\n@@ -699,6 +699,11 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n \t\t\t\t &maxPipelineDepth, 1);\n \n+\t/* LIMITED does not support reprocessing. */\n+\tuint32_t maxNumInputStreams = 0;\n+\tstaticMetadata_->addEntry(ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n+\t\t\t\t &maxNumInputStreams, 1);\n+\n \tstd::vector availableCapabilities = {\n \t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE,\n \t};\n@@ -752,6 +757,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\tANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n \t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n \t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n+\t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n \t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n \t};\n \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CHARACTERISTICS_KEYS,\n","prefixes":["libcamera-devel","v2","4/4"]}