{"id":8952,"url":"https://patchwork.libcamera.org/api/1.1/patches/8952/?format=json","web_url":"https://patchwork.libcamera.org/patch/8952/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200724072218.943245-9-naush@raspberrypi.com>","date":"2020-07-24T07:22:16","name":"[libcamera-devel,v5,08/10] libcamera: pipeline: raspberrypi: Fix bug in passing configuration to IPA","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ef49a90f1640831fa6144d3171847607fbe9e2bd","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8952/mbox/","series":[{"id":1132,"url":"https://patchwork.libcamera.org/api/1.1/series/1132/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1132","date":"2020-07-24T07:22:08","name":"Zero-copy RAW stream work","version":5,"mbox":"https://patchwork.libcamera.org/series/1132/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8952/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8952/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 776F8BD879\n\tfor ;\n\tFri, 24 Jul 2020 07:23:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4239D611AA;\n\tFri, 24 Jul 2020 09:23:00 +0200 (CEST)","from mail-wm1-x341.google.com (mail-wm1-x341.google.com\n\t[IPv6:2a00:1450:4864:20::341])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFC9F6117D\n\tfor ;\n\tFri, 24 Jul 2020 09:22:56 +0200 (CEST)","by mail-wm1-x341.google.com with SMTP id f139so7313764wmf.5\n\tfor ;\n\tFri, 24 Jul 2020 00:22:56 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\t32sm246595wrn.86.2020.07.24.00.22.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 24 Jul 2020 00:22:55 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"hd4zU3RW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Gq7UH/w1bcU53CsPsuv53AmTQEfkzGwhIAn8cztiBJY=;\n\tb=hd4zU3RWjABLuBa2xOCfuaKOljWf+1DfjjUbmzzxD/ALVbOhRSMBexoCWGbRPujveH\n\tBBdkVQoYo+NfJjrsFLTe/LCy02xCpWQsYtBz+Clq+YKw7Y/vqVlddGpbKVH66oHnD07q\n\tNPaROZH851gy8aaHaET7BsnHtsttoS0+34s5FQezKc5IZZJbTC8OMQeKGaT1wgzkrIxA\n\tpg+5yyZdz7mskS0nCrUYvC49QtMCHzkATuYHzllaEG4I0o9sfXHIj0ztrPtE47jZC4if\n\te+iD8+vaKptBIpQy7zV3j9oQtFyYO82SlyuLcDklQEDyzJXI5Xa7t6iepAc+mSpa3oZA\n\trNcQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Gq7UH/w1bcU53CsPsuv53AmTQEfkzGwhIAn8cztiBJY=;\n\tb=NaC1BzD7BRGmIFWAdjb3m93aV03vJbH3f2K6qLixMlCvyUmSRMAufQIIGvLCkbZCEw\n\tvRQ2B2oualO2au/U1xYFAO1brFYKj1fNVL5t3WQmpyHNrwLPDI0SP1qmkMZoUg38jtYm\n\thl1e2NjtxQ5IoeENeVCzPEDdZ6HYPMV34bS4hZtK3iI/HU27x00rSsgxV31porQjdwHn\n\tJbc64zjoOepjbPiUpwPNcLP13dhrLNzQs2OR9xqQkVE6P+W4WqSe+6b+lOc7vxP7VAYT\n\tmu8ahg/nzbhulSAg26JeB+aKxONIzi5PwDXnkTn57lQtbTF3On9pXtiDgw8wT0S0KyU+\n\t4ltQ==","X-Gm-Message-State":"AOAM531rQfhKblsjUCsEbMvSeKmFD48Lu8ifxTWm++deLrczvPpcJbb/\n\tFnAy8Gnhn839+eGD//PdGHbCUTYyH4308A==","X-Google-Smtp-Source":"ABdhPJxQn1LaH0tJ3iP/ZMlZFLDprq9VLb0z0caUBSN5C782Hbd8DeEz3xRm3bF16zQfCndVU1icXA==","X-Received":"by 2002:a7b:cb92:: with SMTP id m18mr7176679wmi.94.1595575376197;\n\tFri, 24 Jul 2020 00:22:56 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 24 Jul 2020 08:22:16 +0100","Message-Id":"<20200724072218.943245-9-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200724072218.943245-1-naush@raspberrypi.com>","References":"<20200724072218.943245-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 08/10] libcamera: pipeline:\n\traspberrypi: Fix bug in passing configuration to IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The counter was not incremented, so multiple streams would only pass the\nlast stream config to the IPA.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Niklas Söderlund \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \nTested-by: David Plowman \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 47941851..14c1a073 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -984,12 +984,13 @@ int RPiCameraData::configureIPA()\n \tunsigned int i = 0;\n \tfor (auto const &stream : isp_) {\n \t\tif (stream.isExternal()) {\n-\t\t\tstreamConfig[i] = {\n+\t\t\tstreamConfig[i++] = {\n \t\t\t\t.pixelFormat = stream.configuration().pixelFormat,\n \t\t\t\t.size = stream.configuration().size\n \t\t\t};\n \t\t}\n \t}\n+\n \tentityControls.emplace(0, unicam_[Unicam::Image].dev()->controls());\n \tentityControls.emplace(1, isp_[Isp::Input].dev()->controls());\n \n","prefixes":["libcamera-devel","v5","08/10"]}