{"id":8941,"url":"https://patchwork.libcamera.org/api/1.1/patches/8941/?format=json","web_url":"https://patchwork.libcamera.org/patch/8941/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200723173942.98182-4-niklas.soderlund@ragnatech.se>","date":"2020-07-23T17:39:41","name":"[libcamera-devel,3/4] android: camera_device: Remove scaler format information from Camera3Format","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7cc1cd8046631f71b2aa97199f6295821fc27a62","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8941/mbox/","series":[{"id":1130,"url":"https://patchwork.libcamera.org/api/1.1/series/1130/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1130","date":"2020-07-23T17:39:38","name":"android: camera_device: Improve on format related tags","version":1,"mbox":"https://patchwork.libcamera.org/series/1130/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8941/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8941/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7F658BD878\n\tfor ;\n\tThu, 23 Jul 2020 17:40:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DBD8B6118D;\n\tThu, 23 Jul 2020 19:40:52 +0200 (CEST)","from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA3966114F\n\tfor ;\n\tThu, 23 Jul 2020 19:40:49 +0200 (CEST)","from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid a4e8b146-cd0b-11ea-933e-005056917a89;\n\tThu, 23 Jul 2020 19:40:48 +0200 (CEST)"],"X-Halon-ID":"a4e8b146-cd0b-11ea-933e-005056917a89","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 23 Jul 2020 19:39:41 +0200","Message-Id":"<20200723173942.98182-4-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200723173942.98182-1-niklas.soderlund@ragnatech.se>","References":"<20200723173942.98182-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 3/4] android: camera_device: Remove scaler\n\tformat information from Camera3Format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The scaler format information was only used for the\nANDROID_SCALER_AVAILABLE_FORMATS tag which is deprecated and removed. As\nit has no other users remove it.\n\nSigned-off-by: Niklas Söderlund \n---\n src/android/camera_device.cpp | 6 ------\n 1 file changed, 6 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 96dd8d5a99082966..d9fdaf44b2803399 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -42,13 +42,10 @@ const std::vector camera3Resolutions = {\n * \\brief Data associated with an Android format identifier\n * \\var libcameraFormats List of libcamera pixel formats compatible with the\n * Android format\n- * \\var scalerFormat The format identifier to be reported to the android\n- * framework through the static format configuration map\n * \\var name The human-readable representation of the Android format code\n */\n struct Camera3Format {\n \tstd::vector libcameraFormats;\n-\tcamera_metadata_enum_android_scaler_available_formats_t scalerFormat;\n \tconst char *name;\n };\n \n@@ -60,13 +57,11 @@ const std::map camera3FormatsMap = {\n \t{\n \t\tHAL_PIXEL_FORMAT_BLOB, {\n \t\t\t{ formats::MJPEG },\n-\t\t\tANDROID_SCALER_AVAILABLE_FORMATS_BLOB,\n \t\t\t\"BLOB\"\n \t\t}\n \t}, {\n \t\tHAL_PIXEL_FORMAT_YCbCr_420_888, {\n \t\t\t{ formats::NV12, formats::NV21 },\n-\t\t\tANDROID_SCALER_AVAILABLE_FORMATS_YCbCr_420_888,\n \t\t\t\"YCbCr_420_888\"\n \t\t}\n \t}, {\n@@ -76,7 +71,6 @@ const std::map camera3FormatsMap = {\n \t\t */\n \t\tHAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED, {\n \t\t\t{ formats::NV12, formats::NV21 },\n-\t\t\tANDROID_SCALER_AVAILABLE_FORMATS_IMPLEMENTATION_DEFINED,\n \t\t\t\"IMPLEMENTATION_DEFINED\"\n \t\t}\n \t},\n","prefixes":["libcamera-devel","3/4"]}