{"id":8919,"url":"https://patchwork.libcamera.org/api/1.1/patches/8919/?format=json","web_url":"https://patchwork.libcamera.org/patch/8919/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200722133009.26528-3-kgupta@es.iitr.ac.in>","date":"2020-07-22T13:30:04","name":"[libcamera-devel,2/7] libcamera: pipeline: vimc: Introduce rawStream_","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a00dfafd01cf936d6d21cf78aa34854eee92739e","submitter":{"id":39,"url":"https://patchwork.libcamera.org/api/1.1/people/39/?format=json","name":"Kaaira Gupta","email":"kgupta@es.iitr.ac.in"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/1.1/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/8919/mbox/","series":[{"id":1127,"url":"https://patchwork.libcamera.org/api/1.1/series/1127/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1127","date":"2020-07-22T13:30:02","name":"vimc: Introduce multiple streaming","version":1,"mbox":"https://patchwork.libcamera.org/series/1127/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8919/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8919/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9664BDB1B\n\tfor ;\n\tWed, 22 Jul 2020 13:30:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A48FB60991;\n\tWed, 22 Jul 2020 15:30:26 +0200 (CEST)","from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com\n\t[IPv6:2607:f8b0:4864:20::52a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16D6A6053C\n\tfor ;\n\tWed, 22 Jul 2020 15:30:25 +0200 (CEST)","by mail-pg1-x52a.google.com with SMTP id o13so1279391pgf.0\n\tfor ;\n\tWed, 22 Jul 2020 06:30:25 -0700 (PDT)","from kaaira-HP-Pavilion-Notebook ([103.113.213.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tp19sm20704699pgj.74.2020.07.22.06.30.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 22 Jul 2020 06:30:23 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=es-iitr-ac-in.20150623.gappssmtp.com\n\theader.i=@es-iitr-ac-in.20150623.gappssmtp.com\n\theader.b=\"CGt+aRtL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Inu6TdNqo/wikV1TauBqX/BnETqTDy3fmj9CxK6jz9I=;\n\tb=CGt+aRtLEA4gf0d8v1eYbOlb0BGtfChm0RHJC2zcvqsX9Rcz7FH8XBXpbqEvIo4XKh\n\tCojIuOK29u6Suil9JqBmwSnhp0+9Jw8XH6SPrRU5hzQWzhT27+VyfuwtK+u0dyvqcQ/R\n\tPCPrskERGOUF4pz15TqFqQ3d4xQjGsGZhwpuB2D+Shdy8zhGmICfB0hM+Pxfha8E2HTT\n\tJGnqJBsgxvxMHCAqbHdVt+fccPK2AMUTIvKIIdhF8nO+nsl4XP4c8zA7Tz/vMITPulzs\n\tYHs9v1j4G2vSjN/oY7ywGt6DVJ2rkI0lGTNUAVUeYMHMlUaeJJ7grJHnOsJkM27mqWS3\n\t9zrw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Inu6TdNqo/wikV1TauBqX/BnETqTDy3fmj9CxK6jz9I=;\n\tb=RlObnRfhORL738W1IxBpqIwst5YR+DBOJZorGdGMAll6J/g0jZj+hTxZ/qL2WETNno\n\t7Lk7lLoLyhycRuDBW6qmysw6/tXAhbrnhO4CHwgpplu/iqHwSzfQOFSrXuLK+2qEJSM4\n\tokT4WePiR2w7x2xyh5BqBj96j6CJuxwlAsH/bkBc8mH632O0u87zwu4hZ+Lg8+vv6Y6M\n\tSJ0JGDT8htbDR7RkFn5x5MbFBamQJtaXOUxATVFkATzthK+WdfeRZ9jifZ3dHxgr4rZV\n\tkZgwgheXhLhlc9jO57zkbqLxZ9kcxafo25Y2PXhDpCPThQiByRpKYxQ98KFAATZ3HPp4\n\tmCpQ==","X-Gm-Message-State":"AOAM533ck7lac0ICZqvmx9MHDtypq8aGZMqLfIJzOxejLbSXpFyygmBA\n\t8pCUoHu6TPbBkgoimY0FBlga+g==","X-Google-Smtp-Source":"ABdhPJxzZ6w7ktUD9HniFxiVHFCq5eIcL4bUefP1DBl+pXXWUcBPGCltVCoOhFHO+LaHePZvok5AYw==","X-Received":"by 2002:a65:6795:: with SMTP id\n\te21mr27756048pgr.289.1595424623708; \n\tWed, 22 Jul 2020 06:30:23 -0700 (PDT)","From":"Kaaira Gupta ","To":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","Date":"Wed, 22 Jul 2020 19:00:04 +0530","Message-Id":"<20200722133009.26528-3-kgupta@es.iitr.ac.in>","X-Mailer":"git-send-email 2.17.1","In-Reply-To":"<20200722133009.26528-1-kgupta@es.iitr.ac.in>","References":"<20200722133009.26528-1-kgupta@es.iitr.ac.in>","Subject":"[libcamera-devel] [PATCH 2/7] libcamera: pipeline: vimc: Introduce\n\trawStream_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kaaira Gupta ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Change \"stream_\" to \"rgbStream_\" as it represents stream at RGB/YUV\nCapture, and introduce a raw stream for streaming with RAW capture 1\n\nSigned-off-by: Kaaira Gupta \n---\n src/libcamera/pipeline/vimc/vimc.cpp | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 4f461b9..bd6ddde 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -66,7 +66,8 @@ public:\n \tV4L2Subdevice *scaler_;\n \tV4L2VideoDevice *video_;\n \tV4L2VideoDevice *raw_;\n-\tStream stream_;\n+\tStream rgbStream_;\n+\tStream rawStream_;\n };\n \n class VimcCameraConfiguration : public CameraConfiguration\n@@ -290,7 +291,7 @@ int PipelineHandlerVimc::configure(Camera *camera, CameraConfiguration *config)\n \tif (ret)\n \t\treturn ret;\n \n-\tcfg.setStream(&data->stream_);\n+\tcfg.setStream(&data->rgbStream_);\n \n \treturn 0;\n }\n@@ -307,7 +308,7 @@ int PipelineHandlerVimc::exportFrameBuffers(Camera *camera, Stream *stream,\n int PipelineHandlerVimc::start(Camera *camera)\n {\n \tVimcCameraData *data = cameraData(camera);\n-\tunsigned int count = data->stream_.configuration().bufferCount;\n+\tunsigned int count = data->rgbStream_.configuration().bufferCount;\n \n \tint ret = data->video_->importBuffers(count);\n \tif (ret < 0)\n@@ -380,7 +381,7 @@ int PipelineHandlerVimc::processControls(VimcCameraData *data, Request *request)\n int PipelineHandlerVimc::queueRequestDevice(Camera *camera, Request *request)\n {\n \tVimcCameraData *data = cameraData(camera);\n-\tFrameBuffer *buffer = request->findBuffer(&data->stream_);\n+\tFrameBuffer *buffer = request->findBuffer(&data->rgbStream_);\n \tif (!buffer) {\n \t\tLOG(VIMC, Error)\n \t\t\t<< \"Attempt to queue request with invalid stream\";\n@@ -433,7 +434,7 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n \n \t/* Create and register the camera. */\n \tstd::string name{ \"VIMC \" + data->sensor_->model() };\n-\tstd::set streams{ &data->stream_ };\n+\tstd::set streams{ &data->rgbStream_, &data->rawStream_ };\n \tstd::shared_ptr camera = Camera::create(this, name, streams);\n \tregisterCamera(std::move(camera), std::move(data));\n \n","prefixes":["libcamera-devel","2/7"]}