{"id":8899,"url":"https://patchwork.libcamera.org/api/1.1/patches/8899/?format=json","web_url":"https://patchwork.libcamera.org/patch/8899/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200720224232.153717-8-kieran.bingham@ideasonboard.com>","date":"2020-07-20T22:42:31","name":"[libcamera-devel,RFC,7/8] android: camera_device: Query plane length","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"2afe8277937f419bd0ab0357bc502bcb767c9e4a","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8899/mbox/","series":[{"id":1119,"url":"https://patchwork.libcamera.org/api/1.1/series/1119/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1119","date":"2020-07-20T22:42:24","name":"RFC MappedBuffers","version":1,"mbox":"https://patchwork.libcamera.org/series/1119/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8899/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8899/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1CB24C2E67\n\tfor ;\n\tMon, 20 Jul 2020 22:42:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC799607CB;\n\tTue, 21 Jul 2020 00:42:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7CF6B6081E\n\tfor ;\n\tTue, 21 Jul 2020 00:42:39 +0200 (CEST)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 10C8EA49;\n\tTue, 21 Jul 2020 00:42:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qqekhroF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595284959;\n\tbh=R+cpnFHtqQo7aKOYXlpN0kq0AcvZ7mdtSsLO3YpKlpE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=qqekhroFRxLkckpLWE31ZppSeCaFApZTFq9FGxPfICjR013mgLJ8NXhBmSXAezV1q\n\tx973iSP1Ji3jP4NMhgg+lIPlzrglMsPyJU+jh1bdeWQv6dQC03jUzPm5SuPT5hL3qH\n\t/O6xI9NVwhITFX1KKy38ooBiJXD+7781NTHsLldg=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Mon, 20 Jul 2020 23:42:31 +0100","Message-Id":"<20200720224232.153717-8-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200720224232.153717-1-kieran.bingham@ideasonboard.com>","References":"<20200720224232.153717-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC PATCH 7/8] android: camera_device: Query\n\tplane length","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use lseek to query the length of planes where possible rather than leaving\nthe plane.length as zero, which prevents mapping buffers for software\nprocessing.\n\nSigned-off-by: Kieran Bingham \n---\n\nI like this one ;-) We need to know the plane lengths for software\nstreams now, but the correct way to get this would be to talk to the\ngralloc allocator. This would mean pulling in various extra\ncros-specific libraries, where instead we can query the size of the\ndmabuf by getting the offset when we SEEK_END.\n\n\n src/android/camera_device.cpp | 18 ++++++++++++------\n 1 file changed, 12 insertions(+), 6 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 538b8ab5da03..6212ccdd61ec 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1045,12 +1045,18 @@ FrameBuffer *CameraDevice::createFrameBuffer(const buffer_handle_t camera3buffer\n \t\t\tcontinue;\n \t\t}\n \n-\t\t/*\n-\t\t * Setting length to zero here is OK as the length is only used\n-\t\t * to map the memory of the plane. Libcamera do not need to poke\n-\t\t * at the memory content queued by the HAL.\n-\t\t */\n-\t\tplane.length = 0;\n+\t\toff_t length = lseek(plane.fd.fd(), 0, SEEK_END);\n+\t\tif (length == -1) {\n+\t\t\t/*\n+\t\t\t * A zero length plane is not fatal unless the\n+\t\t\t * FrameBuffer is used for a software stream, libcamera\n+\t\t\t * itself will not access the internal frame content.\n+\t\t\t */\n+\t\t\tLOG(HAL, Error) << \"Failed to query plane length\";\n+\t\t\tlength = 0;\n+\t\t}\n+\n+\t\tplane.length = length;\n \t\tplanes.push_back(std::move(plane));\n \t}\n \n","prefixes":["libcamera-devel","RFC","7/8"]}