{"id":8897,"url":"https://patchwork.libcamera.org/api/1.1/patches/8897/?format=json","web_url":"https://patchwork.libcamera.org/patch/8897/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200720224232.153717-6-kieran.bingham@ideasonboard.com>","date":"2020-07-20T22:42:29","name":"[libcamera-devel,RFC,5/8] android: camera_device: Report an error in notifyError()","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"75f26e5087589763141d563b7f554bac56773113","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8897/mbox/","series":[{"id":1119,"url":"https://patchwork.libcamera.org/api/1.1/series/1119/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1119","date":"2020-07-20T22:42:24","name":"RFC MappedBuffers","version":1,"mbox":"https://patchwork.libcamera.org/series/1119/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8897/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8897/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 72A07C2E68\n\tfor ;\n\tMon, 20 Jul 2020 22:42:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BAA49608A0;\n\tTue, 21 Jul 2020 00:42:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C274E605BB\n\tfor ;\n\tTue, 21 Jul 2020 00:42:38 +0200 (CEST)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B001563;\n\tTue, 21 Jul 2020 00:42:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Qk7ClZGp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595284958;\n\tbh=CIJiScVilazsTkJLAVPYGXBBRQhLfiiZd8rAJSud8r4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Qk7ClZGpn8Xs6sHDlskWmdyknwNOcFElFvRsYDjjUqsPLtrB4pdPKl+4P8fXCn6OE\n\tUeb4DrK9yBFaz24J2wHyU47wPYoF4HorLEB9KPHs6K3AFs4ZmIOCh1CtU3H/cqXFPH\n\tcHNs2z3R+AiWvFhqM+7zK7ErTmizeZgHKhr8NXwk=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Mon, 20 Jul 2020 23:42:29 +0100","Message-Id":"<20200720224232.153717-6-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200720224232.153717-1-kieran.bingham@ideasonboard.com>","References":"<20200720224232.153717-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC PATCH 5/8] android: camera_device: Report an\n\terror in notifyError()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If an error is generated, try to be verbose about it in the libcamera logs.\n\nSigned-off-by: Kieran Bingham \nReviewed-by: Niklas Söderlund \n\n---\n\nA little unrelated from the RFC series, but in the tree and at v2, so\nposted anyway.... This helps ;-)\n\nv2:\n - Add todo to note possible debug info expansion\n - Fix typo\n - Print .toString() formatted pixel format\n\n src/android/camera_device.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 48f8090a93db..e5c50084e590 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1209,6 +1209,13 @@ void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream)\n {\n \tcamera3_notify_msg_t notify = {};\n \n+\t/*\n+\t * \\todo: Report and identify the stream number or configuration to\n+\t * clarify the stream that failed.\n+\t */\n+\tLOG(HAL, Error) << \"Error occurred on frame \" << frameNumber << \" (\"\n+\t\t\t<< toPixelFormat(stream->format).toString() << \")\";\n+\n \tnotify.type = CAMERA3_MSG_ERROR;\n \tnotify.message.error.error_stream = stream;\n \tnotify.message.error.frame_number = frameNumber;\n","prefixes":["libcamera-devel","RFC","5/8"]}