{"id":8886,"url":"https://patchwork.libcamera.org/api/1.1/patches/8886/?format=json","web_url":"https://patchwork.libcamera.org/patch/8886/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200720104736.19986-15-jacopo@jmondi.org>","date":"2020-07-20T10:47:31","name":"[libcamera-devel,v4,14/19] libcamera: ipu3: Remove streams from IPU3CameraConfiguration","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e746425fd3c07c3533e9c0ace5f756cd95d7aaef","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8886/mbox/","series":[{"id":1118,"url":"https://patchwork.libcamera.org/api/1.1/series/1118/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1118","date":"2020-07-20T10:47:17","name":"ipu3: rework pipe confiuguration","version":4,"mbox":"https://patchwork.libcamera.org/series/1118/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8886/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8886/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A033C0109\n\tfor ;\n\tMon, 20 Jul 2020 10:44:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7B8C60744;\n\tMon, 20 Jul 2020 12:44:27 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 89914605B7\n\tfor ;\n\tMon, 20 Jul 2020 12:44:24 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id C9CD460011;\n\tMon, 20 Jul 2020 10:44:23 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 20 Jul 2020 12:47:31 +0200","Message-Id":"<20200720104736.19986-15-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200720104736.19986-1-jacopo@jmondi.org>","References":"<20200720104736.19986-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 14/19] libcamera: ipu3: Remove streams\n\tfrom IPU3CameraConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The IPU3CameraConfiguration::streams_ field was used to keep an\nassociation between the StreamConfiguration and the assigned streams\nbefore CameraConfiguration::setStream() was called at configure() time.\n\nThe stream assignment was based on the order in which elements were\ninserted in the vector, implementing a fragile association between\nstreams and their intended configurations.\n\nAs it is now possible to assign streams at validation time, there is no\nneed to keep that association in place, and the streams_ vector is now\nunused.\n\nRemove it and the associated accessor method from the\nIPU3CameraConfiguration class.\n\nReviewed-by: Laurent Pinchart \nReviewed-by: Niklas Söderlund \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 --\n 1 file changed, 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 24ad37eb1831..08e3fcb5af15 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -67,7 +67,6 @@ public:\n \tStatus validate() override;\n \n \tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; };\n-\tconst std::vector &streams() { return streams_; }\n \n private:\n \t/*\n@@ -79,7 +78,6 @@ private:\n \tconst IPU3CameraData *data_;\n \n \tStreamConfiguration cio2Configuration_;\n-\tstd::vector streams_;\n };\n \n class PipelineHandlerIPU3 : public PipelineHandler\n","prefixes":["libcamera-devel","v4","14/19"]}