{"id":8878,"url":"https://patchwork.libcamera.org/api/1.1/patches/8878/?format=json","web_url":"https://patchwork.libcamera.org/patch/8878/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200720104736.19986-7-jacopo@jmondi.org>","date":"2020-07-20T10:47:23","name":"[libcamera-devel,v4,06/19] libcamera: ipu3: cio2: Report format and sizes","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"12359bf466ac37c805136b41bb66f365f237fd93","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8878/mbox/","series":[{"id":1118,"url":"https://patchwork.libcamera.org/api/1.1/series/1118/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1118","date":"2020-07-20T10:47:17","name":"ipu3: rework pipe confiuguration","version":4,"mbox":"https://patchwork.libcamera.org/series/1118/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8878/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8878/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6199FC0109\n\tfor ;\n\tMon, 20 Jul 2020 10:44:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A9CB605BF;\n\tMon, 20 Jul 2020 12:44:22 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFE9E60537\n\tfor ;\n\tMon, 20 Jul 2020 12:44:17 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 52D6F6000B;\n\tMon, 20 Jul 2020 10:44:17 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 20 Jul 2020 12:47:23 +0200","Message-Id":"<20200720104736.19986-7-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200720104736.19986-1-jacopo@jmondi.org>","References":"<20200720104736.19986-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 06/19] libcamera: ipu3: cio2: Report\n\tformat and sizes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add two methods to the CIO2Device class to retrieve all the supported\nPixelFormats and sizes.\n\nReviewed-by: Niklas Söderlund \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/cio2.cpp | 40 ++++++++++++++++++++++++++++\n src/libcamera/pipeline/ipu3/cio2.h | 5 ++++\n 2 files changed, 45 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\nindex 77f54da47e28..abe6d8a592d6 100644\n--- a/src/libcamera/pipeline/ipu3/cio2.cpp\n+++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n@@ -10,6 +10,7 @@\n #include \n \n #include \n+#include \n #include \n \n #include \"libcamera/internal/camera_sensor.h\"\n@@ -43,6 +44,45 @@ CIO2Device::~CIO2Device()\n \tdelete sensor_;\n }\n \n+/**\n+ * \\brief Retrieve the list of supported PixelFormats\n+ *\n+ * Retrieve the list of supported pixel formats by matching the sensor produced\n+ * media bus codes with the formats supported by the CIO2 unit.\n+ *\n+ * \\return The list of supported PixelFormat\n+ */\n+std::vector CIO2Device::formats() const\n+{\n+\tif (!sensor_)\n+\t\treturn {};\n+\n+\tstd::vector formats;\n+\tfor (unsigned int code : sensor_->mbusCodes()) {\n+\t\tauto it = mbusCodesToPixelFormat.find(code);\n+\t\tif (it != mbusCodesToPixelFormat.end())\n+\t\t\tformats.push_back(it->second);\n+\t}\n+\n+\treturn formats;\n+}\n+\n+/**\n+ * \\brief Retrieve the list of supported size ranges\n+ * \\return The list of supported SizeRange\n+ */\n+std::vector CIO2Device::sizes() const\n+{\n+\tif (!sensor_)\n+\t\treturn {};\n+\n+\tstd::vector sizes;\n+\tfor (const Size &size : sensor_->sizes())\n+\t\tsizes.emplace_back(size, size);\n+\n+\treturn sizes;\n+}\n+\n /**\n * \\brief Initialize components of the CIO2 device with \\a index\n * \\param[in] media The CIO2 media device\ndiff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h\nindex 956355a0aa58..221cf817eee9 100644\n--- a/src/libcamera/pipeline/ipu3/cio2.h\n+++ b/src/libcamera/pipeline/ipu3/cio2.h\n@@ -20,8 +20,10 @@ namespace libcamera {\n class CameraSensor;\n class FrameBuffer;\n class MediaDevice;\n+class PixelFormat;\n class Request;\n class Size;\n+class SizeRange;\n class V4L2Subdevice;\n struct StreamConfiguration;\n \n@@ -33,6 +35,9 @@ public:\n \tCIO2Device();\n \t~CIO2Device();\n \n+\tstd::vector formats() const;\n+\tstd::vector sizes() const;\n+\n \tint init(const MediaDevice *media, unsigned int index);\n \tint configure(const Size &size, V4L2DeviceFormat *outputFormat);\n \n","prefixes":["libcamera-devel","v4","06/19"]}