{"id":8874,"url":"https://patchwork.libcamera.org/api/1.1/patches/8874/?format=json","web_url":"https://patchwork.libcamera.org/patch/8874/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200720104736.19986-3-jacopo@jmondi.org>","date":"2020-07-20T10:47:19","name":"[libcamera-devel,v4,02/19] libcamera: utils: Add alignUp and alignDown functions","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"37409f1a6eddbebc60c653b8793d4120f3b49676","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8874/mbox/","series":[{"id":1118,"url":"https://patchwork.libcamera.org/api/1.1/series/1118/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1118","date":"2020-07-20T10:47:17","name":"ipu3: rework pipe confiuguration","version":4,"mbox":"https://patchwork.libcamera.org/series/1118/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8874/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8874/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5ACC4C0109\n\tfor ;\n\tMon, 20 Jul 2020 10:44:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7951160718;\n\tMon, 20 Jul 2020 12:44:16 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E23E60554\n\tfor ;\n\tMon, 20 Jul 2020 12:44:14 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 0189D60002;\n\tMon, 20 Jul 2020 10:44:13 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 20 Jul 2020 12:47:19 +0200","Message-Id":"<20200720104736.19986-3-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200720104736.19986-1-jacopo@jmondi.org>","References":"<20200720104736.19986-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 02/19] libcamera: utils: Add alignUp\n\tand alignDown functions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add to libcamera utils library two functions to round up or down a\nvalue to an alignment and add a test in test/utils.cpp for the two\nnew functions.\n\nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/internal/utils.h | 10 ++++++++++\n src/libcamera/utils.cpp | 16 ++++++++++++++++\n test/utils.cpp | 11 +++++++++++\n 3 files changed, 37 insertions(+)","diff":"diff --git a/include/libcamera/internal/utils.h b/include/libcamera/internal/utils.h\nindex 8d026cc6c0fe..45cd6f120c51 100644\n--- a/include/libcamera/internal/utils.h\n+++ b/include/libcamera/internal/utils.h\n@@ -200,6 +200,16 @@ details::StringSplitter split(const std::string &str, const std::string &delim);\n std::string libcameraBuildPath();\n std::string libcameraSourcePath();\n \n+constexpr unsigned int alignDown(unsigned int value, unsigned int alignment)\n+{\n+\treturn value / alignment * alignment;\n+}\n+\n+constexpr unsigned int alignUp(unsigned int value, unsigned int alignment)\n+{\n+\treturn (value + alignment - 1) / alignment * alignment;\n+}\n+\n } /* namespace utils */\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\nindex 0567328fe31b..615df46ac142 100644\n--- a/src/libcamera/utils.cpp\n+++ b/src/libcamera/utils.cpp\n@@ -444,6 +444,22 @@ std::string libcameraSourcePath()\n \treturn path + \"/\";\n }\n \n+/**\n+ * \\fn alignDown(unsigned int value, unsigned int alignment)\n+ * \\brief Align \\a value down to \\a alignment\n+ * \\param[in] value The value to align\n+ * \\param[in] alignment The alignment\n+ * \\return The value rounded down to the nearest multiple of \\a alignment\n+ */\n+\n+/**\n+ * \\fn alignUp(unsigned int value, unsigned int alignment)\n+ * \\brief Align \\a value up to \\a alignment\n+ * \\param[in] value The value to align\n+ * \\param[in] alignment The alignment\n+ * \\return The value rounded up to the nearest multiple of \\a alignment\n+ */\n+\n } /* namespace utils */\n \n } /* namespace libcamera */\ndiff --git a/test/utils.cpp b/test/utils.cpp\nindex f482e6a1d829..08f293898fd9 100644\n--- a/test/utils.cpp\n+++ b/test/utils.cpp\n@@ -166,6 +166,17 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n+\t\t/* utils::alignUp() and utils::alignDown() tests. */\n+\t\tif (utils::alignDown(6, 3) != 6 || utils::alignDown(7, 3) != 6) {\n+\t\t\tcerr << \"utils::alignDown test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (utils::alignUp(6, 3) != 6 || utils::alignUp(7, 3) != 9) {\n+\t\t\tcerr << \"utils::alignUp test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n \t\treturn TestPass;\n \t}\n };\n","prefixes":["libcamera-devel","v4","02/19"]}