{"id":8845,"url":"https://patchwork.libcamera.org/api/1.1/patches/8845/?format=json","web_url":"https://patchwork.libcamera.org/patch/8845/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200717085410.732308-8-naush@raspberrypi.com>","date":"2020-07-17T08:54:07","name":"[libcamera-devel,v3,07/10] libcamera: pipeline: raspberrypi: Fix bug in passing configuration to IPA","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bff231561128ef256652363ed8cdc354fd95fd7e","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8845/mbox/","series":[{"id":1114,"url":"https://patchwork.libcamera.org/api/1.1/series/1114/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1114","date":"2020-07-17T08:54:00","name":"Zero-copy RAW stream work","version":3,"mbox":"https://patchwork.libcamera.org/series/1114/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8845/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8845/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2C8ACC0109\n\tfor ;\n\tFri, 17 Jul 2020 08:54:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D098D6055F;\n\tFri, 17 Jul 2020 10:54:25 +0200 (CEST)","from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3032960542\n\tfor ;\n\tFri, 17 Jul 2020 10:54:22 +0200 (CEST)","by mail-wr1-x432.google.com with SMTP id f2so10148771wrp.7\n\tfor ;\n\tFri, 17 Jul 2020 01:54:22 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\t92sm14582375wrr.96.2020.07.17.01.54.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 17 Jul 2020 01:54:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"QMAJ3C3x\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=0C9ughX4Po/Z46568uNaJZlQ1VtlAbMaVTMSjxvcXjY=;\n\tb=QMAJ3C3xbhpgNJfcA5ykT/qKeCi39vyki5xDrs9T4meW5fKpRQBlcvZQvvEO8uUPeX\n\tfW+nbS/btFfQTBvbTvyaJKtqldlHe7B791+P3PMNGXMlW9CsoVZ1pEczSxsAitXW/2Dc\n\tDpJCq9NK9m9+l2Acqxel+w6utkNPuNHjrjWHtf3l0Fbc5B78BxawPAlPJ65GxTExhnte\n\taHxQ8GA9Bm79OmG+jSPccjxIq/MmhKLSDH6EzYMSQwdx5h9Wd8u/QvhWKGVmAb9NtoS+\n\t0/aIPXyb0a7rwNjkUtUQMEnaL7GBC9+8D7+6K+iB5jI1gxwAIQ3krsj8lKgrDZinneqZ\n\thnqw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=0C9ughX4Po/Z46568uNaJZlQ1VtlAbMaVTMSjxvcXjY=;\n\tb=P5S8zY3SKM+TsAHKxZ63HkLwDqqql/Bp4F4bq0YGlJmcsB9F0WUwqm42Scgdz09nr1\n\tu3IC7TxocuqG7Ov3v1ajpHIw0pIUMW5B0ljQig2TsNjq3l4Wg4JBLjRjo2N1AjnYruSM\n\tyN0VOexFugAU4RiV+3Be3s/6JjLs1KGUQ18YRwKfGqLeKQ7JNM4MxMzaxcqvm+GwNL9x\n\t5uKffCrxabZe8b1IRVmNFAlSBmulei9MrJMxOQMA1qI2vayZoAc/dkB/ReP2q3Ftw63W\n\tRcHVcmU86KIJj8SUNFR0gOUBFaZRGwWp2bz6nYsrpFWU/55IqUv4TwBLG2EpTcGN60Zp\n\taAXg==","X-Gm-Message-State":"AOAM530uCUC6oDwYN4tBsBMHqU1FpDaXMXtiBWnhFVH9vk61LMAeql1f\n\trx6UrhVIeWEYkN2FbCs5XJeOYJwa+pg=","X-Google-Smtp-Source":"ABdhPJxWjaRg3EUFZ3e+nzwz/nGDcSDzzXdGru+BeC5imVw8GHK6mjdGgcJN9J3tbhZH4AC/HZPbmg==","X-Received":"by 2002:adf:ec4e:: with SMTP id\n\tw14mr9703052wrn.280.1594976061676; \n\tFri, 17 Jul 2020 01:54:21 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 17 Jul 2020 09:54:07 +0100","Message-Id":"<20200717085410.732308-8-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200717085410.732308-1-naush@raspberrypi.com>","References":"<20200717085410.732308-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 07/10] libcamera: pipeline:\n\traspberrypi: Fix bug in passing configuration to IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The counter was not incremented, so multiple streams would only pass the\nlast stream config to the IPA.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Niklas Söderlund \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex f63bf497..ce56ad1a 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -988,14 +988,14 @@ int RPiCameraData::configureIPA()\n \tunicam_[Unicam::Image].dev()->getFormat(&sensorFormat);\n \t/* Inform IPA of stream configuration and sensor controls. */\n \tunsigned int i = 0;\n-\tfor (auto const &stream : isp_) {\n+\tfor (auto const &stream : isp_)\n \t\tif (stream.isExternal()) {\n-\t\t\tstreamConfig[i] = {\n+\t\t\tstreamConfig[i++] = {\n \t\t\t\t.pixelFormat = stream.configuration().pixelFormat,\n \t\t\t\t.size = stream.configuration().size\n \t\t\t};\n \t\t}\n-\t}\n+\n \tentityControls.emplace(0, unicam_[Unicam::Image].dev()->controls());\n \tentityControls.emplace(1, isp_[Isp::Input].dev()->controls());\n \n","prefixes":["libcamera-devel","v3","07/10"]}