{"id":8834,"url":"https://patchwork.libcamera.org/api/1.1/patches/8834/?format=json","web_url":"https://patchwork.libcamera.org/patch/8834/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200715142957.24603-1-paul.elder@ideasonboard.com>","date":"2020-07-15T14:29:57","name":"[libcamera-devel] tests: v4l2_compat: Fix v4l2-compliance and v4l2-ctl version parsing","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"70b7ff1ccbb1e648636fd390c3a6ab126dde1860","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8834/mbox/","series":[{"id":1112,"url":"https://patchwork.libcamera.org/api/1.1/series/1112/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1112","date":"2020-07-15T14:29:57","name":"[libcamera-devel] tests: v4l2_compat: Fix v4l2-compliance and v4l2-ctl version parsing","version":1,"mbox":"https://patchwork.libcamera.org/series/1112/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8834/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8834/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CCB0BD792\n\tfor ;\n\tWed, 15 Jul 2020 14:30:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E813609A5;\n\tWed, 15 Jul 2020 16:30:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 21B5C6093A\n\tfor ;\n\tWed, 15 Jul 2020 16:30:09 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C7C9564;\n\tWed, 15 Jul 2020 16:30:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ggo6Aei0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594823408;\n\tbh=SHh606syb72Xwp25w5O9O62FiucRbo5fHqUlZGmkaM0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ggo6Aei08k8RyZBg3p1KczCwpbrqnOYVyqB1KTnDOMKlEPmQj7cih5Ns34iHJWiOk\n\tHHLZwZA03NphghtEc1/kp89O/mjyGHs8jLdKnsGz0to+EQk+veKG/aFuStMpIZgcpJ\n\txNdzrnx2DpUCMLuVOw+NCDixikSqrbfUujlxAImI=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 15 Jul 2020 23:29:57 +0900","Message-Id":"<20200715142957.24603-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] tests: v4l2_compat: Fix v4l2-compliance\n\tand v4l2-ctl version parsing","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"v4l2-compliance originally printed the SHA before the version, leading\nto the indexing that was used previously. Now that the version is\nprinted before the SHA, the indexing is incorrect. Fix this.\n\nAlthough v4l2-ctl doesn't suffer the same issue, it is more correct to\nuse the zeroth index like the v4l2-compliance version check now does, so\nfix that as well.\n\nSigned-off-by: Paul Elder \n---\n test/v4l2_compat/v4l2_compat_test.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py\nindex b054fe6..9867ece 100755\n--- a/test/v4l2_compat/v4l2_compat_test.py\n+++ b/test/v4l2_compat/v4l2_compat_test.py\n@@ -94,7 +94,7 @@ def main(argv):\n return TestSkip\n \n ret, out = run_with_stdout(v4l2_compliance, '--version')\n- if (ret != 0 or version.parse(out[-2].split()[-1]) < MIN_V4L_UTILS_VERSION):\n+ if (ret != 0 or version.parse(out[0].split()[-1]) < MIN_V4L_UTILS_VERSION):\n print('v4l2-compliance version >= 1.21.0 required')\n return TestSkip\n \n@@ -104,7 +104,7 @@ def main(argv):\n return TestSkip\n \n ret, out = run_with_stdout(v4l2_ctl, '--version')\n- if (ret != 0 or version.parse(out[-2].split()[-1]) < MIN_V4L_UTILS_VERSION):\n+ if (ret != 0 or version.parse(out[0].split()[-1]) < MIN_V4L_UTILS_VERSION):\n print('v4l2-ctl version >= 1.21.0 required')\n return TestSkip\n \n","prefixes":["libcamera-devel"]}