{"id":8830,"url":"https://patchwork.libcamera.org/api/1.1/patches/8830/?format=json","web_url":"https://patchwork.libcamera.org/patch/8830/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200715140703.566298-8-naush@raspberrypi.com>","date":"2020-07-15T14:07:00","name":"[libcamera-devel,v2,07/10] libcamera: pipeline: raspberrypi: Fix bug in passing configuration to IPA","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4fec1121eec6172e51e221efab14d27197a45f78","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8830/mbox/","series":[{"id":1111,"url":"https://patchwork.libcamera.org/api/1.1/series/1111/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1111","date":"2020-07-15T14:06:53","name":"Zero-copy RAW stream work","version":2,"mbox":"https://patchwork.libcamera.org/series/1111/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8830/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8830/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11CA9BDB1C\n\tfor ;\n\tWed, 15 Jul 2020 14:07:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD01460C50;\n\tWed, 15 Jul 2020 16:07:23 +0200 (CEST)","from mail-wr1-x444.google.com (mail-wr1-x444.google.com\n\t[IPv6:2a00:1450:4864:20::444])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 61E6F60487\n\tfor ;\n\tWed, 15 Jul 2020 16:07:22 +0200 (CEST)","by mail-wr1-x444.google.com with SMTP id k6so2879560wrn.3\n\tfor ;\n\tWed, 15 Jul 2020 07:07:22 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tl67sm4195339wml.13.2020.07.15.07.07.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 15 Jul 2020 07:07:20 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"jCUHMPex\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=ygtNeMxA39WHsaHOmt9Zi7Yr2keJJ8hfWsz1Zzbb8Qs=;\n\tb=jCUHMPex3LXWugepHSNLCymkCKIAGljCpBjOEI3s7PFI5VJkhgCtnlHXRvApTXqVS/\n\thM6vZdAF7VzDTY2ymGGLz5tzTZQHtM1S+wDTX/7wd6Wx9ZNY0pRhFneS6GvA3QyhuST2\n\tijTjpQZTstKePOs25dOngqyAT+U+F1W7dPP2N26aXXDN+SYOomsoV9dxAkbZd8kwon9m\n\tife5tsvvIvQMQ+dzE8XwnM52+fMLEphj/PLOmYqmX8Rc7deS2gibslKiqGYEskvA231n\n\tdH3SDIQv0yunUeD2Sq+ZUPJwaX+amtbX9dR8pZdATm/04MUW56YunyAl1HoHT7icQeVA\n\twbuw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=ygtNeMxA39WHsaHOmt9Zi7Yr2keJJ8hfWsz1Zzbb8Qs=;\n\tb=NKy5pDh2tK1gFLocW1ha8f4dSQIRsSqwPAgF1ZqaEqk4VbXqJ8CUeMF1zYBjj+0Cff\n\tMyF5+y9MSDeFkU8N1ItOREVWMbSs9exzcOKsi8LLgJtc6+doQqVuIOrXURWAah+ZxvkN\n\tNJTGdZ9wi6KpNdkheN4UeewImclgCDfFC5UsGZjxNZalB67gRW4Qp84qqGrkJXSn17io\n\tmXBaNd01zKsmtMIzyb85EDQk/SewYWeU+ThveV4vjuceknHquTJ3UDLjnG2nJhUvpYf7\n\tCao09kCU2dU874JCb0kkek/W6HZHAhTvnfuXR7nV+bSeMBqwDsZ4/kepGQ/cRRsGsd9l\n\txBqQ==","X-Gm-Message-State":"AOAM532BBnIN/CJJdRu6EwUWy8PAgLgg5I7duii3/VzKUVoQBjmT3lfs\n\t1hzibeV56JteFPBQsfq3QRnW8OcXAjY=","X-Google-Smtp-Source":"ABdhPJwZW42VnIJC9Y7LG8qdvsgQTWym2taewSCJzf3BtBOZk/iMUbtacWzVlFOtNMCDsadzaPmlfQ==","X-Received":"by 2002:a5d:6990:: with SMTP id\n\tg16mr11369540wru.131.1594822041732; \n\tWed, 15 Jul 2020 07:07:21 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 15 Jul 2020 15:07:00 +0100","Message-Id":"<20200715140703.566298-8-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200715140703.566298-1-naush@raspberrypi.com>","References":"<20200715140703.566298-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 07/10] libcamera: pipeline:\n\traspberrypi: Fix bug in passing configuration to IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The counter was not incremented, so multiple streams would only pass the\nlast stream config to the IPA.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Niklas Söderlund \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex cd635eb3..b91f031c 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -856,12 +856,11 @@ int PipelineHandlerRPi::configureIPA(Camera *camera)\n \t/* Inform IPA of stream configuration and sensor controls. */\n \tunsigned int i = 0;\n \tfor (auto const &stream : data->isp_) {\n-\t\tif (stream.isExternal()) {\n-\t\t\tstreamConfig[i] = {\n+\t\tif (stream.isExternal())\n+\t\t\tstreamConfig[i++] = {\n \t\t\t\t.pixelFormat = stream.configuration().pixelFormat,\n \t\t\t\t.size = stream.configuration().size\n \t\t\t};\n-\t\t}\n \t}\n \tentityControls.emplace(0, data->unicam_[Unicam::Image].dev()->controls());\n \tentityControls.emplace(1, data->isp_[Isp::Input].dev()->controls());\n","prefixes":["libcamera-devel","v2","07/10"]}