{"id":8826,"url":"https://patchwork.libcamera.org/api/1.1/patches/8826/?format=json","web_url":"https://patchwork.libcamera.org/patch/8826/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200715140703.566298-4-naush@raspberrypi.com>","date":"2020-07-15T14:06:56","name":"[libcamera-devel,v2,03/10] libcamera: pipeline: raspberrypi: Add some debug logging","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6556ae99126d7e5905142182ad841022458d4870","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8826/mbox/","series":[{"id":1111,"url":"https://patchwork.libcamera.org/api/1.1/series/1111/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1111","date":"2020-07-15T14:06:53","name":"Zero-copy RAW stream work","version":2,"mbox":"https://patchwork.libcamera.org/series/1111/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8826/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8826/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65216BD790\n\tfor ;\n\tWed, 15 Jul 2020 14:07:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D42D609A0;\n\tWed, 15 Jul 2020 16:07:17 +0200 (CEST)","from mail-wm1-x343.google.com (mail-wm1-x343.google.com\n\t[IPv6:2a00:1450:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E0F2609A0\n\tfor ;\n\tWed, 15 Jul 2020 16:07:14 +0200 (CEST)","by mail-wm1-x343.google.com with SMTP id o8so5730065wmh.4\n\tfor ;\n\tWed, 15 Jul 2020 07:07:14 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tl67sm4195339wml.13.2020.07.15.07.07.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 15 Jul 2020 07:07:11 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"HmfkcLQH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=kTU4Ekw107BBgDT7sZ1t6Vbk53bJFssFJ+kUcM6X3B8=;\n\tb=HmfkcLQHdEDwJiVrvqhalLLTj0rSMA0GuOCQ0ONagN2zXzv/2UqprJ7/l5lS21vAZE\n\tqod2cxDe+PFDPzlxx7cgFD4ehrF3m4bqcwIElOyq+cjAcSZzyK6fKqx6vyzB/YbW/N5z\n\t41K4MnM7JztQL230QpFjkI4nfnyGtLxJ8Lv6Xithekp6KNaZAwSIVSo6JmlcS1nZ4bNM\n\t5koI5JpBgGDITz/ZPNH1Z7DvYU8xMx49SkvDMp4OvgeBA5HARpZDf+9ELIHBysb6bRi4\n\t6I+k/ZcivqYxigcgaFjJswif/S0k8JoKSwlqebwNrnKvbWRW12XHTmr1Z2ZoXKnVXxn6\n\tptBQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=kTU4Ekw107BBgDT7sZ1t6Vbk53bJFssFJ+kUcM6X3B8=;\n\tb=YAz8Lhj6b9f1352C7rA5879es6TDAJLTa+7FJHblEc4LCE8x2YoRQLkJqtMSuROC7A\n\tZ+qV5/TBnOFMHzjU5ul/0LLNbbgPgAChtiEB9C/DhTzPw3HHWXlR/4hJbw2I4a/n0S+4\n\tie6HH95DwnN0jT/NCcmYZiEh0rwkB8rDwM3Hnmdfxewkffglt9UYQSGTqiDfiL9aQe3r\n\t7ad3jcXopVAzOGc7JI4uP0EfAfIFRZyPaZdRBWSmXzQ1dSQ/kkwl3hvbhrY88m+SHGM/\n\tltmcy3IATLjXvSDfoy3dkPa9NS8Bq6VELLfsXFGXoZkL54g0gc++aDNSRDTPdBld/7tm\n\tl16w==","X-Gm-Message-State":"AOAM533XRhd/INvbNDIyYqU5/sfMTeXQ7bgO632jZGHtdseezba+TXOn\n\t8fUUJKeTZVHWgit8yqxi6C6WfrdlwHo=","X-Google-Smtp-Source":"ABdhPJy56VfZhqA2qVi7nsQOsJb5D1SgplBgCGJcJB12homlac6G0PpCzhc20Q1zVd+P+8dQCTNUDA==","X-Received":"by 2002:a1c:790c:: with SMTP id l12mr8766811wme.50.1594822033627;\n\tWed, 15 Jul 2020 07:07:13 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 15 Jul 2020 15:06:56 +0100","Message-Id":"<20200715140703.566298-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200715140703.566298-1-naush@raspberrypi.com>","References":"<20200715140703.566298-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 03/10] libcamera: pipeline:\n\traspberrypi: Add some debug logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"No functional changes, only added some more trace points.\n\nSigned-off-by: Naushir Patuck \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 8b6f578f..65c8557d 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1175,6 +1175,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n \tif (state_ == State::Stopped)\n \t\treturn;\n \n+\tLOG(RPI, Debug) << \"Stream ISP Input buffer complete\"\n+\t\t\t<< \", buffer id \" << buffer->cookie()\n+\t\t\t<< \", timestamp: \" << buffer->metadata().timestamp;\n+\n+\t/* The ISP input buffer gets re-queued into Unicam. */\n \thandleStreamBuffer(buffer, &unicam_[Unicam::Image]);\n \thandleState();\n }\n@@ -1339,6 +1344,8 @@ void RPiCameraData::checkRequestCompleted()\n \t\tpipe_->completeRequest(camera_, request);\n \t\trequestQueue_.pop_front();\n \t\trequestCompleted = true;\n+\n+\t\tLOG(RPI, Debug) << \"Request is complete\";\n \t}\n \n \t/*\n@@ -1477,7 +1484,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t\n \t\tif (b->metadata().timestamp < timestamp) {\n \t\t\tq.pop();\n \t\t\tdev->queueBuffer(b);\n-\t\t\tLOG(RPI, Error) << \"Dropping input frame!\";\n+\t\t\tLOG(RPI, Warning) << \"Dropping input frame!\";\n \t\t} else if (b->metadata().timestamp == timestamp) {\n \t\t\t/* The calling function will pop the item from the queue. */\n \t\t\treturn b;\n","prefixes":["libcamera-devel","v2","03/10"]}