{"id":8814,"url":"https://patchwork.libcamera.org/api/1.1/patches/8814/?format=json","web_url":"https://patchwork.libcamera.org/patch/8814/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200715011833.24600-9-laurent.pinchart@ideasonboard.com>","date":"2020-07-15T01:18:28","name":"[libcamera-devel,v2,08/13] media: i2c: ov5647: Parse and register properties","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"02289e10317053743c3b8d4a7017db0c77588b05","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/1.1/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/8814/mbox/","series":[{"id":1108,"url":"https://patchwork.libcamera.org/api/1.1/series/1108/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1108","date":"2020-07-15T01:18:21","name":"raspberrypi: Report sensor orientation through DT","version":2,"mbox":"https://patchwork.libcamera.org/series/1108/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8814/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8814/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A319BD790\n\tfor ;\n\tWed, 15 Jul 2020 01:18:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 570FB60944;\n\tWed, 15 Jul 2020 03:18:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 983996093D\n\tfor ;\n\tWed, 15 Jul 2020 03:18:48 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A1031242;\n\tWed, 15 Jul 2020 03:18:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RSOEjpgo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594775928;\n\tbh=A1KZolLjwP3OO3E1Njd3pbwnQzM87JrFs3FmDDmJM2M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RSOEjpgo4l5peAoDZr9atuzxiLnyGu0vQRqJb83qINQblFzomOxsAAk5pL+G9XfAu\n\tJEVPcpBH0R8wyDv/JMO8c6p8YpCBIuc6FzKdMx5MGX3tYhhyeGcHvCAN4S1GDylRcb\n\tt6DG4lwEMWTcIicF36ccRAhC9UwvnZPNGuc2d3pw=","From":"Laurent Pinchart ","To":"Dave Stevenson ","Date":"Wed, 15 Jul 2020 04:18:28 +0300","Message-Id":"<20200715011833.24600-9-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200715011833.24600-1-laurent.pinchart@ideasonboard.com>","References":"<20200715011833.24600-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 08/13] media: i2c: ov5647: Parse and\n\tregister properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Parse device properties and register controls for them using the V4L2\nfwnode properties helpers.\n\nSigned-off-by: Laurent Pinchart \n---\n drivers/media/i2c/ov5647.c | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c\nindex 6d84d2785f74..86a821a172b3 100644\n--- a/drivers/media/i2c/ov5647.c\n+++ b/drivers/media/i2c/ov5647.c\n@@ -1501,6 +1501,7 @@ static int ov5647_probe(struct i2c_client *client)\n \tstruct device_node *np = client->dev.of_node;\n \tu32 xclk_freq;\n \tint hblank, exposure_max, exposure_def;\n+\tstruct v4l2_fwnode_device_properties props;\n \n \tsensor = devm_kzalloc(dev, sizeof(*sensor), GFP_KERNEL);\n \tif (!sensor)\n@@ -1534,7 +1535,7 @@ static int ov5647_probe(struct i2c_client *client)\n \tmutex_init(&sensor->lock);\n \n \t/* Initialise controls. */\n-\tv4l2_ctrl_handler_init(&sensor->ctrls, 7);\n+\tv4l2_ctrl_handler_init(&sensor->ctrls, 9);\n \tv4l2_ctrl_new_std(&sensor->ctrls, &ov5647_ctrl_ops,\n \t\t\t V4L2_CID_AUTOGAIN,\n \t\t\t 0, /* min */\n@@ -1598,6 +1599,16 @@ static int ov5647_probe(struct i2c_client *client)\n \t\t\t__func__, ret);\n \t\tgoto error;\n \t}\n+\n+\tret = v4l2_fwnode_device_parse(&client->dev, &props);\n+\tif (ret)\n+\t\tgoto error;\n+\n+\tret = v4l2_ctrl_new_fwnode_properties(&sensor->ctrls, &ov5647_ctrl_ops,\n+\t\t\t\t\t &props);\n+\tif (ret)\n+\t\tgoto error;\n+\n \tsensor->sd.ctrl_handler = &sensor->ctrls;\n \n \t/* Write out the register set over I2C on stream-on. */\n","prefixes":["libcamera-devel","v2","08/13"]}