{"id":8790,"url":"https://patchwork.libcamera.org/api/1.1/patches/8790/?format=json","web_url":"https://patchwork.libcamera.org/patch/8790/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200714104212.48683-16-jacopo@jmondi.org>","date":"2020-07-14T10:42:07","name":"[libcamera-devel,15/20] libcamera: ipu3: Remove streams from IPU3CameraConfiguration","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e746425fd3c07c3533e9c0ace5f756cd95d7aaef","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8790/mbox/","series":[{"id":1104,"url":"https://patchwork.libcamera.org/api/1.1/series/1104/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1104","date":"2020-07-14T10:41:52","name":"libcamera: ipu3: Rework pipe configuration","version":1,"mbox":"https://patchwork.libcamera.org/series/1104/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8790/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8790/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7806EBDB1D\n\tfor ;\n\tTue, 14 Jul 2020 10:39:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E047608E0;\n\tTue, 14 Jul 2020 12:39:02 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C88C608E0\n\tfor ;\n\tTue, 14 Jul 2020 12:38:58 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 111E0240011;\n\tTue, 14 Jul 2020 10:38:57 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 14 Jul 2020 12:42:07 +0200","Message-Id":"<20200714104212.48683-16-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200714104212.48683-1-jacopo@jmondi.org>","References":"<20200714104212.48683-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 15/20] libcamera: ipu3: Remove streams\n\tfrom IPU3CameraConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The IPU3CameraConfiguration::streams_ field was used to keep an\nassociation between the StreamConfiguration and the assigned streams\nbefore CameraConfiguration::setStream() was called at configure() time.\n\nThe stream assignment was based on the order in which elements were\ninserted in the vector, implementing a fragile association between\nstreams and their intended configurations.\n\nAs it is now possible to assign streams at validation time, there is no\nneed to keep that association in place, and the streams_ vector is now\nunused.\n\nRemove it and the associated accessor method from the\nIPU3CameraConfiguration class.\n\nReviewed-by: Niklas Söderlund \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 --\n 1 file changed, 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 1161987a4322..2d8b3c501294 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -67,7 +67,6 @@ public:\n \tStatus validate() override;\n \n \tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; };\n-\tconst std::vector &streams() { return streams_; }\n \n private:\n \t/*\n@@ -79,7 +78,6 @@ private:\n \tconst IPU3CameraData *data_;\n \n \tStreamConfiguration cio2Configuration_;\n-\tstd::vector streams_;\n };\n \n class PipelineHandlerIPU3 : public PipelineHandler\n","prefixes":["libcamera-devel","15/20"]}