{"id":8782,"url":"https://patchwork.libcamera.org/api/1.1/patches/8782/?format=json","web_url":"https://patchwork.libcamera.org/patch/8782/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200714104212.48683-8-jacopo@jmondi.org>","date":"2020-07-14T10:41:59","name":"[libcamera-devel,07/20] libcamera: ipu3: cio2: Report format and sizes","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c5b510af2f693ed77113a0c025150f733ce90c6c","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8782/mbox/","series":[{"id":1104,"url":"https://patchwork.libcamera.org/api/1.1/series/1104/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1104","date":"2020-07-14T10:41:52","name":"libcamera: ipu3: Rework pipe configuration","version":1,"mbox":"https://patchwork.libcamera.org/series/1104/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8782/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8782/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 750A8BD792\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 14 Jul 2020 10:38:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 36D8F60900;\n\tTue, 14 Jul 2020 12:38:55 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6F9060832\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Jul 2020 12:38:52 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 57019240015;\n\tTue, 14 Jul 2020 10:38:52 +0000 (UTC)"],"From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 14 Jul 2020 12:41:59 +0200","Message-Id":"<20200714104212.48683-8-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200714104212.48683-1-jacopo@jmondi.org>","References":"<20200714104212.48683-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 07/20] libcamera: ipu3: cio2: Report\n\tformat and sizes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Add two methods to the CIO2Device class to retrieve all the supported\nPixelFormats and sizes.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/cio2.cpp | 40 ++++++++++++++++++++++++++++\n src/libcamera/pipeline/ipu3/cio2.h   |  5 ++++\n 2 files changed, 45 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\nindex 77f54da47e28..ff436e0dae41 100644\n--- a/src/libcamera/pipeline/ipu3/cio2.cpp\n+++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n@@ -9,6 +9,7 @@\n \n #include <linux/media-bus-format.h>\n \n+#include <libcamera/geometry.h>\n #include <libcamera/formats.h>\n #include <libcamera/stream.h>\n \n@@ -43,6 +44,45 @@ CIO2Device::~CIO2Device()\n \tdelete sensor_;\n }\n \n+/**\n+ * \\brief Retrieve the list of supported PixelFormats\n+ *\n+ * Retrieve the list of supported pixel formats by matching the sensor produced\n+ * media bus codes with the formats supported by the CIO2 unit.\n+ *\n+ * \\return The list of supported PixelFormat\n+ */\n+std::vector<PixelFormat> CIO2Device::formats() const\n+{\n+\tif (!sensor_)\n+\t\treturn {};\n+\n+\tstd::vector<PixelFormat> formats;\n+\tfor (unsigned int code : sensor_->mbusCodes()) {\n+\t\tauto it = mbusCodesToPixelFormat.find(code);\n+\t\tif (it != mbusCodesToPixelFormat.end())\n+\t\t\tformats.push_back(it->second);\n+\t}\n+\n+\treturn formats;\n+}\n+\n+/**\n+ * \\brief Retrieve the list of supported size ranges\n+ * \\return The list of supported SizeRange\n+ */\n+std::vector<SizeRange> CIO2Device::sizes() const\n+{\n+\tif (!sensor_)\n+\t\treturn {};\n+\n+\tstd::vector<SizeRange> sizes;\n+\tfor (const Size &size : sensor_->sizes())\n+\t\tsizes.emplace_back(size, size);\n+\n+\treturn sizes;\n+}\n+\n /**\n  * \\brief Initialize components of the CIO2 device with \\a index\n  * \\param[in] media The CIO2 media device\ndiff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h\nindex 4fd949f8e513..f905d97fa79d 100644\n--- a/src/libcamera/pipeline/ipu3/cio2.h\n+++ b/src/libcamera/pipeline/ipu3/cio2.h\n@@ -20,7 +20,9 @@ namespace libcamera {\n class CameraSensor;\n class FrameBuffer;\n class MediaDevice;\n+class PixelFormat;\n class Request;\n+class SizeRange;\n class V4L2Subdevice;\n struct Size;\n struct StreamConfiguration;\n@@ -33,6 +35,9 @@ public:\n \tCIO2Device();\n \t~CIO2Device();\n \n+\tstd::vector<PixelFormat> formats() const;\n+\tstd::vector<SizeRange> sizes() const;\n+\n \tint init(const MediaDevice *media, unsigned int index);\n \tint configure(const Size &size, V4L2DeviceFormat *outputFormat);\n \n","prefixes":["libcamera-devel","07/20"]}