{"id":8772,"url":"https://patchwork.libcamera.org/api/1.1/patches/8772/?format=json","web_url":"https://patchwork.libcamera.org/patch/8772/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200714090936.9562-2-laurent.pinchart@ideasonboard.com>","date":"2020-07-14T09:09:34","name":"[libcamera-devel,v2,2/4] test: file: Add read/write tests","commit_ref":"7e1c153c223b47e4d4308a128da185bc9e4b7bba","pull_url":null,"state":"accepted","archived":false,"hash":"f8a0da313c270acd46e85f7ad02260ee4ce0d155","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8772/mbox/","series":[{"id":1103,"url":"https://patchwork.libcamera.org/api/1.1/series/1103/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1103","date":"2020-07-14T09:09:33","name":"[libcamera-devel,v2,1/4] libcamera: file: Add read/write support","version":2,"mbox":"https://patchwork.libcamera.org/series/1103/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8772/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8772/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB5C6BD790\n\tfor ;\n\tTue, 14 Jul 2020 09:09:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EEA4B60738;\n\tTue, 14 Jul 2020 11:09:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D80960484\n\tfor ;\n\tTue, 14 Jul 2020 11:09:47 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 015E971D\n\tfor ;\n\tTue, 14 Jul 2020 11:09:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"t5JpDZxQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594717787;\n\tbh=1r1YaBcFysKsRXmZAoZrhf3gFg1lsLvxu624Xa8W7gA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=t5JpDZxQfH5BEtzq6hXxUlcA6aWiORJ3ynhJw3n0cBOBOmSGXxYWRtd2hyd6VlJBy\n\tg6YZGfaIuCmIde0S447UavdkxfcnmzHtqk9UJAligotnvtY0/uC/xkMU9Cm7Kng1v8\n\ta7/2eaKiriCHfU6ZQFO1eobj2a5t5P2z0kjaScjc=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 14 Jul 2020 12:09:34 +0300","Message-Id":"<20200714090936.9562-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200714090936.9562-1-laurent.pinchart@ideasonboard.com>","References":"<20200714090936.9562-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 2/4] test: file: Add read/write tests","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add tests for the File::read() and File::write() functions.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \nReviewed-by: Niklas Söderlund \n---\n test/file.cpp | 65 ++++++++++++++++++++++++++++++++++++++++++++++++---\n 1 file changed, 62 insertions(+), 3 deletions(-)","diff":"diff --git a/test/file.cpp b/test/file.cpp\nindex 287831f3ef37..7688a9dc224a 100644\n--- a/test/file.cpp\n+++ b/test/file.cpp\n@@ -30,11 +30,9 @@ protected:\n \t\tif (fd == -1)\n \t\t\treturn TestFail;\n \n-\t\tssize_t ret = write(fd, \"libcamera\", 9);\n-\n \t\tclose(fd);\n \n-\t\treturn ret == 9 ? TestPass : TestFail;\n+\t\treturn TestPass;\n \t}\n \n \tint run()\n@@ -191,7 +189,68 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n+\t\tfile.close();\n+\n+\t\t/* Test read and write. */\n+\t\tstd::array buffer = { 0 };\n+\n+\t\tstrncpy(reinterpret_cast(buffer.data()), \"libcamera\",\n+\t\t\tbuffer.size());\n+\n+\t\tfile.setFileName(fileName_);\n+\n+\t\tif (file.read(buffer) >= 0) {\n+\t\t\tcerr << \"Read succeeded on closed file\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.write(buffer) >= 0) {\n+\t\t\tcerr << \"Write succeeded on closed file\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tfile.open(File::ReadOnly);\n+\n+\t\tif (file.write(buffer) >= 0) {\n+\t\t\tcerr << \"Write succeeded on read-only file\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tfile.close();\n+\n+\t\tfile.open(File::ReadWrite);\n+\n+\t\tif (file.write({ buffer.data(), 9 }) != 9) {\n+\t\t\tcerr << \"Write test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.read(buffer) != 0) {\n+\t\t\tcerr << \"Read at end of file test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.seek(0) != 0) {\n+\t\t\tcerr << \"Seek test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.read(buffer) != 9) {\n+\t\t\tcerr << \"Read test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (file.pos() != 9) {\n+\t\t\tcerr << \"Position test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tfile.close();\n+\n \t\t/* Test mapping and unmapping. */\n+\t\tfile.setFileName(\"/proc/self/exe\");\n+\t\tfile.open(File::ReadOnly);\n+\n \t\tSpan data = file.map();\n \t\tif (data.empty()) {\n \t\t\tcerr << \"Mapping of complete file failed\" << endl;\n","prefixes":["libcamera-devel","v2","2/4"]}