{"id":8753,"url":"https://patchwork.libcamera.org/api/1.1/patches/8753/?format=json","web_url":"https://patchwork.libcamera.org/patch/8753/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200713084727.232422-4-naush@raspberrypi.com>","date":"2020-07-13T08:47:22","name":"[libcamera-devel,3/9] libcamera: pipeline: raspberrypi: Add some debug logging","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6556ae99126d7e5905142182ad841022458d4870","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8753/mbox/","series":[{"id":1100,"url":"https://patchwork.libcamera.org/api/1.1/series/1100/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1100","date":"2020-07-13T08:47:18","name":"Zero-copy RAW stream work","version":1,"mbox":"https://patchwork.libcamera.org/series/1100/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8753/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8753/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 98F77BD790\n\tfor ;\n\tMon, 13 Jul 2020 08:48:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1EC9B605C1;\n\tMon, 13 Jul 2020 10:48:03 +0200 (CEST)","from mail-wr1-x443.google.com (mail-wr1-x443.google.com\n\t[IPv6:2a00:1450:4864:20::443])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C53D605B9\n\tfor ;\n\tMon, 13 Jul 2020 10:48:01 +0200 (CEST)","by mail-wr1-x443.google.com with SMTP id f2so14986035wrp.7\n\tfor ;\n\tMon, 13 Jul 2020 01:48:01 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tg14sm23203357wrm.93.2020.07.13.01.47.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 13 Jul 2020 01:47:59 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ZLaYTAem\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=kTU4Ekw107BBgDT7sZ1t6Vbk53bJFssFJ+kUcM6X3B8=;\n\tb=ZLaYTAemSo/xfKk3VgEJrWrPfsPaSiIVlnfVQrawlb7gr6vPlmBW1QBGG6YE20jTGh\n\tytM/tzUIwxoHJo20kIZY3k0UbXuK1cTQ8fWUazd5mynGn6OsOm3rL/mbMMCYz8/teriW\n\tmd9j5N72aF4Y5VZH+UyG9Y2uX7ooLGn/qw0ODfVoqXDV+gce9PKwKgjDSUGqER/w7ayS\n\ty7g2dXhiFwCjF54XxlCXYwH9e/XyaAefcOYb6ZAT4XK86Nud8517ayBT2n713gznuxs7\n\tm7EfceM8HlNY/9/4N3R5iCwYJIDve4kGnCobBNm3vZa5Lsu4F97eWhCESIS6Tbi6xvK7\n\tMuDA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=kTU4Ekw107BBgDT7sZ1t6Vbk53bJFssFJ+kUcM6X3B8=;\n\tb=DV4k3vN3CRiK9GgvVNSTSPSHDX+tPwKe6eC7UET9DaFn+rdkDM/3B19BLoAS0lEO6y\n\tvS8+4NYFwrUVdMEq7m/baHkbJpZOSMDz/k9CvS+a4PN6yXPcskq2na0P7EqbC+esVnH6\n\tZVX3GrxJqg5+GYmG31UeLcecsJBNPJA62YTA30BFQd7TN2r8cY/5JIolvJ0PVVszPFSk\n\tcsq2gUkXKofZ5K4XrWp8HdoJRR6wbHOcsIrmoXjGJuLk3+/nP4nG4h3VHp3AAyN8qW1z\n\tEWiKw7A7Jwxbbrm/pmHh7oL1fqUq3kQGCIZtwsngbA59CuqyTDaxBQpiMfTMMBuw2Kva\n\t621A==","X-Gm-Message-State":"AOAM532cF0rHfcaH3k7ABO1KjnfPhYWnoeOHLnwbe0xId3awIT5tLQzl\n\tX9XZLXoxJfvDcjLfo0lWQExhZHF1/Ak=","X-Google-Smtp-Source":"ABdhPJwZy44QySL7ZtEhEmpYxkzqWpdcYpGdZMJWzp+gKsbKKQ0bEI6ifmAb93b9bmNjZyKXRLLOrg==","X-Received":"by 2002:a5d:5084:: with SMTP id\n\ta4mr81230998wrt.191.1594630080378; \n\tMon, 13 Jul 2020 01:48:00 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 13 Jul 2020 09:47:22 +0100","Message-Id":"<20200713084727.232422-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200713084727.232422-1-naush@raspberrypi.com>","References":"<20200713084727.232422-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 3/9] libcamera: pipeline: raspberrypi: Add\n\tsome debug logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"No functional changes, only added some more trace points.\n\nSigned-off-by: Naushir Patuck \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 8b6f578f..65c8557d 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1175,6 +1175,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n \tif (state_ == State::Stopped)\n \t\treturn;\n \n+\tLOG(RPI, Debug) << \"Stream ISP Input buffer complete\"\n+\t\t\t<< \", buffer id \" << buffer->cookie()\n+\t\t\t<< \", timestamp: \" << buffer->metadata().timestamp;\n+\n+\t/* The ISP input buffer gets re-queued into Unicam. */\n \thandleStreamBuffer(buffer, &unicam_[Unicam::Image]);\n \thandleState();\n }\n@@ -1339,6 +1344,8 @@ void RPiCameraData::checkRequestCompleted()\n \t\tpipe_->completeRequest(camera_, request);\n \t\trequestQueue_.pop_front();\n \t\trequestCompleted = true;\n+\n+\t\tLOG(RPI, Debug) << \"Request is complete\";\n \t}\n \n \t/*\n@@ -1477,7 +1484,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t\n \t\tif (b->metadata().timestamp < timestamp) {\n \t\t\tq.pop();\n \t\t\tdev->queueBuffer(b);\n-\t\t\tLOG(RPI, Error) << \"Dropping input frame!\";\n+\t\t\tLOG(RPI, Warning) << \"Dropping input frame!\";\n \t\t} else if (b->metadata().timestamp == timestamp) {\n \t\t\t/* The calling function will pop the item from the queue. */\n \t\t\treturn b;\n","prefixes":["libcamera-devel","3/9"]}