{"id":8742,"url":"https://patchwork.libcamera.org/api/1.1/patches/8742/?format=json","web_url":"https://patchwork.libcamera.org/patch/8742/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200710141508.468834-2-paul.elder@ideasonboard.com>","date":"2020-07-10T14:15:08","name":"[libcamera-devel,2/2] tests: v4l2_compat: Check v4l2-compliance and v4l2-ctl versions","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a3644e5d5db8f8a6b9e2205ddea305a953071daa","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8742/mbox/","series":[{"id":1096,"url":"https://patchwork.libcamera.org/api/1.1/series/1096/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1096","date":"2020-07-10T14:15:07","name":"[libcamera-devel,1/2] tests: v4l2_compat: Prettify failure output","version":1,"mbox":"https://patchwork.libcamera.org/series/1096/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8742/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8742/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4BEC8BD792\n\tfor ;\n\tFri, 10 Jul 2020 14:15:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED51560491;\n\tFri, 10 Jul 2020 16:15:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB9866048E\n\tfor ;\n\tFri, 10 Jul 2020 16:15:32 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6334624A;\n\tFri, 10 Jul 2020 16:15:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ix397TAf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594390532;\n\tbh=an8UnZLBpD9vilkwcygVHV2cfqGUdiDBWT7hrUlc9+U=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ix397TAfaZutSgeUZYRozuuJGdKWp3VckqYxUdBVFB8DTh919K230JSeOOw5pwWT0\n\tVVSVGN7NeH4T4c99bgHv3tJixjG3xv3MdSicC36GG8HP2kkkD2h3etl4CnwF9mhMA3\n\tJ9CA8f74XTHGMrXbpgPT7HbRMkk3+iiiqZ9YDzL4=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 10 Jul 2020 23:15:08 +0900","Message-Id":"<20200710141508.468834-2-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200710141508.468834-1-paul.elder@ideasonboard.com>","References":"<20200710141508.468834-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/2] tests: v4l2_compat: Check\n\tv4l2-compliance and v4l2-ctl versions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"v4l2-compliance and v4l2-ctl with version 1.20 and before will fail with\nv4l2-compat. Check the versions of v4l2-compliance and v4l2-ctl before\ncontinuing, though since neither of them currently are able to print\ntheir version, simply checking if they can do so is sufficient.\n\nSigned-off-by: Paul Elder \n\n---\nObviously this depends on v4l2-compliance and v4l2-ctl having --version,\nso that needs to be accepted first before this can be merged.\n---\n test/v4l2_compat/v4l2_compat_test.py | 10 ++++++++++\n 1 file changed, 10 insertions(+)","diff":"diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py\nindex 8a8e59e..c97ae79 100755\n--- a/test/v4l2_compat/v4l2_compat_test.py\n+++ b/test/v4l2_compat/v4l2_compat_test.py\n@@ -98,11 +98,21 @@ def main(argv):\n print('v4l2-compliance is not available')\n return TestSkip\n \n+ ret, _ = run_with_stdout(v4l2_compliance, '--version')\n+ if (ret != 0):\n+ print('v4l2-compliance version >= 1.21.0 required')\n+ return TestSkip\n+\n v4l2_ctl = shutil.which('v4l2-ctl')\n if v4l2_ctl is None:\n print('v4l2-ctl is not available')\n return TestSkip\n \n+ ret, _ = run_with_stdout(v4l2_ctl, '--version')\n+ if (ret != 0):\n+ print('v4l2-ctl version >= 1.21.0 required')\n+ return TestSkip\n+\n dev_nodes = glob.glob('/dev/video*')\n if len(dev_nodes) == 0:\n print('no video nodes available to test with')\n","prefixes":["libcamera-devel","2/2"]}