{"id":8741,"url":"https://patchwork.libcamera.org/api/1.1/patches/8741/?format=json","web_url":"https://patchwork.libcamera.org/patch/8741/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200710141508.468834-1-paul.elder@ideasonboard.com>","date":"2020-07-10T14:15:07","name":"[libcamera-devel,1/2] tests: v4l2_compat: Prettify failure output","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5629dd98e6811a66cce557388abf371988bd8d88","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8741/mbox/","series":[{"id":1096,"url":"https://patchwork.libcamera.org/api/1.1/series/1096/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1096","date":"2020-07-10T14:15:07","name":"[libcamera-devel,1/2] tests: v4l2_compat: Prettify failure output","version":1,"mbox":"https://patchwork.libcamera.org/series/1096/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8741/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8741/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 169AABD792\n\tfor ;\n\tFri, 10 Jul 2020 14:15:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A8A76048B;\n\tFri, 10 Jul 2020 16:15:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 180BD6048A\n\tfor ;\n\tFri, 10 Jul 2020 16:15:31 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7502924A;\n\tFri, 10 Jul 2020 16:15:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PAljE+52\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594390530;\n\tbh=pu7Y9MxN2gTKVDBey7sxu6mu7whTzq2FyzcyUFtoUqY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=PAljE+52Jb+PW5i2FZvJW968iwt8cx4uIzwwnv+KxC+cA5RncxTfbbJSlnkXU8P1J\n\tnueXywuF4n8Y14SHfUv/5EVVtK6R+e5s8ui6MOHM+6QdsnS61rztoUE5VsPUGHDMVU\n\t9oakllNyVicrBgmR56aGXYvnMII983yEUv0bsCmo=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 10 Jul 2020 23:15:07 +0900","Message-Id":"<20200710141508.468834-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 1/2] tests: v4l2_compat: Prettify failure\n\toutput","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When a test is being run on a video device, there is output like so:\n\nTesting /dev/video0 with uvcvideo driver...\n\nand when it succeeds, \"success\" is appended:\n\nTesting /dev/video0 with uvcvideo driver... success\n\nOn failure, however, the output of v4l2-compliance is printed before\n\"failure\" is printed, resulting in the first line of the v4l2-compliance\noutput to be printed on the same line as the message:\n\nTesting /dev/video2 with uvcvideo driver... v4l2-compliance SHA: not available, 64 bits\n\nfailure\n\nMove printing of \"failure\" to the print_output_arr(), where the failed\ntest output is printed, to prettify the output upon failure.\n\nSigned-off-by: Paul Elder \n---\n test/v4l2_compat/v4l2_compat_test.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py\nindex 99b3d5a..8a8e59e 100755\n--- a/test/v4l2_compat/v4l2_compat_test.py\n+++ b/test/v4l2_compat/v4l2_compat_test.py\n@@ -55,6 +55,7 @@ def extract_result(result):\n \n \n def print_output_arr(output_arr):\n+ print('failed')\n print('\\n'.join(output_arr))\n \n \n@@ -135,7 +136,6 @@ def main(argv):\n ret = test_v4l2_compliance(v4l2_compliance, v4l2_compat, device, driver)\n if ret == TestFail:\n failed.append(device)\n- print('failed')\n else:\n print('success')\n drivers_tested[driver] = True\n","prefixes":["libcamera-devel","1/2"]}