{"id":8725,"url":"https://patchwork.libcamera.org/api/1.1/patches/8725/?format=json","web_url":"https://patchwork.libcamera.org/patch/8725/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200709132835.112593-11-paul.elder@ideasonboard.com>","date":"2020-07-09T13:28:22","name":"[libcamera-devel,v5,10/23] libcamera: pipeline: raspberrypi: Filter out unsupported formats","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f18a6500717294beef543aa2bea00956472ad3e7","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8725/mbox/","series":[{"id":1093,"url":"https://patchwork.libcamera.org/api/1.1/series/1093/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1093","date":"2020-07-09T13:28:12","name":"Clean up formats in v4l2-compat and pipeline handlers","version":5,"mbox":"https://patchwork.libcamera.org/series/1093/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8725/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8725/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79D69BD792\n\tfor ;\n\tThu, 9 Jul 2020 13:29:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 45BF1611BA;\n\tThu, 9 Jul 2020 15:29:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31A7861184\n\tfor ;\n\tThu, 9 Jul 2020 15:29:14 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 61826525;\n\tThu, 9 Jul 2020 15:29:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IvDTQCVt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594301353;\n\tbh=u09l7K9pwnR7PbnwEbP4TQQ+9RS3agnCH2OAV8C1hvg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=IvDTQCVts7S66Q6r+RywnmMvMCvnR1YfMES3DDdLR+KfxqMWAyT8/h/+MYBh7DZ9c\n\tN5INnYdkZZZEDMMgwpxq5BhgclmXmT6PSJgvi4Cs62s2zObtAQ48s9HWvyCw9GNwSd\n\t318Dc81E9U/zrfe8Xy9buFfTradLrPtF8QaXtliQ=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 9 Jul 2020 22:28:22 +0900","Message-Id":"<20200709132835.112593-11-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200709132835.112593-1-paul.elder@ideasonboard.com>","References":"<20200709132835.112593-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 10/23] libcamera: pipeline:\n\traspberrypi: Filter out unsupported formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Unsupported formats should not be added to the configuration when\ngenerating the configuration. Filter them out.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \n\n---\nNo change in v5\n\nCosmetic change in v4\n\nNo change in v3\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 +++++-------\n 1 file changed, 5 insertions(+), 7 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex cbb6f1c..1822ac9 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -569,13 +569,11 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera,\n \n \t\t/* Translate the V4L2PixelFormat to PixelFormat. */\n \t\tstd::map> deviceFormats;\n-\t\tstd::transform(fmts.begin(), fmts.end(), std::inserter(deviceFormats, deviceFormats.end()),\n-\t\t\t [&](const decltype(fmts)::value_type &format) {\n-\t\t\t\t\treturn decltype(deviceFormats)::value_type{\n-\t\t\t\t\t\tformat.first.toPixelFormat(),\n-\t\t\t\t\t\tformat.second\n-\t\t\t\t\t};\n-\t\t\t });\n+\t\tfor (const auto &format : fmts) {\n+\t\t\tPixelFormat pixelFormat = format.first.toPixelFormat();\n+\t\t\tif (pixelFormat.isValid())\n+\t\t\t\tdeviceFormats[pixelFormat] = format.second;\n+\t\t}\n \n \t\t/* Add the stream format based on the device node used for the use case. */\n \t\tStreamFormats formats(deviceFormats);\n","prefixes":["libcamera-devel","v5","10/23"]}