{"id":8717,"url":"https://patchwork.libcamera.org/api/1.1/patches/8717/?format=json","web_url":"https://patchwork.libcamera.org/patch/8717/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200709132835.112593-3-paul.elder@ideasonboard.com>","date":"2020-07-09T13:28:14","name":"[libcamera-devel,v5,02/23] libcamera: formats: Add fields to info to ease calculating stride","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"924a9825f3ae05b60fbb427922780ab51b013eda","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8717/mbox/","series":[{"id":1093,"url":"https://patchwork.libcamera.org/api/1.1/series/1093/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1093","date":"2020-07-09T13:28:12","name":"Clean up formats in v4l2-compat and pipeline handlers","version":5,"mbox":"https://patchwork.libcamera.org/series/1093/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8717/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8717/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 15946BD792\n\tfor ;\n\tThu, 9 Jul 2020 13:28:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5FAE6121D;\n\tThu, 9 Jul 2020 15:28:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 011D161184\n\tfor ;\n\tThu, 9 Jul 2020 15:28:54 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4A60C525;\n\tThu, 9 Jul 2020 15:28:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cOlW+dwt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594301333;\n\tbh=2cbNYJyLfZmn/gHZyIqLeMm7sRXatlZLvw1LzCh2APk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cOlW+dwt0F6rJr6GC3yIxEf083k6EOpV/gTTVkRxynBvAxM4R77BreSpGE/7ZzbK7\n\tRLLRZT3KKSls3SeDeVVnikJkivZPz0rfKNZTCWMZjg8iPuAnyAEwVXaAZcjumPplAM\n\tCbUB3iof0V9anb+IhSNoHo8ebGr1IaQMz80vaY4s=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 9 Jul 2020 22:28:14 +0900","Message-Id":"<20200709132835.112593-3-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200709132835.112593-1-paul.elder@ideasonboard.com>","References":"<20200709132835.112593-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 02/23] libcamera: formats: Add fields\n\tto info to ease calculating stride","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Packed formats make it difficult to calculate stride as well as\nframe size with the fields that PixelFormatInfo currently has.\nbitsPerPixel is defined as the average number of bits per pixel, and\nonly counts effective bits, so it is not useful for calculating\nstride and frame size.\n\nTo fix this, we introduce a concept of a \"pixel group\". The size of this\ngroup is defined as the minimum number of pixels (including padding)\nnecessary in a row when the image has only one column of effective\npixels. The pixel group has one more attribute, that is the \"bytes per\ngroup\". This determines how many bytes one pixel group consumes. These\nare the fields pixelsPerGroup and bytesPerGroup that are defined in this\npatch. Defining these two values makes it really simple to calculate\nbytes-per-line, as ceil(width / pixelsPerGroup) * bytesPerGroup, where\nwidth is measured in number of pixels. The ceiling accounts for padding.\n\nThe pixel group has another contraint, which is that the pixel group\n(bytesPerGroup and pixelsPerGroup) is the smallest repeatable unit. What\nthis means is that, for example, in the IPU3 formats, if there is only\none column of effective pixels, it looks like it could be fit in 5 bytes\nwith 3 padding pixels (for a total of 4 pixels over 5 bytes). However,\nthis unit is not repeatable, as at the 7th group in the same row, the\npattern is broken. Therefore, the pixel group for IPU3 formats must be\n25 pixels over 32 bytes.\n\nClearly, pixelsPerGroup must be constant for all planes in the format.\nThe bytesPerGroup then, must be a per-plane attribute. There is one more\nfield, verticalSubSampling, that is per-plane. This is simply a divider,\nto divide the number of rows of pixels by the sub-sampling value, to\nobtain the number of rows of pixels for the subsampled plane.\n\nFor example, for something simple like BGR888, it is self-explanatory:\nthe pixel group size is 1, and the bytes necessary is 3, and there is\nonly one plane with no (= 1) vertical subsampling. For YUYV, the\nCbCr pair is shared between two pixels, so even if you have only one\npixel, you would still need a padded second Y, therefore the pixel\ngroup size is 2, and bytes necessary is 4 (as opposed to 1 and 2). YUYV\nalso has no vertical subsampling. NV12 has a pixel group size of 2\npixels, due to the CbCr plane. The bytes per group then, for both\nplanes, is 2. The first plane has no vertical subsampling, but the\nsecond plane is subsampled by a factor of 2.\nThe IPU3 formats are also self-explanatory, as they are single-planar,\nand have a pixel group size of 25, consuming 32 bytes. Although a\ncomment in the driver suggests that it should be 50 and 64,\nrespectively, this is an attribute of the driver, and not the format, so\nthis shall be set by the ipu3 pipeline handler.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \nReviewed-by: Jacopo Mondi \nReviewed-by: Kieran Bingham \n\n---\nChanges in v5:\n- add #include to fix cros compile error\n\nChanges in v4:\n- expanded documentation and definition of pixel group\n\nChanges in v3:\n- add planes\n- redefine the parameters for the formats\n - pixelsPerGroup is for whole format\n - add verticalSubSampling per plane\n\nChanges in v2:\n- add documentation for bytesPerGroup pixelsPerGroup\n- fix wording in commit message\n - bytes-per-line -> stride\n - buffer size -> frame size\n- changed MJPEG todo to allowing pipeline handlers to set parameters of\n format infos\n---\n include/libcamera/internal/formats.h | 11 ++\n src/libcamera/formats.cpp | 148 +++++++++++++++++++++++++++\n 2 files changed, 159 insertions(+)","diff":"diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\nindex f59ac8f..4e90e5a 100644\n--- a/include/libcamera/internal/formats.h\n+++ b/include/libcamera/internal/formats.h\n@@ -8,6 +8,7 @@\n #ifndef __LIBCAMERA_INTERNAL_FORMATS_H__\n #define __LIBCAMERA_INTERNAL_FORMATS_H__\n \n+#include \n #include \n #include \n \n@@ -32,6 +33,12 @@ private:\n \tstd::map> data_;\n };\n \n+struct PixelFormatPlaneInfo\n+{\n+\tunsigned int bytesPerGroup;\n+\tunsigned int verticalSubSampling;\n+};\n+\n class PixelFormatInfo\n {\n public:\n@@ -52,6 +59,10 @@ public:\n \tunsigned int bitsPerPixel;\n \tenum ColourEncoding colourEncoding;\n \tbool packed;\n+\n+\tunsigned int pixelsPerGroup;\n+\n+\tstd::array planes;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex d3b722c..e6d3d3b 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -110,6 +110,22 @@ const std::map> &ImageFormats::data() const\n \treturn data_;\n }\n \n+/**\n+ * \\class PixelFormatPlaneInfo\n+ * \\brief Information about a single plane of a pixel format\n+ *\n+ * \\var PixelFormatPlaneInfo::bytesPerGroup\n+ * \\brief The number of bytes that a pixel group consumes\n+ *\n+ * \\sa PixelFormatInfo::pixelsPerGroup\n+ *\n+ * \\var PixelFormatPlaneInfo::verticalSubSampling\n+ * \\brief Vertical subsampling multiplier\n+ *\n+ * This value is the ratio between the number of rows of pixels in the frame\n+ * to the number of rows of pixels in the plane.\n+ */\n+\n /**\n * \\class PixelFormatInfo\n * \\brief Information about pixel formats\n@@ -152,6 +168,49 @@ const std::map> &ImageFormats::data() const\n * bytes. For instance, 12-bit Bayer data with two pixels stored in three bytes\n * is packed, while the same data stored with 4 bits of padding in two bytes\n * per pixel is not packed.\n+ *\n+ * \\var PixelFormatInfo::pixelsPerGroup\n+ * \\brief The number of pixels in a pixel group\n+ *\n+ * The minimum number of pixels (including padding) necessary in a row\n+ * when the frame has only one column of effective pixels.\n+ *\n+ * A pixel group is defined as the minimum number of pixels (including padding)\n+ * necessary in a row when the image has only one column of effective pixels.\n+ * pixelsPerGroup refers to this value. PixelFormatPlaneInfo::bytesPerGroup,\n+ * then, refers to the number of bytes that a pixel group consumes. This\n+ * definition of a pixel group allows simple calculation of stride, as\n+ * ceil(width / pixelsPerGroup) * bytesPerGroup. These values are determined\n+ * only in terms of a row. The ceiling accounts for padding.\n+ *\n+ * A pixel group has a second constraint, such that the pixel group\n+ * (bytesPerGroup and pixelsPerGroup) is the smallest repeatable unit.\n+ * What this means is that, for example, in the IPU3 formats, if there is only\n+ * one column of effective pixels, it looks like it could be fit in 5 bytes\n+ * with 3 padding pixels (for a total of 4 pixels over 5 bytes). However, this\n+ * unit is not repeatable, as at the 7th group in the same row, the pattern\n+ * is broken. Therefore, the pixel group for IPU3 formats must be 25 pixels\n+ * over 32 bytes.\n+ *\n+ * For example, for something simple like BGR888, it is self-explanatory:\n+ * the pixel group size is 1, and the bytes necessary is 3, and there is\n+ * only one plane with no (= 1) vertical subsampling. For YUYV, the\n+ * CbCr pair is shared between two pixels, so even if you have only one\n+ * pixel, you would still need a padded second Y sample, therefore the pixel\n+ * group size is 2, and bytes necessary is 4. YUYV also has no vertical\n+ * subsampling. NV12 has a pixel group size of 2 pixels, due to the CbCr plane.\n+ * The bytes per group then, for both planes, is 2. The first plane has no\n+ * vertical subsampling, but the second plane is subsampled by a factor of 2.\n+ * The IPU3 formats are also self-explanatory, as they are single-planar,\n+ * and have a pixel group size of 25, consuming 32 bytes. Although a\n+ * comment in the driver suggests that it should be 50 and 64,\n+ * respectively, this is an attribute of the driver, and not the format, so\n+ * this shall be set by the ipu3 pipeline handler.\n+ *\n+ * \\var PixelFormatInfo::planes\n+ * \\brief Information about pixels for each plane\n+ *\n+ * \\sa PixelFormatPlaneInfo\n */\n \n /**\n@@ -179,6 +238,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 24,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::RGB888, {\n \t\t.name = \"RGB888\",\n@@ -187,6 +248,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 24,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::ABGR8888, {\n \t\t.name = \"ABGR8888\",\n@@ -195,6 +258,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 32,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::ARGB8888, {\n \t\t.name = \"ARGB8888\",\n@@ -203,6 +268,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 32,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::BGRA8888, {\n \t\t.name = \"BGRA8888\",\n@@ -211,6 +278,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 32,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::RGBA8888, {\n \t\t.name = \"RGBA8888\",\n@@ -219,6 +288,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 32,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \n \t/* YUV packed formats. */\n@@ -229,6 +300,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 16,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::YVYU, {\n \t\t.name = \"YVYU\",\n@@ -237,6 +310,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 16,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::UYVY, {\n \t\t.name = \"UYVY\",\n@@ -245,6 +320,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 16,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::VYUY, {\n \t\t.name = \"VYUY\",\n@@ -253,6 +330,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 16,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \n \t/* YUV planar formats. */\n@@ -263,6 +342,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 12,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 2, 2 }, { 0, 0 } }},\n \t} },\n \t{ formats::NV21, {\n \t\t.name = \"NV21\",\n@@ -271,6 +352,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 12,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 2, 2 }, { 0, 0 } }},\n \t} },\n \t{ formats::NV16, {\n \t\t.name = \"NV16\",\n@@ -279,6 +362,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 16,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 2, 1 }, { 0, 0 } }},\n \t} },\n \t{ formats::NV61, {\n \t\t.name = \"NV61\",\n@@ -287,6 +372,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 16,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 2, 1 }, { 0, 0 } }},\n \t} },\n \t{ formats::NV24, {\n \t\t.name = \"NV24\",\n@@ -295,6 +382,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 24,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 1, 1 }, { 2, 1 }, { 0, 0 } }},\n \t} },\n \t{ formats::NV42, {\n \t\t.name = \"NV42\",\n@@ -303,6 +392,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 24,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 1, 1 }, { 2, 1 }, { 0, 0 } }},\n \t} },\n \t{ formats::YUV420, {\n \t\t.name = \"YUV420\",\n@@ -311,6 +402,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 12,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 1, 2 }, { 1, 2 } }},\n \t} },\n \t{ formats::YUV422, {\n \t\t.name = \"YUV422\",\n@@ -319,6 +412,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 16,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 1, 1 }, { 1, 1 } }},\n \t} },\n \n \t/* Greyscale formats. */\n@@ -329,6 +424,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 8,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 1, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \n \t/* Bayer formats. */\n@@ -339,6 +436,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 8,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SGBRG8, {\n \t\t.name = \"SGBRG8\",\n@@ -347,6 +446,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 8,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SGRBG8, {\n \t\t.name = \"SGRBG8\",\n@@ -355,6 +456,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 8,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SRGGB8, {\n \t\t.name = \"SRGGB8\",\n@@ -363,6 +466,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 8,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SBGGR10, {\n \t\t.name = \"SBGGR10\",\n@@ -371,6 +476,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 10,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SGBRG10, {\n \t\t.name = \"SGBRG10\",\n@@ -379,6 +486,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 10,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SGRBG10, {\n \t\t.name = \"SGRBG10\",\n@@ -387,6 +496,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 10,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SRGGB10, {\n \t\t.name = \"SRGGB10\",\n@@ -395,6 +506,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 10,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SBGGR10_CSI2P, {\n \t\t.name = \"SBGGR10_CSI2P\",\n@@ -403,6 +516,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 10,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = true,\n+\t\t.pixelsPerGroup = 4,\n+\t\t.planes = {{ { 5, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SGBRG10_CSI2P, {\n \t\t.name = \"SGBRG10_CSI2P\",\n@@ -411,6 +526,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 10,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = true,\n+\t\t.pixelsPerGroup = 4,\n+\t\t.planes = {{ { 5, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SGRBG10_CSI2P, {\n \t\t.name = \"SGRBG10_CSI2P\",\n@@ -419,6 +536,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 10,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = true,\n+\t\t.pixelsPerGroup = 4,\n+\t\t.planes = {{ { 5, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SRGGB10_CSI2P, {\n \t\t.name = \"SRGGB10_CSI2P\",\n@@ -427,6 +546,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 10,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = true,\n+\t\t.pixelsPerGroup = 4,\n+\t\t.planes = {{ { 5, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SBGGR12, {\n \t\t.name = \"SBGGR12\",\n@@ -435,6 +556,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 12,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SGBRG12, {\n \t\t.name = \"SGBRG12\",\n@@ -443,6 +566,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 12,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SGRBG12, {\n \t\t.name = \"SGRBG12\",\n@@ -451,6 +576,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 12,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SRGGB12, {\n \t\t.name = \"SRGGB12\",\n@@ -459,6 +586,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 12,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SBGGR12_CSI2P, {\n \t\t.name = \"SBGGR12_CSI2P\",\n@@ -467,6 +596,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 12,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = true,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SGBRG12_CSI2P, {\n \t\t.name = \"SGBRG12_CSI2P\",\n@@ -475,6 +606,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 12,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = true,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SGRBG12_CSI2P, {\n \t\t.name = \"SGRBG12_CSI2P\",\n@@ -483,6 +616,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 12,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = true,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SRGGB12_CSI2P, {\n \t\t.name = \"SRGGB12_CSI2P\",\n@@ -491,6 +626,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 12,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = true,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SBGGR10_IPU3, {\n \t\t.name = \"SBGGR10_IPU3\",\n@@ -499,6 +636,9 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 10,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = true,\n+\t\t/* \\todo remember to double this in the ipu3 pipeline handler */\n+\t\t.pixelsPerGroup = 25,\n+\t\t.planes = {{ { 32, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SGBRG10_IPU3, {\n \t\t.name = \"SGBRG10_IPU3\",\n@@ -507,6 +647,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 10,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = true,\n+\t\t.pixelsPerGroup = 25,\n+\t\t.planes = {{ { 32, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SGRBG10_IPU3, {\n \t\t.name = \"SGRBG10_IPU3\",\n@@ -515,6 +657,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 10,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = true,\n+\t\t.pixelsPerGroup = 25,\n+\t\t.planes = {{ { 32, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \t{ formats::SRGGB10_IPU3, {\n \t\t.name = \"SRGGB10_IPU3\",\n@@ -523,6 +667,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 10,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = true,\n+\t\t.pixelsPerGroup = 25,\n+\t\t.planes = {{ { 32, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n \n \t/* Compressed formats. */\n@@ -533,6 +679,8 @@ const std::map pixelFormatInfo{\n \t\t.bitsPerPixel = 0,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n \t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 1, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n };\n \n","prefixes":["libcamera-devel","v5","02/23"]}