{"id":8703,"url":"https://patchwork.libcamera.org/api/1.1/patches/8703/?format=json","web_url":"https://patchwork.libcamera.org/patch/8703/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200709084128.5316-13-jacopo@jmondi.org>","date":"2020-07-09T08:41:20","name":"[libcamera-devel,v2,12/20] libcamera: ipu3: Always use the maximum frame size","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"405afa3b4aa63fe599c58c938503d5a377ca6a1e","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/1.1/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/8703/mbox/","series":[{"id":1091,"url":"https://patchwork.libcamera.org/api/1.1/series/1091/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1091","date":"2020-07-09T08:41:08","name":"libcamera: ipu3: Rework configuration","version":2,"mbox":"https://patchwork.libcamera.org/series/1091/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8703/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8703/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F048CBD790\n\tfor ;\n\tThu, 9 Jul 2020 08:38:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90C70611A9;\n\tThu, 9 Jul 2020 10:38:17 +0200 (CEST)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C29061158\n\tfor ;\n\tThu, 9 Jul 2020 10:38:15 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id E2996100015;\n\tThu, 9 Jul 2020 08:38:14 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 9 Jul 2020 10:41:20 +0200","Message-Id":"<20200709084128.5316-13-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200709084128.5316-1-jacopo@jmondi.org>","References":"<20200709084128.5316-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 12/20] libcamera: ipu3: Always use the\n\tmaximum frame size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The requirement of having the ImgU output height 32 pixels smaller\nthan the input frame produced by the CIO2 makes it complicated to\nre-adjust the sensor produced size after the alignement has been\napplied.\n\nTo simplify the procedure, always ask for the full frame size from the\nCIO2 unit.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 12 ++++--------\n 1 file changed, 4 insertions(+), 8 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex d07f1a7b5ae8..feabffe641e1 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -156,8 +156,6 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n \tunsigned int rawCount = 0;\n \tunsigned int outCount = 0;\n \tSize yuvSize;\n-\tSize size;\n-\n \tfor (const StreamConfiguration &cfg : config_) {\n \t\tconst PixelFormatInfo &info =\n \t\t\tPixelFormatInfo::info(cfg.pixelFormat);\n@@ -174,11 +172,6 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n \t\t\tif (cfg.size > yuvSize)\n \t\t\t\tyuvSize = cfg.size;\n \t\t}\n-\n-\t\tif (cfg.size.width > size.width)\n-\t\t\tsize.width = cfg.size.width;\n-\t\tif (cfg.size.height > size.height)\n-\t\t\tsize.height = cfg.size.height;\n \t}\n \tif (rawCount > 1 || outCount > 2) {\n \t\tLOG(IPU3, Error)\n@@ -189,10 +182,13 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n \t}\n \n \t/* Generate raw configuration from CIO2. */\n-\tcio2Configuration_ = data_->cio2_.generateConfiguration(size);\n+\tSize sensorSize = data_->cio2_.sensor()->resolution();\n+\tcio2Configuration_ = data_->cio2_.generateConfiguration(sensorSize);\n \tif (!cio2Configuration_.pixelFormat.isValid())\n \t\treturn Invalid;\n \n+\tLOG(IPU3, Debug) << \"CIO2 configuration: \" << cio2Configuration_.toString();\n+\n \t/*\n \t * Adjust the configurations if needed and assign streams while\n \t * iterating them.\n","prefixes":["libcamera-devel","v2","12/20"]}