{"id":8688,"url":"https://patchwork.libcamera.org/api/1.1/patches/8688/?format=json","web_url":"https://patchwork.libcamera.org/patch/8688/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200708134417.67747-20-paul.elder@ideasonboard.com>","date":"2020-07-08T13:44:15","name":"[libcamera-devel,v4,19/21] libcamera: vimc: Fill stride and frameSize at config validation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b20af871ae68676a687ac564fb285e9e5339f3a2","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8688/mbox/","series":[{"id":1090,"url":"https://patchwork.libcamera.org/api/1.1/series/1090/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1090","date":"2020-07-08T13:43:56","name":"Clean up formats in v4l2-compat and pipeline handlers","version":4,"mbox":"https://patchwork.libcamera.org/series/1090/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8688/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8688/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FCF6BD792\n\tfor ;\n\tWed, 8 Jul 2020 13:45:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC0D06114E;\n\tWed, 8 Jul 2020 15:45:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1474C6112A\n\tfor ;\n\tWed, 8 Jul 2020 15:45:10 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91FE451B;\n\tWed, 8 Jul 2020 15:45:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OrFHEoIu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594215909;\n\tbh=A1GQXz7ImwqbDGp9VBrYQKOl1xTwPGCwgk2BOwYAQvs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OrFHEoIuR8cF+wJLRqiSULxl80d1qPmHm1v10TQMp0o8vvrAIkFgLMOW4N+LIUiX5\n\tfXXMcZesglOmVDu7oaw5hVmw7u5gAxO5KIfSRQRCo66dMZVXmBAL4k7h6DXf5ulxt5\n\td/1CakFWk/us4+vP64M6ahZjlaSDswZViCler7tw=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 8 Jul 2020 22:44:15 +0900","Message-Id":"<20200708134417.67747-20-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200708134417.67747-1-paul.elder@ideasonboard.com>","References":"<20200708134417.67747-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 19/21] libcamera: vimc: Fill stride and\n\tframeSize at config validation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Fill the stride and frameSize fields of the StreamConfiguration at\nconfiguration validation time instead of at camera configuration time.\nThis allows applications to get the stride when trying a configuration\nwithout modifying the active configuration of the camera.\n\nSigned-off-by: Paul Elder \n\n---\nChanges in v4:\n- mention motivation in commit message\n- get stride and frameSize from tryFormat on capture video node\n\nNew in v3\n---\n src/libcamera/pipeline/vimc/vimc.cpp | 23 ++++++++++++++++++-----\n 1 file changed, 18 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex b653066..a6f457c 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -72,9 +72,12 @@ public:\n class VimcCameraConfiguration : public CameraConfiguration\n {\n public:\n-\tVimcCameraConfiguration();\n+\tVimcCameraConfiguration(VimcCameraData *data);\n \n \tStatus validate() override;\n+\n+private:\n+\tVimcCameraData *data_;\n };\n \n class PipelineHandlerVimc : public PipelineHandler\n@@ -115,8 +118,8 @@ static const std::map pixelformats{\n \n } /* namespace */\n \n-VimcCameraConfiguration::VimcCameraConfiguration()\n-\t: CameraConfiguration()\n+VimcCameraConfiguration::VimcCameraConfiguration(VimcCameraData *data)\n+\t: CameraConfiguration(), data_(data)\n {\n }\n \n@@ -160,6 +163,17 @@ CameraConfiguration::Status VimcCameraConfiguration::validate()\n \n \tcfg.bufferCount = 4;\n \n+\tV4L2DeviceFormat format = {};\n+\tformat.fourcc = data_->video_->toV4L2PixelFormat(cfg.pixelFormat);\n+\tformat.size = cfg.size;\n+\n+\tint ret = data_->video_->tryFormat(&format);\n+\tif (ret)\n+\t\treturn Invalid;\n+\n+\tcfg.stride = format.planes[0].bpl;\n+\tcfg.frameSize = format.planes[0].size;\n+\n \treturn status;\n }\n \n@@ -171,8 +185,8 @@ PipelineHandlerVimc::PipelineHandlerVimc(CameraManager *manager)\n CameraConfiguration *PipelineHandlerVimc::generateConfiguration(Camera *camera,\n \tconst StreamRoles &roles)\n {\n-\tCameraConfiguration *config = new VimcCameraConfiguration();\n \tVimcCameraData *data = cameraData(camera);\n+\tCameraConfiguration *config = new VimcCameraConfiguration(data);\n \n \tif (roles.empty())\n \t\treturn config;\n@@ -282,7 +296,6 @@ int PipelineHandlerVimc::configure(Camera *camera, CameraConfiguration *config)\n \t\treturn ret;\n \n \tcfg.setStream(&data->stream_);\n-\tcfg.stride = format.planes[0].bpl;\n \n \treturn 0;\n }\n","prefixes":["libcamera-devel","v4","19/21"]}