{"id":8678,"url":"https://patchwork.libcamera.org/api/1.1/patches/8678/?format=json","web_url":"https://patchwork.libcamera.org/patch/8678/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200708134417.67747-10-paul.elder@ideasonboard.com>","date":"2020-07-08T13:44:05","name":"[libcamera-devel,v4,09/21] libcamera: pipeline: raspberrypi: Simplify format fetching","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"412f8bb9478c23dc0944a406e7696c03e91a1087","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8678/mbox/","series":[{"id":1090,"url":"https://patchwork.libcamera.org/api/1.1/series/1090/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1090","date":"2020-07-08T13:43:56","name":"Clean up formats in v4l2-compat and pipeline handlers","version":4,"mbox":"https://patchwork.libcamera.org/series/1090/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8678/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8678/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53DC4BD792\n\tfor ;\n\tWed, 8 Jul 2020 13:44:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2051161111;\n\tWed, 8 Jul 2020 15:44:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4CD4C6110E\n\tfor ;\n\tWed, 8 Jul 2020 15:44:49 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 93FF951B;\n\tWed, 8 Jul 2020 15:44:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FkUFKhc4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594215889;\n\tbh=7AsjP/RSwx6wJiBdvga1b9O9G0aKSODLSpNJEBifihA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=FkUFKhc4s/8EOfTk61TNZrS0WV+IgQL+RLCIF8vG4Wygf/Lm+Qfxa+tcZ3TsCGm6J\n\tmpDayVuqBxgHJrCuVtNQz+Hjg8EfZaMSEU5GEULA7h2cG1llmRcKUq1On7pqjbGvyw\n\t0GjoBfyexodk7gZdeYCz/ORjdnu98pUKLL5nlmlo=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 8 Jul 2020 22:44:05 +0900","Message-Id":"<20200708134417.67747-10-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200708134417.67747-1-paul.elder@ideasonboard.com>","References":"<20200708134417.67747-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 09/21] libcamera: pipeline:\n\traspberrypi: Simplify format fetching","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Simplify code for looking up PixelFormatInfo using a V4L2 format by\nusing the new PixelFormatInfo lookup function based on V4L2 format.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \n\n---\nNo change in v4\n\nNo change in v3\n\nChanges in v2:\n- just a few words in the commit message\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex f4966f8..1c0000b 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -81,8 +81,7 @@ V4L2DeviceFormat findBestMode(V4L2PixFmtMap &formatsMap, const Size &req)\n \t/* Calculate the closest/best mode from the user requested size. */\n \tfor (const auto &iter : formatsMap) {\n \t\tV4L2PixelFormat v4l2Format = iter.first;\n-\t\tPixelFormat pixelFormat = v4l2Format.toPixelFormat();\n-\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(pixelFormat);\n+\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(v4l2Format);\n \n \t\tfor (const SizeRange &sz : iter.second) {\n \t\t\tdouble modeWidth = sz.contains(req) ? req.width : sz.max.width;\n","prefixes":["libcamera-devel","v4","09/21"]}