{"id":8668,"url":"https://patchwork.libcamera.org/api/1.1/patches/8668/?format=json","web_url":"https://patchwork.libcamera.org/patch/8668/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200706230240.2482100-9-kieran.bingham@ideasonboard.com>","date":"2020-07-06T23:02:40","name":"[libcamera-devel,v5,8/8] android: camera_device: Remove single buffer restriction.","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ddb42c8e33ce431d10619f4e3887fd27f8c3a64b","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8668/mbox/","series":[{"id":1089,"url":"https://patchwork.libcamera.org/api/1.1/series/1089/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1089","date":"2020-07-06T23:02:32","name":"android: Multi-stream support","version":5,"mbox":"https://patchwork.libcamera.org/series/1089/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8668/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8668/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78815BD792\n\tfor ;\n\tMon, 6 Jul 2020 23:02:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 43DD560EA5;\n\tTue, 7 Jul 2020 01:02:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B503660E93\n\tfor ;\n\tTue, 7 Jul 2020 01:02:49 +0200 (CEST)","from Q.local (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net\n\t[86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E629D98;\n\tTue, 7 Jul 2020 01:02:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UyYjfFAK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594076569;\n\tbh=wNkIVJ+85VHhGpNWaNuTCq9mFioRD4RQauKUpGssb0E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=UyYjfFAKSrKoelDpwGrU4rYJqv2V9Q8VsEqYYRDqKdxyUiYHQ0cGUDFq83yiLoUpQ\n\tbNS9isgCQeS4oD48Z8b5zwNirSJtcjNSZ5j07LD3I61NOtZ4V6FtwgxEpEd2A0BoIW\n\txuMaEReDHEqQYLrv8olJhRHxE59cosKCxpKtTC94=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Tue, 7 Jul 2020 00:02:40 +0100","Message-Id":"<20200706230240.2482100-9-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200706230240.2482100-1-kieran.bingham@ideasonboard.com>","References":"<20200706230240.2482100-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 8/8] android: camera_device: Remove\n\tsingle buffer restriction.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A capture request is no longer limited to a single output buffer.\nRemove the limitation, but (for now) keep the check to ensure that\nat least one buffer is always provided.\n\nSigned-off-by: Kieran Bingham \nReviewed-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \nReviewed-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex b13729e84abf..95a7368d8ebc 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1050,9 +1050,8 @@ FrameBuffer *CameraDevice::createFrameBuffer(const buffer_handle_t camera3buffer\n \n int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)\n {\n-\tif (camera3Request->num_output_buffers != 1) {\n-\t\tLOG(HAL, Error) << \"Invalid number of output buffers: \"\n-\t\t\t\t<< camera3Request->num_output_buffers;\n+\tif (!camera3Request->num_output_buffers) {\n+\t\tLOG(HAL, Error) << \"No output buffers provided\";\n \t\treturn -EINVAL;\n \t}\n \n","prefixes":["libcamera-devel","v5","8/8"]}