{"id":8645,"url":"https://patchwork.libcamera.org/api/1.1/patches/8645/?format=json","web_url":"https://patchwork.libcamera.org/patch/8645/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200706085625.1625432-2-naush@raspberrypi.com>","date":"2020-07-06T08:56:23","name":"[libcamera-devel,v2,1/3] libcamera: controls: Add focus Figure of Merit (FoM) control","commit_ref":"c905870cd0f1d6c1af048669ea744bc1de8062de","pull_url":null,"state":"accepted","archived":false,"hash":"3b7969fd1cae3b3abbf35626a5c52f61d276a2e0","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8645/mbox/","series":[{"id":1084,"url":"https://patchwork.libcamera.org/api/1.1/series/1084/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1084","date":"2020-07-06T08:56:22","name":"Focus feedback control","version":2,"mbox":"https://patchwork.libcamera.org/series/1084/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8645/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8645/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13EBEBD792\n\tfor ;\n\tMon, 6 Jul 2020 08:56:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B1B760C59;\n\tMon, 6 Jul 2020 10:56:39 +0200 (CEST)","from mail-wm1-x343.google.com (mail-wm1-x343.google.com\n\t[IPv6:2a00:1450:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CEE77603B1\n\tfor ;\n\tMon, 6 Jul 2020 10:56:37 +0200 (CEST)","by mail-wm1-x343.google.com with SMTP id f139so41030059wmf.5\n\tfor ;\n\tMon, 06 Jul 2020 01:56:37 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tk185sm22600282wmk.47.2020.07.06.01.56.36\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 06 Jul 2020 01:56:36 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"F0pF90f6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=n32uuMBO84Te9GK7nFDuckXfnJke7rImJZsKTjKeGHo=;\n\tb=F0pF90f62UV/HMZ1BFzIQw9YGSyfhO3RStkuJu+emd0g69HlWWfyDHnhfVm538/6zH\n\tRPfhQA+G70DfGwwRDdppfYxyRGydn0IfuP8ER0RPuLzRyaM71wIj5rEDmPjuZxLI5UFs\n\tD0vfS8wLfNBTYz56E42ZvH/Rldt8X5nxUjf8MM89qi7iey1VNA4HTbPYn0/bRPU7+CSK\n\tgke4VfyefoNfTmHmMyB4RtdWimZKQcdpD0yYDpvRFDb8l2GKbCNgcTn6OuDbELwpMJrq\n\tcx/QKPHRaRpmR49eyBIk/fPj8LsCgbWftytWc9nNm61XDi7FFSRRI5wrJ0IXewVzv/+M\n\tbNdA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=n32uuMBO84Te9GK7nFDuckXfnJke7rImJZsKTjKeGHo=;\n\tb=a4m0FcxqIWnZ5D3HUVQ1qmXPYPYrVTe7KhggbuPNd+Go74uOSzQLivQ0Hucce7Ivam\n\tIy5zW+pdNGqAHimzDuNKeJKnS0HcLXl5HzCBuSMXW2SawC3kcOrre1Dnd4e6aTjmYcaK\n\thlq/Qyssup4Uzunz781wpLbkoQSD8VNilBfSxCYp5+5gCGQxym06zaMYwg9dMeWiapv4\n\t9xLzekuKXD8ub+GZL7jHJeY3aww0fUbK9pxhjsdn/1TVkhWcMxRB+qwzHDJp8BZ7fAvS\n\tS29GJ0nNmawBGQ7Omk/UfnmezBNst4UjiZUeHr9FMQ4p7Spq4LZE10Fq+OzcMLCaVkQu\n\tOi+w==","X-Gm-Message-State":"AOAM5311CsyBzASgBHsZXu89xyxTDfHnPHL82ozQdwWFK1c9uv0dDZ51\n\tz870QVMVzWG/Sp88BTC5MFeFE15HJoY=","X-Google-Smtp-Source":"ABdhPJxO+fpRFEhFBsfWJUcZH/VsYfQqiGEHTMEsk7zz93zoRYVCnwmQ4PCCycE6EebvJkm2OU36zw==","X-Received":"by 2002:a1c:1bc6:: with SMTP id\n\tb189mr46471606wmb.166.1594025797276; \n\tMon, 06 Jul 2020 01:56:37 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 6 Jul 2020 09:56:23 +0100","Message-Id":"<20200706085625.1625432-2-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200706085625.1625432-1-naush@raspberrypi.com>","References":"<20200706085625.1625432-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 1/3] libcamera: controls: Add focus\n\tFigure of Merit (FoM) control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide a control to allow the IPA to return a FoM to indicate how\nin-focus a scene is. Note, this is not to be used as a means to\nimplement a focus algorithm by the application, rather an indication of\nhow in-focus a scene is.\n\nSigned-off-by: Naushir Patuck \n---\n src/libcamera/control_ids.yaml | 11 +++++++++++\n 1 file changed, 11 insertions(+)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 8c3e4c72..988b5016 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -251,4 +251,15 @@ controls:\n higher than anyone could reasonably want. Negative values are\n not allowed. Note also that sharpening is not applied to raw\n streams.\n+\n+ - FocusFoM:\n+ type: int32_t\n+ description: |\n+ Reports a Figure of Merit (FoM) to indicate how in-focus the frame is.\n+ A larger FocusFoM value indicates a more in-focus frame. This control\n+ depends on the IPA to gather ISP statistics from the defined focus\n+ region, and combine them in a suitable way to generate a FocusFoM value.\n+ In this respect, it is not necessarily aimed at providing a way to\n+ implement a focus algorithm by the application, rather an indication of\n+ how in-focus a frame is.\n ...\n","prefixes":["libcamera-devel","v2","1/3"]}