{"id":8611,"url":"https://patchwork.libcamera.org/api/1.1/patches/8611/?format=json","web_url":"https://patchwork.libcamera.org/patch/8611/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200704005227.21782-8-laurent.pinchart@ideasonboard.com>","date":"2020-07-04T00:52:22","name":"[libcamera-devel,v2,07/12] libcamera: pipeline: raspberrypi: Don't call handleState() in stop state","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"f1773afa051474fb9a35926d019cd3baeffdfcc7","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/1.1/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/8611/mbox/","series":[{"id":1081,"url":"https://patchwork.libcamera.org/api/1.1/series/1081/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1081","date":"2020-07-04T00:52:15","name":"Support passing custom data to IPA configure()","version":2,"mbox":"https://patchwork.libcamera.org/series/1081/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8611/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8611/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 905CDC2E69\n\tfor ;\n\tSat, 4 Jul 2020 00:52:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 38E2860DC0;\n\tSat, 4 Jul 2020 02:52:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A9F6460CAE\n\tfor ;\n\tSat, 4 Jul 2020 02:52:39 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 36D2B29E;\n\tSat, 4 Jul 2020 02:52:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ESxXZUR6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593823959;\n\tbh=cTovLdMVwGYNRuXjbNnWeuW8EJtG+I2TzsX1lrbb+mY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ESxXZUR6cn9M6W5bWLrTk2gZqs5uwQ6jFHfWeJGY20STGVleus6IW7+K3JUY2FPVZ\n\twm5URMbJOzzLDduC61sGH6ddxkbub9VGEwy33j+BWgTtXumIwUjbjlZiWRHUc9w8LO\n\teUMQPsJcneWm1YyCIVlCbrYFkz/9NeEranDo69NE=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 4 Jul 2020 03:52:22 +0300","Message-Id":"<20200704005227.21782-8-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200704005227.21782-1-laurent.pinchart@ideasonboard.com>","References":"<20200704005227.21782-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 07/12] libcamera: pipeline:\n\traspberrypi: Don't call handleState() in stop state","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The handleState() function is a no-op when the state is State::Stopped.\nDon't call it in that case, which simplifies the caller.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex a05fc68b98fa..74bee6895dcd 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1188,7 +1188,7 @@ void RPiCameraData::queueFrameAction(unsigned int frame, const IPAOperationData\n \t\tControlList controls = action.controls[0];\n \t\tif (!staggeredCtrl_.set(controls))\n \t\t\tLOG(RPI, Error) << \"V4L2 staggered set failed\";\n-\t\tgoto done;\n+\t\treturn;\n \t}\n \n \tcase RPI_IPA_ACTION_SET_SENSOR_CONFIG: {\n@@ -1206,18 +1206,18 @@ void RPiCameraData::queueFrameAction(unsigned int frame, const IPAOperationData\n \t\t/* Set the sensor orientation here as well. */\n \t\tControlList controls = action.controls[0];\n \t\tunicam_[Unicam::Image].dev()->setControls(&controls);\n-\t\tgoto done;\n+\t\treturn;\n \t}\n \n \tcase RPI_IPA_ACTION_V4L2_SET_ISP: {\n \t\tControlList controls = action.controls[0];\n \t\tisp_[Isp::Input].dev()->setControls(&controls);\n-\t\tgoto done;\n+\t\treturn;\n \t}\n \t}\n \n \tif (state_ == State::Stopped)\n-\t\tgoto done;\n+\t\treturn;\n \n \t/*\n \t * The following actions must not be handled when the pipeline handler\n@@ -1261,7 +1261,6 @@ void RPiCameraData::queueFrameAction(unsigned int frame, const IPAOperationData\n \t\tbreak;\n \t}\n \n-done:\n \thandleState();\n }\n \n","prefixes":["libcamera-devel","v2","07/12"]}