{"id":8570,"url":"https://patchwork.libcamera.org/api/1.1/patches/8570/?format=json","web_url":"https://patchwork.libcamera.org/patch/8570/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200703001422.24324-2-laurent.pinchart@ideasonboard.com>","date":"2020-07-03T00:14:13","name":"[libcamera-devel,01/10] utils: raspberrypi: ctt: json_pretty_print: Fix printer test","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b3db439b0ffd8ad3622b1eb41ee59e7e52cfc351","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8570/mbox/","series":[{"id":1076,"url":"https://patchwork.libcamera.org/api/1.1/series/1076/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1076","date":"2020-07-03T00:14:12","name":"utils: raspberrypi: ctt: Improve JSON pretty printer","version":1,"mbox":"https://patchwork.libcamera.org/series/1076/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8570/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8570/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD780BE905\n\tfor ;\n\tFri, 3 Jul 2020 00:14:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 316B160C5F;\n\tFri, 3 Jul 2020 02:14:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59338609C7\n\tfor ;\n\tFri, 3 Jul 2020 02:14:34 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF230A2D;\n\tFri, 3 Jul 2020 02:14:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"W7b0ECgw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593735274;\n\tbh=6cVZuua9BYmUrOOA7o5LCM5TKsuZcuOUdWeLqktF5wU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=W7b0ECgwyTU1lYlCMDC+mdnil9XETYtq6XLPkjJKJ4TIPlaHCn8kZg3snO44Vw+uj\n\tvgLthYkBENYEPQSWJPPPB0GRwY/C1e8qr58ahXB3YLk1IwrOnL7dI/+O3K2q28Ea+8\n\tcEEcIjQuX8NHwr345emLu8k/UEEF5eCuvd5EWawg=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 3 Jul 2020 03:14:13 +0300","Message-Id":"<20200703001422.24324-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200703001422.24324-1-laurent.pinchart@ideasonboard.com>","References":"<20200703001422.24324-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 01/10] utils: raspberrypi: ctt:\n\tjson_pretty_print: Fix printer test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ctt_pretty_print_json.py file supports being run standalone to test\nthe code. It however suffers from multiple issues:\n\n- The same input file name is hardcoded, and doesn't exist in the\n repository\n- The input file name is used instead of JSON data\n\nFix both issues and make the input file selectable on the command line.\n\nSigned-off-by: Laurent Pinchart \n---\n utils/raspberrypi/ctt/ctt_pretty_print_json.py | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)","diff":"diff --git a/utils/raspberrypi/ctt/ctt_pretty_print_json.py b/utils/raspberrypi/ctt/ctt_pretty_print_json.py\nindex 73383ea09665..18938c828b4e 100644\n--- a/utils/raspberrypi/ctt/ctt_pretty_print_json.py\n+++ b/utils/raspberrypi/ctt/ctt_pretty_print_json.py\n@@ -4,6 +4,8 @@\n #\n # ctt_pretty_print_json.py - camera tuning tool JSON formatter\n \n+import sys\n+\n \n \"\"\"\n takes a collapsed json file and makes it more readable\n@@ -72,4 +74,10 @@ def pretty_print_json(str_in, output_filename):\n \n \n if __name__ == '__main__':\n- pretty_print_json(\"../ctt/ref_json/final_imx477.json\", \"pretty.json\")\n+ if len(sys.argv) != 2:\n+ print(\"Usage: %s filename\" % sys.argv[0])\n+ sys.exit(1)\n+\n+ input_filename = sys.argv[1]\n+ with open(input_filename, \"r\") as fin:\n+ pretty_print_json(fin.read(), \"pretty.json\")\n","prefixes":["libcamera-devel","01/10"]}