{"id":8564,"url":"https://patchwork.libcamera.org/api/1.1/patches/8564/?format=json","web_url":"https://patchwork.libcamera.org/patch/8564/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200702213654.2129054-10-kieran.bingham@ideasonboard.com>","date":"2020-07-02T21:36:54","name":"[libcamera-devel,v2,9/9] android: camera_device: Report an error in notifyError()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"44b91af50607da407f73d3462ffe23c0ef450bcb","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8564/mbox/","series":[{"id":1073,"url":"https://patchwork.libcamera.org/api/1.1/series/1073/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1073","date":"2020-07-02T21:36:45","name":"android: Multi-stream support","version":2,"mbox":"https://patchwork.libcamera.org/series/1073/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8564/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8564/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DD510BE905\n\tfor ;\n\tThu, 2 Jul 2020 21:37:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E0F860C59;\n\tThu, 2 Jul 2020 23:37:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EFB6460C64\n\tfor ;\n\tThu, 2 Jul 2020 23:37:05 +0200 (CEST)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 876049CB;\n\tThu, 2 Jul 2020 23:37:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PfmaNaLe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593725825;\n\tbh=p3mmoYXL1A+kaLsOv4/KaDG50/FQkOc3w+uf8npORwA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PfmaNaLefmAZwCPvIS9kPCm7F4msXFTq7pxfyy4beiB3LP0NHO8fAUFw08S8W6IEC\n\tx+ZGK8rMVQ4OdrK57oPKB+KCToF+8aZJ2lyk7ZlLDeD+G0ezITqUPuzOTyRnFVScge\n\twEN+xT6VmMF2k6T5RJSSUjPYtcBzJtw5S24YmP3o=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Thu, 2 Jul 2020 22:36:54 +0100","Message-Id":"<20200702213654.2129054-10-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200702213654.2129054-1-kieran.bingham@ideasonboard.com>","References":"<20200702213654.2129054-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 9/9] android: camera_device: Report an\n\terror in notifyError()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If an error is generated, try to be verbose about it in the libcamera logs.\n\nSigned-off-by: Kieran Bingham \n---\n src/android/camera_device.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 4681fd8af90b..5a3b4dfae6a0 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1192,6 +1192,9 @@ void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream)\n {\n \tcamera3_notify_msg_t notify = {};\n \n+\tLOG(HAL, Error) << \"Error occured on frame \" << frameNumber\n+\t\t\t<< toPixelFormat(stream->format);\n+\n \tnotify.type = CAMERA3_MSG_ERROR;\n \tnotify.message.error.error_stream = stream;\n \tnotify.message.error.frame_number = frameNumber;\n","prefixes":["libcamera-devel","v2","9/9"]}