{"id":8550,"url":"https://patchwork.libcamera.org/api/1.1/patches/8550/?format=json","web_url":"https://patchwork.libcamera.org/patch/8550/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200701211650.1002567-3-niklas.soderlund@ragnatech.se>","date":"2020-07-01T21:16:50","name":"[libcamera-devel,RFC,2/2] libcamera: formats: Remove ImageFormats","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5952c36123e39aca6bb603f97051ddc7d5fed54e","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8550/mbox/","series":[{"id":1070,"url":"https://patchwork.libcamera.org/api/1.1/series/1070/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1070","date":"2020-07-01T21:16:48","name":"libcamera: formats: Remove ImageFormats","version":1,"mbox":"https://patchwork.libcamera.org/series/1070/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8550/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8550/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3255BBE905\n\tfor ;\n\tWed, 1 Jul 2020 21:17:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 08EFD60C5C;\n\tWed, 1 Jul 2020 23:17:02 +0200 (CEST)","from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7B7E60C57\n\tfor ;\n\tWed, 1 Jul 2020 23:16:59 +0200 (CEST)","from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 32dd038a-bbe0-11ea-8fb8-005056917f90;\n\tWed, 01 Jul 2020 23:16:59 +0200 (CEST)"],"X-Halon-ID":"32dd038a-bbe0-11ea-8fb8-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 1 Jul 2020 23:16:50 +0200","Message-Id":"<20200701211650.1002567-3-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200701211650.1002567-1-niklas.soderlund@ragnatech.se>","References":"<20200701211650.1002567-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC 2/2] libcamera: formats: Remove ImageFormats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ImageFormats helper class is not used anymore and can be removed.\n\nSigned-off-by: Niklas Söderlund \n---\n include/libcamera/internal/formats.h | 14 -----\n src/libcamera/formats.cpp | 88 ----------------------------\n 2 files changed, 102 deletions(-)","diff":"diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\nindex f59ac8fe36a1623b..70c2f5cb5b7d5eb4 100644\n--- a/include/libcamera/internal/formats.h\n+++ b/include/libcamera/internal/formats.h\n@@ -18,20 +18,6 @@\n \n namespace libcamera {\n \n-class ImageFormats\n-{\n-public:\n-\tint addFormat(unsigned int format, const std::vector &sizes);\n-\n-\tbool isEmpty() const;\n-\tstd::vector formats() const;\n-\tconst std::vector &sizes(unsigned int format) const;\n-\tconst std::map> &data() const;\n-\n-private:\n-\tstd::map> data_;\n-};\n-\n class PixelFormatInfo\n {\n public:\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 436672e8bf4f8571..10830ceb9aae8f0c 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -22,94 +22,6 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(Formats)\n \n-/**\n- * \\class ImageFormats\n- * \\brief Describe V4L2Device and V4L2SubDevice image formats\n- *\n- * This class stores a list of image formats, each associated with a\n- * corresponding set of image sizes. It is used to describe the formats and\n- * sizes supported by a V4L2Device or V4L2Subdevice.\n- *\n- * Formats are stored as an integer. When used for a V4L2Device, the image\n- * formats are fourcc pixel formats. When used for a V4L2Subdevice they are\n- * media bus codes. Both are defined by the V4L2 specification.\n- *\n- * Sizes are stored as a list of SizeRange.\n- */\n-\n-/**\n- * \\brief Add a format and corresponding sizes to the description\n- * \\param[in] format Pixel format or media bus code to describe\n- * \\param[in] sizes List of supported size ranges for the format\n- *\n- * \\return 0 on success or a negative error code otherwise\n- * \\retval -EEXIST The format is already described\n- */\n-int ImageFormats::addFormat(unsigned int format, const std::vector &sizes)\n-{\n-\tif (data_.find(format) != data_.end())\n-\t\treturn -EEXIST;\n-\n-\tdata_[format] = sizes;\n-\n-\treturn 0;\n-}\n-\n-/**\n- * \\brief Check if the list of devices supported formats is empty\n- * \\return True if the list of supported formats is empty\n- */\n-bool ImageFormats::isEmpty() const\n-{\n-\treturn data_.empty();\n-}\n-\n-/**\n- * \\brief Retrieve a list of all supported image formats\n- * \\return List of pixel formats or media bus codes\n- */\n-std::vector ImageFormats::formats() const\n-{\n-\tstd::vector formats;\n-\tformats.reserve(data_.size());\n-\n-\t/* \\todo: Should this be cached instead of computed each time? */\n-\tfor (auto const &it : data_)\n-\t\tformats.push_back(it.first);\n-\n-\treturn formats;\n-}\n-\n-/**\n- * \\brief Retrieve all sizes for a specific format\n- * \\param[in] format The pixel format or mbus code\n- *\n- * Retrieve all size ranges for a specific format. For V4L2Device \\a format is a\n- * pixel format while for a V4L2Subdevice \\a format is a media bus code.\n- *\n- * \\return The list of image sizes supported for \\a format, or an empty list if\n- * the format is not supported\n- */\n-const std::vector &ImageFormats::sizes(unsigned int format) const\n-{\n-\tstatic const std::vector empty;\n-\n-\tauto const &it = data_.find(format);\n-\tif (it == data_.end())\n-\t\treturn empty;\n-\n-\treturn it->second;\n-}\n-\n-/**\n- * \\brief Retrieve the map that associates formats to image sizes\n- * \\return The map that associates formats to image sizes\n- */\n-const std::map> &ImageFormats::data() const\n-{\n-\treturn data_;\n-}\n-\n /**\n * \\class PixelFormatInfo\n * \\brief Information about pixel formats\n","prefixes":["libcamera-devel","RFC","2/2"]}