{"id":8526,"url":"https://patchwork.libcamera.org/api/1.1/patches/8526/?format=json","web_url":"https://patchwork.libcamera.org/patch/8526/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200701085356.3626-1-david.plowman@raspberrypi.com>","date":"2020-07-01T08:53:56","name":"[libcamera-devel] libcamera: ipa: raspberrypi: Enable focus measure without recompile","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d7ce711c7c87f024c33fe99d861562e8bade67d0","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8526/mbox/","series":[{"id":1065,"url":"https://patchwork.libcamera.org/api/1.1/series/1065/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1065","date":"2020-07-01T08:53:56","name":"[libcamera-devel] libcamera: ipa: raspberrypi: Enable focus measure without recompile","version":1,"mbox":"https://patchwork.libcamera.org/series/1065/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8526/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8526/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C19BBFFE2\n\tfor ;\n\tWed, 1 Jul 2020 08:54:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DDD8560C56;\n\tWed, 1 Jul 2020 10:54:04 +0200 (CEST)","from mail-wr1-x443.google.com (mail-wr1-x443.google.com\n\t[IPv6:2a00:1450:4864:20::443])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3EE5A603B3\n\tfor ;\n\tWed, 1 Jul 2020 10:54:03 +0200 (CEST)","by mail-wr1-x443.google.com with SMTP id z2so689033wrp.2\n\tfor ;\n\tWed, 01 Jul 2020 01:54:03 -0700 (PDT)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\t1sm6197348wmf.21.2020.07.01.01.54.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 01 Jul 2020 01:54:01 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"KKkvNYKi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=BsO267ETNeS74AYM6aDuR28sGVor9jgljacQk+YQ12o=;\n\tb=KKkvNYKio20LIzzesBwwfPg4ybx9N8PA4/vcwP8F+7hlc5V/PMiyNh7oQBjRSrzyRg\n\thBbVplC57Rniq/Naox8TiiwfTMxp4Cih5qhEf8YjBMqHANjZEZwUr3Wf6+2HQu2KxuSO\n\t8kB0/4sxPheQ8maGjP33W0jz1Q4FiBi1TgxT9whFmsZXzjFlDa+MeLLQPTEHuoH5vgn7\n\tCMapZLswuVhL3tqnyRcWTqMDKj0VUfYEnqW24Mjy0S3zMTAMZVXKJp5gPLh09vCLvFDG\n\tdqGdZkOWmEfPmEKCNK6kjjN5UUQOUdYBI7IFEWsuAgjABm3z4FHrBQDKfRpGqdRr5yfk\n\teDZQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=BsO267ETNeS74AYM6aDuR28sGVor9jgljacQk+YQ12o=;\n\tb=UH4+UKAZczXX+wWoU1WS2Hbnta9q3xDtCI3pYzHKPNI3sclTCND9LYTFvE17ZzYl+f\n\ti5aaRD8dTAPp9nn3MSDZuDy3k6SsX8k5dDzyw98AwEUOwxyxauoyFcLWm+I7UPL3sBBK\n\tgv6jYfUQBmoCOOe415+Hp5pSxfFfns1EDwC2vWjl7WPBMn8RU3IqyWRYLrFNhDrsSOwh\n\tTZofWF807i0nmY3eUoCMF25yDAhop3U+O+yftOe0VzkweX+5N+X7SzRZfgob1zKN+fD7\n\tsdNaHcY3kMFKaZQ36QNCaCYAFpv99bBnLUUPeXviggG3FcjFaOAklquziO7L7a+4AqrX\n\tAsrA==","X-Gm-Message-State":"AOAM532d+mahGvFUnIkp4to5LoVZjBVzTByoW8wkzIsFzQDkg6mCiRPq\n\tKRwwR1UjLTJZ8mQaronGLUig/EaB+bM=","X-Google-Smtp-Source":"ABdhPJynMH9IlFmLblQO5EHZJ9k2Rvz2xRDziYsGkYwsVn73P1np8uPsCi+dwrTrWeQxdRx8uErm+w==","X-Received":"by 2002:adf:8524:: with SMTP id\n\t33mr25532876wrh.366.1593593642240; \n\tWed, 01 Jul 2020 01:54:02 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 1 Jul 2020 09:53:56 +0100","Message-Id":"<20200701085356.3626-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] libcamera: ipa: raspberrypi: Enable focus\n\tmeasure without recompile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Previously output of the focus measure could be enabled without\nrecompiling (because of the RPI_LOGGING_ENABLE macro). Here we disable\nit in the imx477 tuning, but if re-enabled there it will now be output\nto the console (much more helpful behaviour).\n\nSigned-off-by: David Plowman \n---\n src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +-\n src/ipa/raspberrypi/data/imx477.json | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/focus.cpp b/src/ipa/raspberrypi/controller/rpi/focus.cpp\nindex 1e2b649..133ea6f 100644\n--- a/src/ipa/raspberrypi/controller/rpi/focus.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/focus.cpp\n@@ -39,7 +39,7 @@ void Focus::Process(StatisticsPtr &stats, Metadata *image_metadata)\n \timage_metadata->Set(\"focus.status\", status);\n \tif (print_) {\n \t\tuint32_t value = (status.focus_measures[5] + status.focus_measures[6]) / 10;\n-\t\tRPI_LOG(\"Focus contrast measure: \" << value);\n+\t\tstd::cout << \"Focus contrast measure: \" << value << std::endl;\n \t}\n }\n \ndiff --git a/src/ipa/raspberrypi/data/imx477.json b/src/ipa/raspberrypi/data/imx477.json\nindex 389e8ce..8976e31 100644\n--- a/src/ipa/raspberrypi/data/imx477.json\n+++ b/src/ipa/raspberrypi/data/imx477.json\n@@ -415,6 +415,6 @@\n },\n \"rpi.focus\":\n {\n-\t\"print\": 1\n+\t\"print\": 0\n }\n }\n","prefixes":["libcamera-devel"]}