{"id":8458,"url":"https://patchwork.libcamera.org/api/1.1/patches/8458/?format=json","web_url":"https://patchwork.libcamera.org/patch/8458/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200628001532.2685967-2-niklas.soderlund@ragnatech.se>","date":"2020-06-28T00:15:20","name":"[libcamera-devel,v2,01/13] libcamera: ipu3: Remove unused name_ filed from IPU3Stream","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0d1676463b2d41c594c840c7662f41b64fc05c28","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8458/mbox/","series":[{"id":1048,"url":"https://patchwork.libcamera.org/api/1.1/series/1048/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1048","date":"2020-06-28T00:15:19","name":"libcamera: ipu3: Refactoring of ImgU","version":2,"mbox":"https://patchwork.libcamera.org/series/1048/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8458/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8458/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD0A7C2E69\n\tfor ;\n\tSun, 28 Jun 2020 00:15:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 66D59609E1;\n\tSun, 28 Jun 2020 02:15:48 +0200 (CEST)","from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D534A609C5\n\tfor ;\n\tSun, 28 Jun 2020 02:15:45 +0200 (CEST)","from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 6e36aaf3-b8d4-11ea-86ee-0050569116f7;\n\tSun, 28 Jun 2020 02:15:11 +0200 (CEST)"],"X-Halon-ID":"6e36aaf3-b8d4-11ea-86ee-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 28 Jun 2020 02:15:20 +0200","Message-Id":"<20200628001532.2685967-2-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200628001532.2685967-1-niklas.soderlund@ragnatech.se>","References":"<20200628001532.2685967-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 01/13] libcamera: ipu3: Remove unused\n\tname_ filed from IPU3Stream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The field is never used, remove it.\n\nSigned-off-by: Niklas Söderlund \nReviewed-by: Jacopo Mondi \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ----\n 1 file changed, 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 6c43169eb0915965..fba45935741e0e4e 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -109,7 +109,6 @@ public:\n \n \tbool active_;\n \tbool raw_;\n-\tstd::string name_;\n \tImgUDevice::ImgUOutput *device_;\n };\n \n@@ -867,11 +866,8 @@ int PipelineHandlerIPU3::registerCameras()\n \t\t */\n \t\tdata->imgu_ = numCameras ? &imgu1_ : &imgu0_;\n \t\tdata->outStream_.device_ = &data->imgu_->output_;\n-\t\tdata->outStream_.name_ = \"output\";\n \t\tdata->vfStream_.device_ = &data->imgu_->viewfinder_;\n-\t\tdata->vfStream_.name_ = \"viewfinder\";\n \t\tdata->rawStream_.raw_ = true;\n-\t\tdata->rawStream_.name_ = \"raw\";\n \n \t\t/*\n \t\t * Connect video devices' 'bufferReady' signals to their\n","prefixes":["libcamera-devel","v2","01/13"]}