{"id":8449,"url":"https://patchwork.libcamera.org/api/1.1/patches/8449/?format=json","web_url":"https://patchwork.libcamera.org/patch/8449/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200627030043.2088585-8-niklas.soderlund@ragnatech.se>","date":"2020-06-27T03:00:37","name":"[libcamera-devel,07/13] libcamera: ipu3: imgu: Mark things that are internal as private","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f7057a74d4ddd3885f5f6cb2ef75ff5898832de0","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8449/mbox/","series":[{"id":1046,"url":"https://patchwork.libcamera.org/api/1.1/series/1046/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1046","date":"2020-06-27T03:00:30","name":"libcamera: ipu3: Refactoring of ImgU","version":1,"mbox":"https://patchwork.libcamera.org/series/1046/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8449/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8449/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 85AC0C2E66\n\tfor ;\n\tSat, 27 Jun 2020 03:00:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 30C4E60B0A;\n\tSat, 27 Jun 2020 05:00:59 +0200 (CEST)","from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8FB1D609C9\n\tfor ;\n\tSat, 27 Jun 2020 05:00:55 +0200 (CEST)","from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 57347ce0-b822-11ea-86ee-0050569116f7;\n\tSat, 27 Jun 2020 05:00:22 +0200 (CEST)"],"X-Halon-ID":"57347ce0-b822-11ea-86ee-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 27 Jun 2020 05:00:37 +0200","Message-Id":"<20200627030043.2088585-8-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200627030043.2088585-1-niklas.soderlund@ragnatech.se>","References":"<20200627030043.2088585-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 07/13] libcamera: ipu3: imgu: Mark things\n\tthat are internal as private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Mark all variables and functions that are only used internally as\nprivate.\n\nSigned-off-by: Niklas Söderlund \n---\n src/libcamera/pipeline/ipu3/imgu.h | 24 +++++++++++++-----------\n 1 file changed, 13 insertions(+), 11 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\nindex ad5aabf134e2099d..b6b08b4fef2d3a9d 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.h\n+++ b/src/libcamera/pipeline/ipu3/imgu.h\n@@ -24,11 +24,6 @@ struct StreamConfiguration;\n class ImgUDevice\n {\n public:\n-\tstatic constexpr unsigned int PAD_INPUT = 0;\n-\tstatic constexpr unsigned int PAD_OUTPUT = 2;\n-\tstatic constexpr unsigned int PAD_VF = 3;\n-\tstatic constexpr unsigned int PAD_STAT = 4;\n-\n \t/* ImgU output descriptor: group data specific to an ImgU output. */\n \tstruct ImgUOutput {\n \t\tV4L2VideoDevice *dev;\n@@ -64,20 +59,27 @@ public:\n \tint start();\n \tint stop();\n \n-\tint linkSetup(const std::string &source, unsigned int sourcePad,\n-\t\t const std::string &sink, unsigned int sinkPad,\n-\t\t bool enable);\n \tint enableLinks(bool enable);\n \n-\tstd::string name_;\n-\tMediaDevice *media_;\n-\n \tV4L2Subdevice *imgu_;\n \tV4L2VideoDevice *input_;\n \tImgUOutput output_;\n \tImgUOutput viewfinder_;\n \tImgUOutput stat_;\n \t/* \\todo Add param video device for 3A tuning */\n+\n+private:\n+\tstatic constexpr unsigned int PAD_INPUT = 0;\n+\tstatic constexpr unsigned int PAD_OUTPUT = 2;\n+\tstatic constexpr unsigned int PAD_VF = 3;\n+\tstatic constexpr unsigned int PAD_STAT = 4;\n+\n+\tint linkSetup(const std::string &source, unsigned int sourcePad,\n+\t\t const std::string &sink, unsigned int sinkPad,\n+\t\t bool enable);\n+\n+\tstd::string name_;\n+\tMediaDevice *media_;\n };\n \n } /* namespace libcamera */\n","prefixes":["libcamera-devel","07/13"]}