{"id":8402,"url":"https://patchwork.libcamera.org/api/1.1/patches/8402/?format=json","web_url":"https://patchwork.libcamera.org/patch/8402/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200624145256.48266-5-paul.elder@ideasonboard.com>","date":"2020-06-24T14:52:38","name":"[libcamera-devel,v4,04/22] v4l2: v4l2_camera_proxy: Free old buffers on reqbufs > 0","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"75157da90ff8a5a397a874eab7762b0666369ee9","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8402/mbox/","series":[{"id":1041,"url":"https://patchwork.libcamera.org/api/1.1/series/1041/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1041","date":"2020-06-24T14:52:34","name":"Support v4l2-compliance","version":4,"mbox":"https://patchwork.libcamera.org/series/1041/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8402/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8402/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7FCDD609B3\n\tfor ;\n\tWed, 24 Jun 2020 16:53:25 +0200 (CEST)","from jade.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:8147:f2a2:a8c6:9087])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A550D2A8;\n\tWed, 24 Jun 2020 16:53:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"mRhdKTve\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593010405;\n\tbh=fjl37sOhCxIzztCUNmlsV53bSzFFBIYNv4n3UqLHj2g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mRhdKTveI1gEjg88bDeWeGevig9ovGw7XYGA4vo7dcn0Qm7qdwZoom0GCNSXMhMa8\n\tnJ0Y7LdylzNAPxYeFf0TnQg33FdOMJIVG+6PhIh+RqS+J7y+E5eT4bwzH/GkrmGrWd\n\t9GhIy40oWxgWCr8ScUWkAREN0rCiu/0NA64F3NVs=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 24 Jun 2020 23:52:38 +0900","Message-Id":"<20200624145256.48266-5-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200624145256.48266-1-paul.elder@ideasonboard.com>","References":"<20200624145256.48266-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 04/22] v4l2: v4l2_camera_proxy: Free\n\told buffers on reqbufs > 0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 24 Jun 2020 14:53:25 -0000"},"content":"Free buffers, if any were previously allocated, at VIDIOC_REQBUFS with\ncount > 0.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \n\n---\nChanges in v4:\n- don't check return value of V4L2CameraProxy::freeBuffers()\n\nNew in v3\n- split from... a conglomerate of v4l2-compliance fixes patch\n---\n src/v4l2/v4l2_camera_proxy.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 240420c..c6959a8 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -359,6 +359,9 @@ int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *file, struct v4l2_requestbuf\n \t\treturn 0;\n \t}\n \n+\tif (bufferCount_ > 0)\n+\t\tfreeBuffers();\n+\n \tSize size(curV4L2Format_.fmt.pix.width, curV4L2Format_.fmt.pix.height);\n \tint ret = vcam_->configure(&streamConfig_, size,\n \t\t\t\t v4l2ToDrm(curV4L2Format_.fmt.pix.pixelformat),\n","prefixes":["libcamera-devel","v4","04/22"]}