{"id":834,"url":"https://patchwork.libcamera.org/api/1.1/patches/834/?format=json","web_url":"https://patchwork.libcamera.org/patch/834/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190402005332.25018-4-niklas.soderlund@ragnatech.se>","date":"2019-04-02T00:53:30","name":"[libcamera-devel,RFC,3/5] test: camera: Remove test for bad Stream IDs","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"88d955343ab5dd8322a76b1af6bf136571071d35","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/834/mbox/","series":[{"id":227,"url":"https://patchwork.libcamera.org/api/1.1/series/227/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=227","date":"2019-04-02T00:53:27","name":"libcamera: camera: Add support for stream usage hint","version":1,"mbox":"https://patchwork.libcamera.org/series/227/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/834/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/834/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 276B8610BF\n\tfor ;\n\tTue, 2 Apr 2019 02:54:01 +0200 (CEST)","from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid cda2301d-54e1-11e9-846a-005056917a89;\n\tTue, 02 Apr 2019 02:54:00 +0200 (CEST)"],"X-Halon-ID":"cda2301d-54e1-11e9-846a-005056917a89","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 2 Apr 2019 02:53:30 +0200","Message-Id":"<20190402005332.25018-4-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190402005332.25018-1-niklas.soderlund@ragnatech.se>","References":"<20190402005332.25018-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC 3/5] test: camera: Remove test for bad\n\tStream IDs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Apr 2019 00:54:01 -0000"},"content":"In preparation of reworking how a default configuration is retrieved\nfrom a camera remove test that stream IDs must be valid as the data type\npassed to Camera::streamConfiguration() will change. This change is in\npreparation for a invasive change.\n\nSigned-off-by: Niklas Söderlund \n---\n test/camera/configuration_default.cpp | 13 -------------\n 1 file changed, 13 deletions(-)","diff":"diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp\nindex 53ee021d33ca39b1..856cd415f7a6aec1 100644\n--- a/test/camera/configuration_default.cpp\n+++ b/test/camera/configuration_default.cpp\n@@ -49,19 +49,6 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n-\t\t/*\n-\t\t * Test that asking for configuration for an array of bad streams\n-\t\t * returns an empty list of configurations.\n-\t\t */\n-\t\tStream *stream_bad = reinterpret_cast(0xdeadbeef);\n-\t\tstd::set streams_bad = { stream_bad };\n-\t\tconf = camera_->streamConfiguration(streams_bad);\n-\t\tif (!conf.empty()) {\n-\t\t\tcout << \"Failed to retrieve configuration for bad streams\"\n-\t\t\t << endl;\n-\t\t\treturn TestFail;\n-\t\t}\n-\n \t\treturn TestPass;\n \t}\n };\n","prefixes":["libcamera-devel","RFC","3/5"]}