{"id":754,"url":"https://patchwork.libcamera.org/api/1.1/patches/754/?format=json","web_url":"https://patchwork.libcamera.org/patch/754/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190320163055.22056-9-jacopo@jmondi.org>","date":"2019-03-20T16:30:32","name":"[libcamera-devel,v4,08/31] libcamera: ipu3: Implement camera start/stop","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"00ad4aef2ba1757a9f986901e0b1693f589a9f3a","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/754/mbox/","series":[{"id":214,"url":"https://patchwork.libcamera.org/api/1.1/series/214/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=214","date":"2019-03-20T16:30:24","name":"libcamera: ipu3: Add ImgU support + multiple streams","version":4,"mbox":"https://patchwork.libcamera.org/series/214/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/754/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/754/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FA3F611B4\n\tfor ;\n\tWed, 20 Mar 2019 17:30:33 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id B04D8200008;\n\tWed, 20 Mar 2019 16:30:32 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 20 Mar 2019 17:30:32 +0100","Message-Id":"<20190320163055.22056-9-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190320163055.22056-1-jacopo@jmondi.org>","References":"<20190320163055.22056-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 08/31] libcamera: ipu3: Implement\n\tcamera start/stop","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 20 Mar 2019 16:30:33 -0000"},"content":"Start and stop video devices in the pipeline.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 54 ++++++++++++++++++++++++----\n 1 file changed, 48 insertions(+), 6 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 2975c218f6c9..994c95692dd4 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -334,12 +334,52 @@ int PipelineHandlerIPU3::freeBuffers(Camera *camera, Stream *stream)\n int PipelineHandlerIPU3::start(Camera *camera)\n {\n \tIPU3CameraData *data = cameraData(camera);\n-\tV4L2Device *cio2 = data->cio2.output;\n \tint ret;\n \n-\tret = cio2->streamOn();\n+\t/*\n+\t * Enqueue all available buffers to the CIO2 unit to start frame\n+\t * capture. Start ImgU video devices and queue buffers to the output\n+\t * ones at queueRequest() time.\n+\t */\n+\tfor (Buffer &buffer : data->cio2.pool.buffers()) {\n+\t\tret = data->cio2.output->queueBuffer(&buffer);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\t}\n+\n+\tret = data->cio2.output->streamOn();\n \tif (ret) {\n-\t\tLOG(IPU3, Info) << \"Failed to start camera \" << camera->name();\n+\t\tLOG(IPU3, Error) << \"Failed to start CIO2\";\n+\t\tstop(camera);\n+\t\treturn ret;\n+\t}\n+\n+\t/* Start the ImgU video devices. */\n+\tret = data->imgu->output->streamOn();\n+\tif (ret) {\n+\t\tLOG(IPU3, Error) << \"Failed to start ImgU output\";\n+\t\tstop(camera);\n+\t\treturn ret;\n+\t}\n+\n+\tret = data->imgu->viewfinder->streamOn();\n+\tif (ret) {\n+\t\tLOG(IPU3, Error) << \"Failed to start ImgU viewfinder\";\n+\t\tstop(camera);\n+\t\treturn ret;\n+\t}\n+\n+\tret = data->imgu->stat->streamOn();\n+\tif (ret) {\n+\t\tLOG(IPU3, Error) << \"Failed to start ImgU stat\";\n+\t\tstop(camera);\n+\t\treturn ret;\n+\t}\n+\n+\tret = data->imgu->input->streamOn();\n+\tif (ret) {\n+\t\tLOG(IPU3, Error) << \"Failed to start ImgU input\";\n+\t\tstop(camera);\n \t\treturn ret;\n \t}\n \n@@ -349,10 +389,12 @@ int PipelineHandlerIPU3::start(Camera *camera)\n void PipelineHandlerIPU3::stop(Camera *camera)\n {\n \tIPU3CameraData *data = cameraData(camera);\n-\tV4L2Device *cio2 = data->cio2.output;\n \n-\tif (cio2->streamOff())\n-\t\tLOG(IPU3, Info) << \"Failed to stop camera \" << camera->name();\n+\tdata->cio2.output->streamOff();\n+\tdata->imgu->output->streamOff();\n+\tdata->imgu->viewfinder->streamOff();\n+\tdata->imgu->stat->streamOff();\n+\tdata->imgu->input->streamOff();\n \n \tPipelineHandler::stop(camera);\n }\n","prefixes":["libcamera-devel","v4","08/31"]}