{"id":727,"url":"https://patchwork.libcamera.org/api/1.1/patches/727/?format=json","web_url":"https://patchwork.libcamera.org/patch/727/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190312121242.2253-13-jacopo@jmondi.org>","date":"2019-03-12T12:12:40","name":"[libcamera-devel,v2,12/14] libcamera: ipu3: Use NV12 as default image format","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2c453aea996d0d16e9f6cd0f769fc292c472c97e","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/727/mbox/","series":[{"id":205,"url":"https://patchwork.libcamera.org/api/1.1/series/205/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=205","date":"2019-03-12T12:12:28","name":"libcamera: ipu3: ImgU support","version":2,"mbox":"https://patchwork.libcamera.org/series/205/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/727/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/727/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA4F5612E8\n\tfor ;\n\tTue, 12 Mar 2019 13:12:26 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 61BEC1C0002;\n\tTue, 12 Mar 2019 12:12:26 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 12 Mar 2019 13:12:40 +0100","Message-Id":"<20190312121242.2253-13-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190312121242.2253-1-jacopo@jmondi.org>","References":"<20190312121242.2253-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 12/14] libcamera: ipu3: Use NV12 as\n\tdefault image format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 12 Mar 2019 12:12:27 -0000"},"content":"Now that images come from the ImgU output, hardcode NV12 as default\noutput format.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 4d08383291ea..f998f900b219 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -190,6 +190,7 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n \tIPU3CameraData *data = cameraData(camera);\n \tV4L2Subdevice *sensor = data->cio2.sensor;\n \tStreamConfiguration *config = &configs[&data->stream_];\n+\tbool found = false;\n \n \t/*\n \t * Make sure the sensor produces a raw format compatible with the\n@@ -208,17 +209,18 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n \n \t\t\tconfig->width = range.maxWidth;\n \t\t\tconfig->height = range.maxHeight;\n-\t\t\tconfig->pixelFormat = cio2Code;\n+\t\t\tfound = true;\n \t\t}\n \t}\n \n \t/* If not suitable format has been found, return an empty config. */\n-\tif (!config->pixelFormat) {\n+\tif (!found) {\n \t\tLOG(IPU3, Error) << \"Sensor image format not supported\";\n \n \t\treturn configs;\n \t}\n \n+\tconfig->pixelFormat = V4L2_PIX_FMT_NV12;\n \tconfig->bufferCount = IPU3_BUFFER_COUNT;\n \n \tLOG(IPU3, Debug)\n","prefixes":["libcamera-devel","v2","12/14"]}