{"id":708,"url":"https://patchwork.libcamera.org/api/1.1/patches/708/?format=json","web_url":"https://patchwork.libcamera.org/patch/708/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190306024755.28726-5-niklas.soderlund@ragnatech.se>","date":"2019-03-06T02:47:54","name":"[libcamera-devel,4/5] test: camera: Add capture test","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4991f800cb6e1cdf68d478f8243ce374f9aa45e6","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/708/mbox/","series":[{"id":203,"url":"https://patchwork.libcamera.org/api/1.1/series/203/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=203","date":"2019-03-06T02:47:50","name":"test: camera: Add basic tests for the camera","version":1,"mbox":"https://patchwork.libcamera.org/series/203/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/708/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/708/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 18231611A8\n\tfor ;\n\tWed, 6 Mar 2019 03:48:22 +0100 (CET)","from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 4d650ea3-3fba-11e9-985a-005056917f90;\n\tWed, 06 Mar 2019 03:48:21 +0100 (CET)"],"X-Halon-ID":"4d650ea3-3fba-11e9-985a-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 6 Mar 2019 03:47:54 +0100","Message-Id":"<20190306024755.28726-5-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190306024755.28726-1-niklas.soderlund@ragnatech.se>","References":"<20190306024755.28726-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 4/5] test: camera: Add capture test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 06 Mar 2019 02:48:22 -0000"},"content":"Add positive capture test. Correctly configure the camera using the\ndefault format and run a capture session for 100 milliseconds, which is\nplenty of time, in tests over 600 requests completed using the vimc\npipeline.\n\nThe test passes if at least one requests completes.\n\nSigned-off-by: Niklas Söderlund \n---\n test/camera/capture.cpp | 130 ++++++++++++++++++++++++++++++++++++++++\n test/camera/meson.build | 1 +\n 2 files changed, 131 insertions(+)\n create mode 100644 test/camera/capture.cpp","diff":"diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\nnew file mode 100644\nindex 0000000000000000..133b38318e471f3f\n--- /dev/null\n+++ b/test/camera/capture.cpp\n@@ -0,0 +1,130 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * libcamera Camera API tests\n+ */\n+\n+#include \n+\n+#include \"camera_test.h\"\n+\n+using namespace std;\n+\n+namespace {\n+\n+class Capture : public CameraTest\n+{\n+protected:\n+\tunsigned int count_buffers_;\n+\tunsigned int count_requests_;\n+\n+\tvoid bufferComplete(Request *request, Buffer *buffer)\n+\t{\n+\t\tcount_buffers_++;\n+\t}\n+\n+\tvoid requestComplete(Request *request, const std::map &buffers)\n+\t{\n+\t\tif (request->status() == Request::RequestCancelled)\n+\t\t\treturn;\n+\n+\t\tcount_requests_++;\n+\n+\t\t/* Reuse the buffers for a new request. */\n+\t\trequest = camera_->createRequest();\n+\t\trequest->setBuffers(buffers);\n+\t\tcamera_->queueRequest(request);\n+\t}\n+\n+\tint run()\n+\t{\n+\t\tif (camera_->acquire()) {\n+\t\t\tcout << \"Acquiring the camera failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tStream *stream = *camera_->streams().begin();\n+\t\tstd::set streams = { stream };\n+\t\tstd::map conf =\n+\t\t\tcamera_->streamConfiguration(streams);\n+\t\tif (conf.size() != 1) {\n+\t\t\tcout << \"Reading default format failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (camera_->configureStreams(conf)) {\n+\t\t\tcout << \"Setting valid format failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (camera_->allocateBuffers()) {\n+\t\t\tcout << \"Allocating buffers failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tBufferPool &pool = stream->bufferPool();\n+\t\tstd::vector requests;\n+\t\tfor (Buffer &buffer : pool.buffers()) {\n+\t\t\tRequest *request = camera_->createRequest();\n+\t\t\tif (!request) {\n+\t\t\t\tcout << \"Creating request failed\" << endl;\n+\t\t\t\treturn TestFail;\n+\t\t\t}\n+\n+\t\t\tstd::map map = { { stream, &buffer } };\n+\t\t\tif (request->setBuffers(map)) {\n+\t\t\t\tcout << \"Associating buffer with request failed\" << endl;\n+\t\t\t\treturn TestFail;\n+\t\t\t}\n+\n+\t\t\trequests.push_back(request);\n+\t\t}\n+\n+\t\tif (camera_->start()) {\n+\t\t\tcout << \"Starting camera failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tfor (Request *request : requests) {\n+\t\t\tif (camera_->queueRequest(request)) {\n+\t\t\t\tcout << \"Queueing request failed\" << endl;\n+\t\t\t\treturn TestFail;\n+\t\t\t}\n+\t\t}\n+\n+\t\tcamera_->bufferCompleted.connect(this, &Capture::bufferComplete);\n+\t\tcamera_->requestCompleted.connect(this, &Capture::requestComplete);\n+\n+\t\tcount_requests_ = 0;\n+\t\tcount_buffers_ = 0;\n+\n+\t\tEventDispatcher *dispatcher = CameraManager::instance()->eventDispatcher();\n+\n+\t\tTimer timer;\n+\t\ttimer.start(100);\n+\t\twhile (timer.isRunning())\n+\t\t\tdispatcher->processEvents();\n+\n+\t\tif (!count_requests_ || !count_buffers_) {\n+\t\t\tcout << \"Capture failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (camera_->stop()) {\n+\t\t\tcout << \"Stopping camera failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (camera_->freeBuffers()) {\n+\t\t\tcout << \"Freeing buffers failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\treturn TestPass;\n+\t}\n+};\n+\n+} /* namespace */\n+\n+TEST_REGISTER(Capture);\ndiff --git a/test/camera/meson.build b/test/camera/meson.build\nindex f5f27c4229ac307f..6da297714f34a4e3 100644\n--- a/test/camera/meson.build\n+++ b/test/camera/meson.build\n@@ -3,6 +3,7 @@\n camera_tests = [\n [ 'format_default', 'format_default.cpp' ],\n [ 'format_set', 'format_set.cpp' ],\n+ [ 'capture', 'capture.cpp' ],\n ]\n \n foreach t : camera_tests\n","prefixes":["libcamera-devel","4/5"]}